From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751345AbdI1Ss6 (ORCPT ); Thu, 28 Sep 2017 14:48:58 -0400 Received: from mail-co1nam03on0050.outbound.protection.outlook.com ([104.47.40.50]:49504 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750775AbdI1Ssz (ORCPT ); Thu, 28 Sep 2017 14:48:55 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Tom Lendacky , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski Subject: Re: [Part1 PATCH v5 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support To: Borislav Petkov References: <20170927151329.70011-1-brijesh.singh@amd.com> <20170927151329.70011-3-brijesh.singh@amd.com> <20170928090242.ber7gynwaldinafa@pd.tnic> From: Brijesh Singh Message-ID: Date: Thu, 28 Sep 2017 13:48:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170928090242.ber7gynwaldinafa@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR08CA0075.namprd08.prod.outlook.com (10.172.143.141) To CY1PR12MB0150.namprd12.prod.outlook.com (10.161.173.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04cadb40-d97d-4e83-63fc-08d506a1912c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR12MB0150; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0150;3:W3Y1l/iqRP4gyq0IeyNGAXgPUqvjMiN01uEsvtW4Dbf6ltzXnefeTOSpxIcUwEn7qCQK7o5twjVp+pzfI90Br358KHSPPvAFP6a12cgX9DAsjb2MzV8qDaeUr7HjpLuAv9HMnowa2sXGXr4Y7qC4OjE6bbrhVu58F1UJ8Fan9zPY7cbAxisM4rINUTzxN3pUDCcePpGtXdgDcctEWLrQuHXWE3f2V4z/pR35Uc6IV3rnlovrYZMFDZGvcBE1Bdw1;25:ios3s3I0+AzHf3A1Hot9W4LHC05WWHlDEfulJtNfvkXd9z9v5+i/w+FN3ZwWMSy6NtG4P3RY2kilLXkEnfaKmppWv+oasvxYVoUw8WbQSEvFooKrFX5y+IBFvh+VmwNdz8rdOFcBnbZZdFIJz223RWtdiCBV2xP+Jp9QFC4JOGFA0j6ak/nrpaw+RyewFv2rEIw/BoLrKdTvDJMpPhcbitSKr8HHfEVUTNxsTpa5v5Y19to3aS4JNxqojoh9ZUY6zmdHOv5z3VmE/Hin0lyh3CIpVesFyPWiPOnLgWLoJ04CmMPH87InriULiUmjm4dDR05PNyS7c5A0gIaEQzGWOg==;31:Al1FzfS6xGo2HYNyWDGbCqAJjZNc7pOKumv+lJ6zp+nAZSYKtwYee8hkjCSRJZUoFNtuKhHMpZy0eAfKIrPJRsGDCFNs/0ah3FEDKzTqhjOR1Ev3y9JJG/fkmad1JE9ynDQM97GfXQYytyKvEdPKkXG9dAmeYZHewb5x2xirYHcX/t/UIS4DPqJkK6gek6Vn0KLr/luW8Gi6FUb8BscqkDcbSyOy+MF6p97+doe7DNM= X-MS-TrafficTypeDiagnostic: CY1PR12MB0150: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0150;20:snRWSyfrnmIlqjwfNvgaeovR1g6RT2bmWrOgebhdS/spXX/SCdbb2zgbIDU280eA1NJkfb92YaS4zV9oaAI/P4Vwc45h67tgPlAcFucQLnWdugCMm7AIWLpHeW2zTbg5hveRNk8xQs2dM3fcFC4wj7wXHTbfcTF7S4aYS3ow6ZSBdNfsvbS3qvmnbvhmcf0gCYaDOEcnU9DD1VbPvxPBdddU269yKaURQAE9CD3CKtoY9qATqHdGJHntQMXwOPNwVpKhEW+TKloLkaTTqsKaLtCmA/qpsPjRAntrRljVP/x40XEpwG9bdQ5yPLKWNRbOFvciQ9h00lf7tG3ctiv6HLAhBcNO2mDr1pROD7EnVnFH0ZldpWYMv8RG+PUw8D01Zj9P816ro3gBaacsp8Ou5VZQqHDB/VCD9R5ULpHKm//urcC51FpJGhLf1OwcxD7YVCseu/TQPKTvjps0o3gn/Y1dipt6jFn0JDlwp8tLocD2hTSAh/Lu2hzsoz365YRI;4:uvqQO1KSjChMaHd0GXhoWKEzjrqHzX71oddQnX4Jvlx0wekmQKwr50FpI01C0x/Dedj3Q/aHXkgZytuLufXTQRJam+8dQDU67cf8uO5tB50kmL5O9xjT9gK13HYo6CdQuatNqujh3D4QXsil8mnLFi3zX6e9dOmlzrcOtXc9pErid5pGS45ATPoQobObiixotrCzZbk0glKR51mrH79ymQdmEK5ptH5xAQPFQ4Gc3C9jqrFzi4UMo9Q210oE/j3T X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0150;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0150; X-Forefront-PRVS: 0444EB1997 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(376002)(39860400002)(346002)(189002)(199003)(24454002)(377454003)(966005)(6246003)(16576012)(105586002)(316002)(36756003)(90366009)(58126008)(305945005)(7736002)(106356001)(16526017)(6916009)(2950100002)(50466002)(81166006)(8676002)(8936002)(77096006)(101416001)(97736004)(6666003)(230700001)(53546010)(83506001)(229853002)(47776003)(86362001)(65806001)(4326008)(5660300001)(6486002)(50986999)(478600001)(66066001)(65956001)(31696002)(189998001)(76176999)(65826007)(31686004)(23676002)(54906003)(33646002)(3846002)(6116002)(25786009)(53936002)(64126003)(68736007)(6306002)(2906002)(81156014)(54356999)(6606295002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0150;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUwOzIzOk43Q1lqaktpdldIZnJ4Z0ozd3IrcDN4Z0tH?= =?utf-8?B?SXpsK3F2dC9Pb2lOV0VTTkdQVjJpU1Jmby9qZlBJaFE2Zit6dFdXNm9qN3hw?= =?utf-8?B?czhpS0kvejFlaVVDa01rbTExQ1ZoZGlHY2VJdkhyZ2RqMWI5TkJJdEtSOWh3?= =?utf-8?B?L0c0TVpuY2ZrZTlIZGpZOHN0dng0VzR5eks2Znk5Y0l3YWNYUVFyZWQrQm1v?= =?utf-8?B?MDJMQlllYzgrR0UwTCt6NnY2OUZ1eTNHZ2NhSXJ6Q2hCTnNUVjU2L29tOTZT?= =?utf-8?B?YVhmVklybFdrcmI0RU9qazZtTXpvS1Y5SDlueUYrZjRJdkl0UTgwb2k0M3BO?= =?utf-8?B?VnNzVGVaYktsS25uTTJLR1Z4NGRJSE9PcjJCQ2RGRVBOSCt1ekJBRVdlTFVp?= =?utf-8?B?YjRTSWFWNHNpeTMySmJEU2tOcWh0SEhGZURGVkxrV0szZCtETFRxSFlKTWxQ?= =?utf-8?B?dVRaOHVDa0EyTmluZncyQVpMK3ZSL1Z3NlRPWDRWNUhMTXgvSDZDV2c0OEpo?= =?utf-8?B?cFExTE02ajBpY2tiYmRWK2QyZDVuSTl2azVxQW5YTVpqNmxEMlFNUHRyQUl6?= =?utf-8?B?bWFKYjUzbFlHVEc3QWNuNGIvbE9PUVpLS01tMXgyOHVBU0h2NVI0VURUV0JB?= =?utf-8?B?dkt6SVdnbGZEd1ZySU9IMzhJYlFwTUJwbjV2TDZPM2NjcFdOdlZkK2lFNGtE?= =?utf-8?B?bGZEVnN2MXpOZWVFZ0NqZnpaam1mc0ZVUlpobVVCVXppUHg4OUMyeHEvMWd2?= =?utf-8?B?K2RhUnRqVDJQakRZNi9iTVpGNVpXSzQ2TjA0NmpEUjU0OCtXSldOTE5YdFRS?= =?utf-8?B?bU5MUmEzdWlQdG5hSTFHRlRGNHNxcnNsdFdQcVp4eFdkRmZEcFV3YXBPTy93?= =?utf-8?B?cDlzaXI3b29MRzhkVE9XeFNKbHVXbXBBUzdlRE02K0kzVFRiK25VUnlvNVlq?= =?utf-8?B?cHdMYWdPWVRQc2tZd0VRVk1XcGJ3dHhFTnl5L2VOcUNTVFlMK2VDaEFmSjZy?= =?utf-8?B?NUFMN3JzUlI4blpNSm1PNGtOVFFma3czTmRUTzdTM0ZWbHZvNFRrdDZoK29j?= =?utf-8?B?YTBVaE1rRnFhTjVUVlAvbXRrRytrc1pJL0dEanVacnpIY1lyRkcvNHRldVJ2?= =?utf-8?B?RkRXdWUza3k4VEFrTUtSZjB4bVhrMkNoTnhFS0cvbmhRc0pZdUVxUW85Nk40?= =?utf-8?B?aHRUdVJMY3RkOHRYMWw0dVZQRDVRQjVHb1dCRnV0SG96UitYM2ZEdkl0M25m?= =?utf-8?B?elhKY3ArajZOSWxnTit1blBjU2szNXR6NllKWTJXRVFSZGU5RkNCUnNoRXZF?= =?utf-8?B?N1RHNkZFdFQvaVJISEx0TlRzRi9WWWY5dCtxL2YvZEtCVEZhNHhTVFNZSFA1?= =?utf-8?B?TEhsbGVuVURRRkgwTW9EaXlSWEZ0NTdYYmMvRU1oYVFHY1JmZEdiOERWdVB0?= =?utf-8?B?djVTRTdJRGlHazBsODVCanZaS08yMERjZEZ5djNjbHF3bHV3K0VPWDJ0YXVU?= =?utf-8?B?Unl0azBhUm85VzhPNHpHVklRWjV1dlBkZ0wwUlBnd1ByaXFaYlVld1lMQkxM?= =?utf-8?B?R0h4RFNXbEUyZFEvb04xS2oyeFJQU1FuenNuSlNhOXJJSVhSai9qQWJwN3VL?= =?utf-8?B?QWR4L0Vicm9sNGc5c3NYazBUTk1PaG1jdGJybjJrRjFhTDg5RzBFVTBaZjdk?= =?utf-8?B?NTZ3RVdjdnpsUGpMejE1T0VCS01PNkJYaW8wTHU1TUdDZ0g1bVVmOUd6bHJn?= =?utf-8?B?elFCc09wMGxaZ2xyeHBHWXhEUzJjZ0xEemRadXhJQlJSR2ZjRWhDeENlN0g1?= =?utf-8?B?Uk5hTDduSHRzNWFTQWp6UmVRWmdFdStic295SERWSmhEVnMwTHo4NXBId1hh?= =?utf-8?B?S0MxVmtmZTJrRzI3TXU5WW1Iek1hMzZVOU5veDFIOUF2M2cvSVRUbEVYRVpU?= =?utf-8?B?bkZYM0w0OWFkcWc5TlUwM0NySU01aW9zUWZkendURUo1Y2hvd3p2MzZTaUNa?= =?utf-8?Q?EV+8lW?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0150;6:vt9Kga3n1LEA15HgaANCM/wAV0ymvnoB4SPFOz133AxXNQryy3eC2Fhp0/G5ktFNKb6pJOWuMMmt/SoeO49HGHHT1dJKMWqO1jIHE0OrIJTndOHFKFMn1Y+lyH9DQCCSU0sLC1xG+6QCVynjvB8dRldeH61igk+2tTAKal7HmJwxqXyj/MmOvLNd9erWR1dVZkdaXWPEl7uufVRRS0RCcJXDVY9K79UKoXyxXwvvKwNQaIyRkOUztr+JCU8sBKPYNQdileNi4eJyljAw/XiWSp1qxKTTwZ3oL05E5VcBmKB6cmmMK8f8aSKYE/7h7OkWaTwMWk+5BbuxHZyKs/Wqow==;5:lR+438+fq2NuvosUTIPykIyZMdvAft40rTWB7w6+rmn+R0dP8WgvLEKGaCQBIpYAPT+9tVhJBRoWkZz4TX/NomHJlQnREuhVxxPS0sb6atFwt39bymsGEhKGLun8SumD7HU7A6QD8aIvuUufVw6mPg==;24:kFI+cAcVhcfcZW6jkFoQmJzBIfA5TWJmDYLkeUjKu1etKE5rV/hMA6w8hD6e9zjED8W2uN8UYzOXIcFOMFxRJCHQORIYiHS0jkofz77LQNU=;7:I1EhpYFEvkq/gIUeAVDY1rEXYiyTyQbUpCw/Yym//QbnSoXqy4PTI0zIFME50YcSbsZ6fAuhZOPBUj3ylwbUxEbeUUaxZjAhoox66zqMbZCc2Mwr9Qd1D7ppc5Ujt9Xpa6KN2Xdq4JPgKMDw/pGn6FsSzP/B57eJYIXng2lhlSYwr819IerMOaHnVyFFe2wRg+wWTv2LRCT9li4nrsjEsy5PGPvu/dljl7ysNjOsUjQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0150;20:WOMsiPVoucCeVXEp5jfXO/zjVmChgr28RLb2bItuctCMqbmLL35mccPxG2E9TqUsIw6OwqdcCOhXFKbr211iOC0J6trsuKrmaOSf8tLgyuzC/m7hUEQIek1Zv0MC1/m2wVCMjhxGyYzqs37GXiSRARSCfLpKBGH+HAEqV8IR03Qw+KZzyv32gnpwYYBXOc8VawrRPEEwGe3rNRNui4RBwBnhDpL6uJHt0+y/bTmEGznmLT18zFf0UdeF/Fad2Rpa X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2017 18:48:52.3993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0150 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 09/28/2017 04:02 AM, Borislav Petkov wrote: ... >> +bool sev_active(void) >> +{ >> + return sme_me_mask && sev_enabled; > > What I'm still missing is the chicken bit. I.e., to be able to boot with > "mem_encrypt=smeonly" or so, which disables the SEV side but can still > allow SME. For when SEV has issues and people want to disable it. > Let me understand the ask, are you saying that we need a method to disable the SEV feature from the host OS so that Hypervisor will not be able to create a SEV guest? Because once a guest is booted with SEV feature, there is no way to disable the SEV feature from the guest. i.e if "mem_encrypt=smeonly" is set then we clear X86_FEATURE_SEV capability flag defined in [1]. [1] https://marc.info/?l=linux-kernel&m=150585470323923&w=2 > You can do the patch ontop of those and send it as a reply to this > thread - no need to wait to resend the whole thing again. >