From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51799C43382 for ; Tue, 25 Sep 2018 20:21:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03A6320880 for ; Tue, 25 Sep 2018 20:21:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03A6320880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbeIZCbG (ORCPT ); Tue, 25 Sep 2018 22:31:06 -0400 Received: from smtprelay0016.hostedemail.com ([216.40.44.16]:54898 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726042AbeIZCbF (ORCPT ); Tue, 25 Sep 2018 22:31:05 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 4390918224D82; Tue, 25 Sep 2018 20:21:48 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: north82_83e34cca32b26 X-Filterd-Recvd-Size: 2797 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Tue, 25 Sep 2018 20:21:46 +0000 (UTC) Message-ID: Subject: Re: [PATCH net-next v6 02/23] zinc: introduce minimal cryptography library From: Joe Perches To: "Jason A. Donenfeld" Cc: LKML , Netdev , Linux Crypto Mailing List , David Miller , Greg Kroah-Hartman , Samuel Neves , Andrew Lutomirski , Jean-Philippe Aumasson Date: Tue, 25 Sep 2018 13:21:45 -0700 In-Reply-To: References: <20180925145622.29959-1-Jason@zx2c4.com> <20180925145622.29959-3-Jason@zx2c4.com> <2b5f2df2f1278c118a913259a44efdf589719293.camel@perches.com> <748429eee2fc77afd01630c24bd2cf66a545aec5.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-09-25 at 22:12 +0200, Jason A. Donenfeld wrote: > Hi Joe, > > On Tue, Sep 25, 2018 at 10:05 PM Joe Perches wrote: > > As far as I can tell, zinc doesn't use pr_err, just > > pr_info > > Yes, pr_info, not pr_err. Apologies for my imprecision. But the > distinction does not matter at all, since they both use pr_fmt in > exactly the same way, which is sufficient for the purposes of this > discussion. > > > > why can't I just do this from the makefile, since > > > I want that same pr_fmt to copy the whole directory? > > > > Ideally all of those > > > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > > > uses will be removed one day soon and the default > > will change. > > > > https://lore.kernel.org/patchwork/cover/904507/ > > > > This slightly odd use might complicate that. > > Oh, that's good to see. In this case, I'm prefixing all of them with > zinc: instead of zinc_chacha20: (the modname), but I wouldn't object > to that changing to KBUILD_MODNAME if your patch lands. IOW, once your > patch lands, I'm happy to revisit this discussion and fall back to > using the sane defaults you're in the process of setting up for > everyone. I'd still prefer as all these are effectively debugging output that you convert the pr_info uses pr_debug and so avoid using pr_fmt altogether.