From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752600AbdBAP7K (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Feb 2017 10:59:10 -0500
Received: from mx08-00178001.pphosted.com ([91.207.212.93]:49217 "EHLO
        mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1750953AbdBAP7J (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Feb 2017 10:59:09 -0500
Subject: Re: [PATCH 6/8] Documentation: dt: Add new compatible to STM32
 pinctrl driver bindings
To: Rob Herring <robh@kernel.org>
References: <1485533721-9019-1-git-send-email-alexandre.torgue@st.com>
 <1485533721-9019-7-git-send-email-alexandre.torgue@st.com>
 <20170201150609.cbhwon76m6igmhyh@rob-hp-laptop>
CC: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>, Arnd Bergmann <arnd@arndb.de>,
        Russell King <linux@armlinux.org.uk>, Olof Johansson <olof@lixom.net>,
        Patrice Chotard <patrice.chotard@st.com>, <lee.jones@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Alexandre Torgue <alexandre.torgue@st.com>
Message-ID: <abee01c1-da4f-97b4-258a-3ab937f620eb@st.com>
Date: Wed, 1 Feb 2017 16:58:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <20170201150609.cbhwon76m6igmhyh@rob-hp-laptop>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.75.127.48]
X-ClientProxiedBy: SFHDAG8NODE3.st.com (10.75.127.24) To SFHDAG3NODE2.st.com
 (10.75.127.8)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-01_08:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 02/01/2017 04:06 PM, Rob Herring wrote:
> On Fri, Jan 27, 2017 at 05:15:19PM +0100, Alexandre TORGUE wrote:
>> Add new compatible for stm32f469 MCU.
>>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> index 25d9809..4f0487d 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt
>> @@ -9,7 +9,8 @@ Pin controller node:
>>  Required properies:
>>   - compatible: value should be one of the following:
>>     (a) "st,stm32f429-pinctrl"
>> -   (b) "st,stm32f746-pinctrl"
>> +   (b) "st,stm32f469-pinctrl"
>> +   (c) "st,stm32f746-pinctrl"
>
> Drop the a,b,c. Otherwise, you'll be changing a bunch of lines every
> time.

I completely agree.

Linus, Do i need to send a v2 for this patch ?

>
> With that,
>
> Acked-by: Rob Herring <robh@kernel.org>
>
>
>>   - #address-cells: The value of this property must be 1
>>   - #size-cells	: The value of this property must be 1
>>   - ranges	: defines mapping between pin controller node (parent) to
>> --
>> 1.9.1
>>