From: "Andrew F. Davis" <afd@ti.com>
To: <Codrin.Ciubotariu@microchip.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>
Cc: <dannenberg@ti.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_SCALE()
Date: Tue, 19 Feb 2019 11:05:24 -0600 [thread overview]
Message-ID: <abf49724-6567-43cf-852c-027c7948860d@ti.com> (raw)
In-Reply-To: <20190219162840.7244-1-codrin.ciubotariu@microchip.com>
On 2/19/19 10:29 AM, Codrin.Ciubotariu@microchip.com wrote:
> From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>
> According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step.
> Tested on pcm1863.
>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
Acked-by: Andrew F. Davis <afd@ti.com>
>
> Changes in v2:
> - fixed title - added correct macro;
> - revert the removal of a new line;
>
> sound/soc/codecs/pcm186x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/pcm186x.c b/sound/soc/codecs/pcm186x.c
> index 809b7e9f03ca..c36a391fec8a 100644
> --- a/sound/soc/codecs/pcm186x.c
> +++ b/sound/soc/codecs/pcm186x.c
> @@ -42,7 +42,7 @@ struct pcm186x_priv {
> bool is_master_mode;
> };
>
> -static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 4000, 50);
> +static const DECLARE_TLV_DB_SCALE(pcm186x_pga_tlv, -1200, 50, 0);
>
> static const struct snd_kcontrol_new pcm1863_snd_controls[] = {
> SOC_DOUBLE_R_S_TLV("ADC Capture Volume", PCM186X_PGA_VAL_CH1_L,
>
prev parent reply other threads:[~2019-02-19 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 16:29 Codrin.Ciubotariu
2019-02-19 16:29 ` [PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit Codrin.Ciubotariu
2019-02-19 16:56 ` Mark Brown
2019-02-19 17:06 ` Andrew F. Davis
2019-02-19 17:18 ` Mark Brown
2019-02-20 10:56 ` Codrin.Ciubotariu
2019-02-19 17:05 ` Andrew F. Davis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abf49724-6567-43cf-852c-027c7948860d@ti.com \
--to=afd@ti.com \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dannenberg@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®