From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00BE4382F17 for ; Mon, 16 Mar 2026 09:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773651647; cv=none; b=EQjPAVcdr6ngqujNACkeY2kEHCIDDDXZzgef5nb7uRvWn3bPFzNF8nx/wEs5/nFAEXd+DU6CEOORr3LtaUOfDSZ5tEMTYnJhDUrrnBnQiJMLtPBxydSrcHtQrNKVtP9WvPH/VVovKDB2SvrOKBRK9/Kqmxol+wr57+oUvxVrXec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773651647; c=relaxed/simple; bh=ChiTss7cdYlG02srTwNm2YmEqwejd9n8HdjtcaHpSaw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CX3XIa7Vb5z/ba5421YlCqJwytvlIfvlSsQRH0pBHKUmgtRQA8OwCe+9mVVKiS99cXGrvjyZFjwmVOj1uCPyGkV1fh/92hpgHi1z5tr8D2R5r2otPAWGcDf60qI2GGF2ZK1zSQnNRrOGtZgW98PxPR5nIWOBpE98wup1J8so6Uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Xlxu96+s; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Xlxu96+s" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4852f8ac7e9so51299565e9.1 for ; Mon, 16 Mar 2026 02:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773651644; x=1774256444; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=m2uQ6cvlypnVHsVAo9AGgQ4YcUxa4jo4S97am47FBUQ=; b=Xlxu96+syeH9BvqvdB82IypPryGdy3uKW/cqfhfWm4Fwulofuprcoi72kJzsIkMyIT bJkMca/dNDA/bHBA/5RT6zE2r3B7GJtb7T28LMuDrWQcVRjD95N52WUsAFjioL3kABsz As9hzTzqCkhucCXL2Ml7tElw++QqFu8smb8F3WtnuL++lm0SyXzFZGXBnM7Q/N+nmq6U IwKAs3XfPLGAojCBxGltTipNfVvMaxzHLXrpK9DUwQxrMGyanR0lRQC7r9B6RAmJ5Gbb TvJXi506wckT/VfTgTafOjYXnnBNBtI166wWkq4UfcW7tlkh/xWdP3/AC4nV037F/PRZ zByQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773651644; x=1774256444; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m2uQ6cvlypnVHsVAo9AGgQ4YcUxa4jo4S97am47FBUQ=; b=aJP6r2J/vs/WAUKnocjfWqsl4QD4HxFgxIx/hKPBoaBOxD1QYqJKfnsIJDBOCp/MsK kHHnuG28smm3K7ZZkqHjlbM3lNYCNnESwDoanCGObxHEAIW9hKXEL1Lxh5Dii5CQ3vT8 ww7KSinFOM0j2ZeUv7RtHR+LoiUNVUpkRwOytUkuqXnY2a9PUPwdsgQr64koihXny9WP rj7wn6lN4MpCLkODMVexy6wCexYW1tiBXDIJf0JcfAjdjrCbai8nqgxtGP1oOHom31wk MYN/NtXcWXFJy5LJITaWrz/oYUTlWFH9mr26xSY+gLPixBLZvA9LAe04QdrX0rGa6qWB Hq4g== X-Forwarded-Encrypted: i=1; AJvYcCXTdGl198GM6o6zfb2HDy6Z7fI6124+FCJy1fdtyzK6MowZupWa6nFVscp2j4qRGflzPeTZvcN3vHGtLRY=@vger.kernel.org X-Gm-Message-State: AOJu0YxEWN1PA/Ltg5VU5KTbMyYigOE1+shUzoREt30peJhrNHt3ibbC HOZd7sWlmqmUvZl+kP93bbdLF8IxPuk0cEJHYRC9oO9lkgYKiTNbfowd2gmtbkSEUeQ= X-Gm-Gg: ATEYQzw6n4HhlmITftb+BFuTPWJb1+dMSn6HeHjQmJaObZsL2oUYI3RGkyjlFW5v308 KsNM+3L7C+FHRE85J5TEwpHGswjMoaMON1rmmV5kJD6Xt8F7dKl4NJo4sKMH75ZvUUJ9YMNpOzx 65owDdUkEBCG84TZ+2JmWf5UXF0JezdAL6zrNs4Fe+6rgtebHRJwwooGYfGXL7iTAUBl//cSXBO UiF8xrIqDTFtOTGENM7LdA/ZuFzpBm6yYuElIXNje1xMmK15lvq4Eku2ZjmO3ty2E6ADJyfXKyL gL4zCU7r5GzSWqDABh/43Lcc+hjqlhtqEOTioaaBXW6bnArYrLZYq3ByEf354H2blNvzxoI5RUV zsgzm9PwPtWAGeEZi/lUm5WkqPp7xXMdc04yOgzfIPe8zNcJbZvi0D+tAUgH5Tqg+Pa+ttRRlbS K6fhPakr2FE0d7wJeHcehgbu6LwKWd X-Received: by 2002:a05:600c:3550:b0:483:709e:f238 with SMTP id 5b1f17b1804b1-4855670c971mr216147815e9.29.1773651644178; Mon, 16 Mar 2026 02:00:44 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541aa73easm504391785e9.3.2026.03.16.02.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 02:00:43 -0700 (PDT) Date: Mon, 16 Mar 2026 12:00:40 +0300 From: Dan Carpenter To: Oarora Etimis Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] staging: greybus: bootrom: fix potential null pointer dereference Message-ID: References: <20260315231949.231320-1-OaroraEtimis@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260315231949.231320-1-OaroraEtimis@gmail.com> On Mon, Mar 16, 2026 at 07:19:49AM +0800, Oarora Etimis wrote: > In gb_bootrom_get_firmware(), the 'fw' pointer could be NULL if the > function jumps to the 'unlock' label. The execution flow continues > into the 'queue_work' block where 'fw->size' is accessed, leading to > a null pointer dereference. > > Fix this by adding a NULL check for 'fw' before accessing its members. > > Signed-off-by: Oarora Etimis > --- > Changes in v2: > - Rebased onto the latest staging-next branch to resolve merge conflicts. > - No logical code changes. > > drivers/staging/greybus/bootrom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c > index 83921d90c322..50c80475d241 100644 > --- a/drivers/staging/greybus/bootrom.c > +++ b/drivers/staging/greybus/bootrom.c > @@ -298,7 +298,7 @@ static int gb_bootrom_get_firmware(struct gb_operation *op) > > queue_work: > /* Refresh timeout */ > - if (!ret && (offset + size == fw->size)) > + if (!ret && fw && (offset + size == fw->size)) This seems like a static checker false positive. regards, dan carpenter