From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Peter Rosin <peda@axentia.se>,
Michael Hennerich <michael.hennerich@analog.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andi Shyti <andi.shyti@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 4/5] i2c: davinci: add support for setting bus frequency
Date: Mon, 16 Mar 2026 12:00:16 +0200 [thread overview]
Message-ID: <abfUsE0cR6GddDDz@ashevche-desk.local> (raw)
In-Reply-To: <20260314-i2c-mux-v8-4-fb1738a4df0a@gmail.com>
On Sat, Mar 14, 2026 at 10:22:43AM +0100, Marcus Folkesson wrote:
> Populate adapter with clock_hz and .set_clk_freq() to enable support for
> dynamic bus frequency.
>
> Remove bus_freq_hz entirely and only use clock_hz instead.
...
> u32 input_clock = clk_get_rate(dev->clk);
> + u32 bus_freq_hz = dev->adapter.clock_hz;
> +
Stray blank line. We have already one below.
>
> /* NOTE: I2C Clock divider programming info
> * As per I2C specs the following formulas provide prescaler
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-16 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 9:22 [PATCH v8 0/5] I2C Mux per channel bus speed Marcus Folkesson
2026-03-14 9:22 ` [PATCH v8 1/5] i2c: core: add callback to change bus frequency Marcus Folkesson
2026-03-14 9:22 ` [PATCH v8 2/5] i2c: mux: add support for per channel " Marcus Folkesson
2026-03-14 9:22 ` [PATCH v8 3/5] i2c: davinci: calculate bus freq from Hz instead of kHz Marcus Folkesson
2026-03-14 9:22 ` [PATCH v8 4/5] i2c: davinci: add support for setting bus frequency Marcus Folkesson
2026-03-16 10:00 ` Andy Shevchenko [this message]
2026-03-14 9:22 ` [PATCH v8 5/5] docs: i2c: i2c-topology: add section about bus speed Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abfUsE0cR6GddDDz@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andi.shyti@kernel.org \
--cc=brgl@bgdev.pl \
--cc=brgl@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=peda@axentia.se \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®