From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756026AbeASQJT (ORCPT ); Fri, 19 Jan 2018 11:09:19 -0500 Received: from esa4.dell-outbound.iphmx.com ([68.232.149.214]:26409 "EHLO esa4.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755581AbeASQJL (ORCPT ); Fri, 19 Jan 2018 11:09:11 -0500 IronPort-PHdr: =?us-ascii?q?9a23=3AXVQCWxeVXjTgnw8rUoi4XvAWlGMj4u6mDksu8pMi?= =?us-ascii?q?zoh2WeGdxcW7YB7h7PlgxGXEQZ/co6odzbaO6ua4ASQp2tWoiDg6aptCVhsI24?= =?us-ascii?q?09vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFRrhKAF7?= =?us-ascii?q?Ovr6GpLIj8Swyuu+54Dfbx9HiTahfL9+Ngm6oRnMvcQKnIVuLbo8xAHUqXVSYe?= =?us-ascii?q?RWwm1oJVOXnxni48q74YBu/SdNtf8/7sBMSar1cbg2QrxeFzQmLns65Nb3uhnZ?= =?us-ascii?q?TAuA/WUTX2MLmRdVGQfF7RX6XpDssivms+d2xSeXMdHqQb0yRD+v6bpgRh31hy?= =?us-ascii?q?cdLzM38H/ZhNFsjKxVoxyhqR5ww4/Ib4+aO/VzZb/dcsgYRWZdQspdSy5MD4Wh?= =?us-ascii?q?ZIUPFeoBOuNYopH6qlUJtxS+HwisBOT1xjFOh3/22Ko60+I9HgHHwgMgG9YOsH?= =?us-ascii?q?PPodroKqgSVeS1wLPUwjXEavNbwDHw45XLfBA5ufyBXLF9fdDPxUQhCQ/JlEic?= =?us-ascii?q?pIzqMj+P0ukAt3CX4/d8We61lmIqpA98riKyysovkIXEhYMYxkjZ+Sh2zos5P8?= =?us-ascii?q?C0RU96bNK+E5ZdtzuWO5VqTs8+RWxjpTw0xaccuZGheSgH0JEnxxnCZPOZa4WI?= =?us-ascii?q?+RfjVPqJITd/mXJlZKqzhxas/kikze3xTte70E1QoSdEiNXDq24C1xjX6sSeTf?= =?us-ascii?q?t941uh1i2I1wDO7OFLPF44mbDaK545wr4wk5USvV7fES/xnUX6lK6WdkM69ei0?= =?us-ascii?q?8+nqY7brqoWCO4J6lA3yKLkil8ywDOgiNgUDW3CX+eGm273i+U35Tq9Kjvozkq?= =?us-ascii?q?TBt57VP94bpq++AwNP1Igj6hO/DzCg0NsEnHkIMlZFeBaAj4XyJl7BPvT4DfOl?= =?us-ascii?q?j1uwlzdrwujKPqf9DZXVMnjDjLDhcK55605dzgoz0N9e64tXCr4fOvLzXFH+tN?= =?us-ascii?q?jDAx8nPAy73fznBM9+1owAQ2KPBLGWMKfIvV+P/OIvLPGGZJUJtzblN/gl+/nu?= =?us-ascii?q?gGchmV8ZZ6apwZUXaHeiHvRjOkmWfGDsgtYfEWgUpAoyVePrhV6DXDNIeXayUL?= =?us-ascii?q?wz5ishBIKlE4jDXIatj6KF3CuhGZ1WfG9GWRiwFiK8b4yAWrEWbyKbOOdulzUF?= =?us-ascii?q?Uf6qTIp3kVn6uAr716B2aPbT4CobtZX9/Ndw7uzX0xo18GonId6a1jTZamhun2?= =?us-ascii?q?ROYz4z26Z0oEF5zlCr3aV8h7pTEtkFtKABaRszKZOJl78yMNv1QA+UJto=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GVAwASF2JamGOa6EReGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYQYgQQnB2sDgmiZBIICggCDCoN/kEAKN4UEAhqESEMUAQEBAQE?= =?us-ascii?q?BAQEBAQIQAQEBAQEICwsGKC+COCKCSgEBAQQjBA1FDAQCAQgRBAEBAQICIwMCA?= =?us-ascii?q?gIfJQEICAIEAQ0FCIoTAxWvJoFtOoc+DYJoAQEBAQEBAQEBAQEBAQEBAQEBAQE?= =?us-ascii?q?BHYEPgzmCFYM/gy6Ca0QEggaDAIJlBaM4PZBVhHqUIY4OiTCBPDaBcm+CfIJkg?= =?us-ascii?q?XN4i0mBFwEBAQ?= X-IPAS-Result: =?us-ascii?q?A2GVAwASF2JamGOa6EReGQEBAQEBAQEBAQEBAQcBAQEBAYQ?= =?us-ascii?q?YgQQnB2sDgmiZBIICggCDCoN/kEAKN4UEAhqESEMUAQEBAQEBAQEBAQIQAQEBA?= =?us-ascii?q?QEICwsGKC+COCKCSgEBAQQjBA1FDAQCAQgRBAEBAQICIwMCAgIfJQEICAIEAQ0?= =?us-ascii?q?FCIoTAxWvJoFtOoc+DYJoAQEBAQEBAQEBAQEBAQEBAQEBAQEBHYEPgzmCFYM/g?= =?us-ascii?q?y6Ca0QEggaDAIJlBaM4PZBVhHqUIY4OiTCBPDaBcm+CfIJkgXN4i0mBFwEBAQ?= From: X-LoopCount0: from 10.166.132.172 X-IronPort-AV: E=Sophos;i="5.46,381,1511848800"; d="scan'208";a="604961080" X-DLP: DLP_GlobalPCIDSS To: , CC: , , , , , , Subject: RE: [PATCH] Support tablet mode switch for Dell laptops Thread-Topic: [PATCH] Support tablet mode switch for Dell laptops Thread-Index: AQHTkT7ACO6NWJiW5EytMhw2yxA7U6N7W1OA Date: Fri, 19 Jan 2018 16:09:09 +0000 Message-ID: References: <1516283990-3665-1-git-send-email-notmart@gmail.com> <20180118154408.eyke3dtn6zlcqphi@pali> <20180119160123.onn7w36hmhrxoaq6@pali> In-Reply-To: <20180119160123.onn7w36hmhrxoaq6@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w0JG9OPv015368 > -----Original Message----- > From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86- > owner@vger.kernel.org] On Behalf Of Pali Rohár > Sent: Friday, January 19, 2018 10:01 AM > To: Dmitry Torokhov > Cc: linux-kernel@vger.kernel.org; mjg59@srcf.ucam.org; dvhart@infradead.org; > andy@infradead.org; bhush94@gmail.com; platform-driver-x86@vger.kernel.org; > Marco Martin > Subject: Re: [PATCH] Support tablet mode switch for Dell laptops > > On Thursday 18 January 2018 16:44:08 Pali Rohár wrote: > > On Thursday 18 January 2018 14:59:50 Marco Martin wrote: > > > - if (!sparse_keymap_report_event(priv->input_dev, event, 1, true)) > > > + if (event == 0xCC) { > > > + input_report_switch(priv->input_dev, SW_TABLET_MODE, 1); > > > + input_sync(priv->input_dev); > > > + } else if (event == 0xCD) { > > > + input_report_switch(priv->input_dev, SW_TABLET_MODE, 0); > > > + input_sync(priv->input_dev); > > > + } else if (!sparse_keymap_report_event(priv->input_dev, event, 1, true)) > > > > Is not it possible to put 0xCC and 0xCD into sparse keymap table? > > Because IIRC sparse keymap was created just to avoid that big > > if-elseif-elseif-else blocks. > > Dmitry, can you comment above part? I think that there should be better > way how to handle above switches and sparse keymap via one input device. > > > > dev_info(&device->dev, "unknown event index 0x%x\n", > > > event); > > > } > > > > -- > Pali Rohár > pali.rohar@gmail.com We discussed a little more on the bug he filed with attached DSDT. I think that in sparse keymap he can use KE_VSW for the entries and sparse keymap can handle. Assuming that works I'm expecting him to resubmit soon with that and some other changes I recommended on the bug.