From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Josh Law <objecting@objecting.org>
Cc: kees@kernel.org, akpm@linux-foundation.org, andy@kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/string: rewrite strlcat() to use sized_strscpy()
Date: Mon, 16 Mar 2026 18:53:41 +0200 [thread overview]
Message-ID: <abg1laKmwpw-762f@ashevche-desk.local> (raw)
In-Reply-To: <20260316164939.89349-1-objecting@objecting.org>
On Mon, Mar 16, 2026 at 04:49:39PM +0000, Josh Law wrote:
> Replace the hand-rolled copy logic and BUG_ON() in strlcat() with a
> call to sized_strscpy(). This removes the kernel panic on caller
> misuse (dsize >= count) and instead returns a truncation indicator
> consistent with BSD strlcat semantics.
>
> strlcat() is deprecated and callers should be converted to strscpy()
> or similar bounded interfaces.
I mentioned something different, id est converting users.
This function will go when ~130 or so users gone.
So, I don't see a need to touch this function (implementation) at all.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-16 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 16:49 Josh Law
2026-03-16 16:53 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abg1laKmwpw-762f@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=objecting@objecting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®