From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8286C39E194; Mon, 16 Mar 2026 15:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773673770; cv=none; b=GB8dfrFoZcZ5/FkZ+LmMb5qWhXPTLqb9j3jvBFoLWapBAAiwBi/NU+1O+6qJ6v2awmjonHinfAwiHVE7IVSSuNdVGtCEjSCQxug5xPGrQGNBRWF+cgGCMuMrXd9TbFFH9In1jyHBuA/pc3l8BzcZBR33sLZUbtvUW8OC6y9iN2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773673770; c=relaxed/simple; bh=yJhLYM4Bkw0hwkX8DWNS2MMddNF+4QuhrkkGcBrGRgc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=moUp9H9xjVFPiX6rdUOrwSAFcymE5BEbGBOtmDAFTP/YQ9/HVfQj3GGf/9rNfBJPOn3ap9mTeDxqFECHZoYxMtURGyljn6aZvB0s8PHPOJrECA6pqIvkVD8VcCatd1kTNokRfbQ5BtVwfQFE27ioZo2kUs+vgx4gwLbPn0ihUSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=La75v7hx; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="La75v7hx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773673770; x=1805209770; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yJhLYM4Bkw0hwkX8DWNS2MMddNF+4QuhrkkGcBrGRgc=; b=La75v7hxgY2j1/RlrbNq5fKG6Td3Eph1DgBsFdeflqdXnm55My+Padt7 bAUCwTGsWoy8GBwZjTlWy046KDcIXSFgtKhuOOXZZrwwM8wBoqqR5sbY1 eHysGa3tnKAh/Bz4a5yigfK9eaBxBUVc7T3ufk1pdeH2ene46DPzrfGZc Ez6GDesEYd346oraImFc82Tr5FpwVDDcNQ+PqrUd2eLZ8GaNpSCUm0vzp S6UdcsISawwdbstx84fhcsV2f1grMU47CHdJpZGE4zzzQcyD6CDKHbPrL /2LkfrZufWf/GmGlWGpY+Nsv0tda1pmTKl39i32ecT0QtyxhnP5+Sbwan Q==; X-CSE-ConnectionGUID: Y31a0oa2Sk2x9akG0k+2UA== X-CSE-MsgGUID: cikuWKAnR9eJ8zMFKaXAew== X-IronPort-AV: E=McAfee;i="6800,10657,11731"; a="92074253" X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="92074253" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 08:09:29 -0700 X-CSE-ConnectionGUID: EyU5VXr5QPu7uWgHJDO1BA== X-CSE-MsgGUID: xBaHTrL3T2qHLLNhT89M0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="226627487" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.244.237]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 08:09:27 -0700 Date: Mon, 16 Mar 2026 17:09:25 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Lee Jones , Linus Walleij , Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 2/3] gpio: timberdale: use device properties Message-ID: References: <20260316-gpio-timberdale-swnode-v2-0-ea0078066871@oss.qualcomm.com> <20260316-gpio-timberdale-swnode-v2-2-ea0078066871@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260316-gpio-timberdale-swnode-v2-2-ea0078066871@oss.qualcomm.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Mar 16, 2026 at 10:30:49AM +0100, Bartosz Golaszewski wrote: > The top-level MFD driver now passes the device properties to the GPIO > cell via the software node. Use generic device property accessors and > stop using platform data. We can ignore the "ngpios" property here now > as it will be retrieved internally by GPIO core. ... > int irq = platform_get_irq(pdev, 0); > gc->to_irq = (irq >= 0 && tgpio->irq_base > 0) ? timbgpio_to_irq : NULL; > if (irq < 0 || tgpio->irq_base <= 0) > return 0; I believe we also want to have a fix of the above (it will print a message when it's fine to continue and checks for irq > 0 twice). -- With Best Regards, Andy Shevchenko