From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ECAD368278 for ; Tue, 17 Mar 2026 11:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773747801; cv=none; b=vBFq9vYOV2+LYAj1bygew60xSj5lEhKL6SyybX8+HkK2hExIHaG7UX1Xzjz6OTbrik9GRKq9lcuVUADpQ//Ud45OIey9K0gbu8qgxNwvvdhR6Wtifi7XNGhXv5X1/vxVgJ6mI6rdjS8CyVCd2gBTRH2UeTNnM9JfOOXtm3Ar4sA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773747801; c=relaxed/simple; bh=iLUZn14+6rtimFfKhoQnVQGHBQrCrfF5eg0tdX9ApFE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jhlLnMD7MLCWraqIY1jiJGJ5yGeVxEC5+8LpRoWL4qcNQDFCcaRZMKRTBbzBVWfxJR+sUTxj0TCNVMf7WeCcpMXV4QQjQh3JrllJv+uUhncb66BWlAcVeiZZT8ugbox6z2kPNcbfSQj0aHXEF8rs8r1vCYl70GnGQTo8o8eTxxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=t4uVenMp; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t4uVenMp" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43b41b545d9so2840328f8f.2 for ; Tue, 17 Mar 2026 04:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773747799; x=1774352599; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8fNR5wIxvlPYlAMd4vfb8Hl49r1pKDzcdGZFsZ2lfMA=; b=t4uVenMpbAqqtr9ihuaX4IbU/kQNtKIuVxCz/UhjbP8320W1mK89pCDq7ptJha8r/r EDjwnQokuHxe6abVYQ46J1iHa6M+xuYGC6/sEniSMNOzg6KEmKa5zybMoiFVr+OMj1bb kzSVWJvGu2U3WjiVcT1UiU3B8k++aLDnFmnOxLIBzs2LG5Y7DdZy8WgvuABu4n3u18sk KcfPJs10Yu+QPFIOefb7eOaXLq0vMEbcADWj50A50wjU1onwzfGj6JuKnRebdzhQ/9SN blJrki8UeaUw+7OpQM7Si5ZrXuZ+EE7tmYm/MCLLFbuxp4wnRI6t9cq+6XIhVCMRhRSp kvaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773747799; x=1774352599; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8fNR5wIxvlPYlAMd4vfb8Hl49r1pKDzcdGZFsZ2lfMA=; b=MD+a0kG3N6H6GR/Gw2pVKlnRgr65+oj/RqCb3jbiIcSHLEGtDX7E3aflpswsCtYtQH v66DUarUU5cVsaq1oPhpbCgonyZ/HpbC4UamVpwWeTtSdq5UEgEUptq2px5pNRF8b3xV kY1VWMTU1Ly+qXw+vTRmUBwuZNMef4datF+XJ7PiIQFEyDzaR1L1tZA66OLYsBuVtTYJ UbmOaFsso04WIEbWY3madG6sNLB2a+brvRipty3dRNuA/7/u9Qr2FsgWM5AnU+vEz0PE cr1HunQjxdXzw7L241gUXdfwAvVfSGdnBCoQJX8kJCu8mlkH7E72iDed99D3OC6roVSu u6xw== X-Forwarded-Encrypted: i=1; AJvYcCWvuMMEramaIhH/qKbxDX8H/5GI/XjBiWGXt8e4ta6ZxyKUFFpVG7uRgEPby1aF84uZ2v1fvidBfrtSqAY=@vger.kernel.org X-Gm-Message-State: AOJu0YxwQDXhuV9periXDI5oLISIFUnS1M8H6tiBIavH2kYyKt2QB/yI OHiTQHUMw1hyAUQetbDkR0WsO5+ksk9UKWV15IJBXYeBjbz5N9uL+z3ExSCrh5du4yE= X-Gm-Gg: ATEYQzwpQbL5uRf9ujyvWMXqYZA5Trvs/NdUL9Kh/2+x9pfxlR9aLxV8tRIYxgDTAGf sRnn2Ekop66sRWNTCUBz0QbPXUAi88QaXPsBIxeAsr3fWa803AjJFGCDqeNfx5OC1uxTlMPwkjS 9DIkc8Nev6d2LtF/KN/denZhhn0ux9CZSXWwUJCGoUVYiVvIKhkwdzBLVH1mBZpkAeDErJx2yRv byMFEBgFP29+qlj0bhSh3Jj82hSh4YuElORvOK91nfovBThEVMKfDloXpINJDSkZaMo32XADSsp AhuZcemk1Db/0BZP7JUynOa54J2OxBtMyV67XwkO2Xmf/+STwqPklz25DPZATtttlRj26bSNT/2 IDwW4Qr+3CMx21VuDCKUkqyES4PkXjvoWbeupmg6mJvd3iZJR4xcojLS11aCvSWK+RLsvAXYj09 LswOrKEGs4WxPcQcZdMHOyj8ZkuMS3Py28OwORelE= X-Received: by 2002:a05:6000:4014:b0:439:b541:a092 with SMTP id ffacd0b85a97d-43a04d83c63mr29302718f8f.8.1773747798917; Tue, 17 Mar 2026 04:43:18 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b45e5c233sm15187046f8f.33.2026.03.17.04.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 04:43:18 -0700 (PDT) Date: Tue, 17 Mar 2026 14:43:15 +0300 From: Dan Carpenter To: Marcos Andrade Cc: Greg Kroah-Hartman , Ethan Tidmore , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/2] staging: rtl8723bs: Cleanups for rtw_xmit.c Message-ID: References: <20260316221924.4904-1-marcosandrade95963@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260316221924.4904-1-marcosandrade95963@gmail.com> On Mon, Mar 16, 2026 at 07:19:22PM -0300, Marcos Andrade wrote: > This patch series cleans up rtw_xmit.c by replacing magic numbers with > proper macros and updating the sleep API, as suggested by reviewers. > > Patch 1 replaces network magic numbers with EtherType macros. > Patch 2 updates an msleep() call to the new fsleep() API. > > Changes in v5: > - Collected Reviewed-by tags from Ethan Tidmore for both patches. Next time, don't do this. Maintainer scripts do it automatically. regards, dan carpenter > Changes in v4: > - Fixed commit message line wrapping in patch 2/2 to comply with > the 75-column limit, as suggested by Ethan Tidmore.