From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E18833B4E83 for ; Tue, 17 Mar 2026 14:14:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773756885; cv=none; b=cwSd/jUe+M2qQ3QvW0VCBC2GUd0t+hE6P9bwnoIeaGXxKCWyuIbk71/cq9UnEjgwpc6vPRB81MCLNfQvi8wWkR4RuvWODWQp3l0J6WkvyKEY2rImrtAlFQBDoqI+mRu2Y0lsxLvja/pBFQNrEyTiAuOmRoflbQZz2RjvtPXuunA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773756885; c=relaxed/simple; bh=TYYlLMXuP4IlI3NRqsUo8ERXR+xfxK1pOTap65J7cXg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EWtVOAqm5oaWiBT56KrNWIKpFyn6QJPGWlAJRPHB/qgtQlaUcOzoD6Zm0SQsx7hekJ4h7FLAconKMN5ON9A6nBWeBOD+YluqtU061EA9NEyfgqiYZ4pYLBeKaAjFIvV1NJxtjPG9UksRFavsr4wRkyK9BQJI+USw+kbxSQmWRCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QYlaZw8R; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QYlaZw8R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773756884; x=1805292884; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TYYlLMXuP4IlI3NRqsUo8ERXR+xfxK1pOTap65J7cXg=; b=QYlaZw8RUVSZPu/9upEzUHdGI/F1TrYF1Cyg6fPLLYtum61W14J6ulrF mNOeFlbv4UnPLTIaDVFvcYRTCSmye+14k1FsRauMkcfDQuScnrGsVAEDU DOsEWn7npMnHiraQRyCfGuaQbpoDU3QrQLzluXevPW0e6LmmrYlRDmqwX 4GpkuqLuPdW8Wv8+VplRaSYUkyI69jeTXFDqroVd5XD65/4HpbTIweHwx 0qX99cvN4hRqHb6D/3aVlXf2s0FYix2K4jgSVo+Sl5EXgwEbm00znR6H3 9EQ9VzQ49zLPvzeJXSuojUHq6c0csTdTaoFnQHgDB63z0/8Ae8tTfYype w==; X-CSE-ConnectionGUID: h6N+a+MRTyK+qw8XttD/Vw== X-CSE-MsgGUID: riqifvmbQzSqBC/epPSjdQ== X-IronPort-AV: E=McAfee;i="6800,10657,11732"; a="78643026" X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="78643026" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 07:14:43 -0700 X-CSE-ConnectionGUID: 0NxTxbGXQgOoDF213ywUCA== X-CSE-MsgGUID: bHFfAghrTM+ZyOeGStR61Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="226755293" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.97]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 07:14:42 -0700 Date: Tue, 17 Mar 2026 16:14:39 +0200 From: Andy Shevchenko To: Shuvam Pandey Cc: Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printf: add IPv6 address format tests Message-ID: References: <20260317114548.98919-1-shuvampandey1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317114548.98919-1-shuvampandey1@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Mar 17, 2026 at 05:30:48PM +0545, Shuvam Pandey wrote: > printf_kunit already covers IPv4 address formatting, but the ip6() > test case is empty even though printk-formats.rst documents %pI6, > %pi6, %pI6c, and generic %pIS variants. > > Add focused IPv6 checks for raw and generic formatting, compressed > output, the single-zero %pI6c corner case, and bracketed port > formatting for sockaddr_in6. > Validated with the arm64 printf KUnit suite and a W=1 rebuild of > lib/tests/printf_kunit.o. No need to put this paragraph into the commit message, it's implied that the author of the change has validated and tested it beforehand. Otherwise, test cases are always warmly welcome! Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko