From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.avm.de (mail.avm.de [212.42.244.119]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC94423EAA6 for ; Tue, 17 Mar 2026 20:42:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.42.244.119 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773780139; cv=none; b=pWkryGWOZELyeDjOk9pmMVBCdWdrQdELoaRADx/hJSyXGhl27XP8AqyUS4qgl/PKMKlgJ81aIqDCZlhLPWSw7obf5V+drcXbJjYqQdE9bjIJZtpZ06FX8gljdF0qMIYLrsfkDT2kc3Dc7BHaY9kZG7I2U2c6z8SHRVtJN5vfXMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773780139; c=relaxed/simple; bh=8xPO8mua7W8lJFWVf1zlT4iyyEvfbc3nT02sh5EWaKo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WAQ8H3rQVAXCK/toxdEp5cb92otu2gE41Hul+kU9x4GJqLBfFnX4E+vS9wVUZaJu8bbjqCt+WwSi8xvRpcQwGW4wMjgKe3+RSpdve2Bi/KeERLeegIzl/SdAQuODcXXkEm3bzd3c+Bf3peRU4NPmYRC4zWIeUiXtW80Ct8vz44E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=avm.de; spf=pass smtp.mailfrom=avm.de; dkim=pass (1024-bit key) header.d=avm.de header.i=@avm.de header.b=axRzgfDz; arc=none smtp.client-ip=212.42.244.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=avm.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=avm.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=avm.de header.i=@avm.de header.b="axRzgfDz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=avm.de; s=mail; t=1773780093; bh=8xPO8mua7W8lJFWVf1zlT4iyyEvfbc3nT02sh5EWaKo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=axRzgfDzwGmJ4p7F6Sftitpejh+zlAfaQu16LE+9lRJWbXQZCzXblD2zF1NbLjJ1F XDX0KK/E+SSePyLumq0FyRamzpzk/viJDiBIhGYLVJn83S8neYwuvvT7rlwMPz7M0W tWsv+k2jNjss3XuxGNYJEwnncSKu8bc4/3FwbKz0= Received: from [212.42.244.71] (helo=mail.avm.de) by mail.avm.de with ESMTP (eXpurgate 4.55.2) (envelope-from ) id 69b9bc7d-76f5-7f0000032729-7f000001c620-1 for ; Tue, 17 Mar 2026 21:41:33 +0100 Received: from mail-auth.avm.de (dovecot-mx-01.avm.de [212.42.244.71]) by mail.avm.de (Postfix) with ESMTPS; Tue, 17 Mar 2026 21:41:33 +0100 (CET) Date: Tue, 17 Mar 2026 21:41:32 +0100 From: Philipp Hahn To: jim.cromie@gmail.com Cc: Jason Baron , linux-kernel@vger.kernel.org, Greg KH Subject: Re: dyndbg: pr_fmt(fmt) with additional arguments? Message-ID: Mail-Followup-To: jim.cromie@gmail.com, Jason Baron , linux-kernel@vger.kernel.org, Greg KH References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-purgate-ID: 149429::1773780093-925E5BF8-FFD150C1/0/0 X-purgate-type: clean X-purgate-size: 1118 X-purgate-Ad: Categorized by eleven eXpurgate (R) https://www.eleven.de X-purgate: This mail is considered clean (visit https://www.eleven.de for further information) X-purgate: clean Hello Jim, Am Sun, Mar 15, 2026 at 05:30:43PM -0600 schrieb jim.cromie@gmail.com: > On Fri, Feb 27, 2026 at 4:12 AM Philipp Hahn wrote: > > > > Hello Jason, hello Jim, > > > > I've been using the following in my modules to prefix all messages with > > the module and function name: > > #define pr_fmt(fmt) KBUILD_MODNAME ".%s ", __func__ > > Your example loses the fmt, so is not actually useful. Yes, somehow that 'fmt' got lost; I've re-added it. > but that said, the compile err is real, I hit it once I changed > > 1 - the pr_debug("exited") call in test_dynamic_debug.c > to pr_debug_ratelimited. > > 2- the pr_fmt in same: > #if defined(TEST_DYNAMIC_DEBUG_SUBMOD) > - #define pr_fmt(fmt) "test_dd_submod: " fmt > + #define pr_fmt(fmt) KBUILD_MODNAME " test_dd_submod: %s" fmt, __func__ > > 2 was my test-case, on my latest branch, yours (on master) will be different. > > please add that test to your patch, and my > Acked-by: Jim Cromie I did both; v2 is on it's way. Thank you for your review. Philipp Hahn