From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CC3837A4B5 for ; Tue, 17 Mar 2026 23:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789792; cv=none; b=R5ijzgrOkKVAoD4MUanqln7rf/ervU1zd4Zm1j/f/MhlNQbaHsjQd1OYEPnqzRpdjAI0ORy1PE4eESRa5UHRyBPwdUBgor/utdwPp/ARXBheNrVlVhqOQPcckGnmjyewIoztliRJOtne6SsC1KD3+eoAyXhzQHjwNWNxQWDiKRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773789792; c=relaxed/simple; bh=WxVoAH6XfFqFLe8C0G1jyDlCB5OztWMMCtpxSlhLNIo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gpYzKoSXV+ZQo11U7dZDN6KQk6LFNv6TNBUiICWQjgn6N0ppVupRZotjQwAL8/FkX3AB9mE1AoYvPRrlFWyQap6sZ8kn3uL8gDj7G+9zX4smHl3Ui14X94dtdT8J0z48VqNfNAjk66Rm2HK+xokEaIdeS2gzmI8EQH+tkqaIZsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GIoQ67cz; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GIoQ67cz" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2beab594d8eso1345501eec.0 for ; Tue, 17 Mar 2026 16:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773789790; x=1774394590; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=XN/qOC5CJ/bhMlRJKWhmjAU6IJC68YMTmoD5LWl17yI=; b=GIoQ67czo4il7UlO4rY6sg2Qgn0dwBPaXFIGQHgz9Qe+sxFVaqZt5AqGubXEg6ftl4 IywJqtGTjuqWy5ce8u/q5o73w8L+rnw/selBxLOeRQO7TEAZlTlZHsnAtONBi036ALym IN98NxrVPMy6U0QYyEx3+96iSbCZK+AnFd0acXiEl3HMRoqOLCkndQ9j25ShhOry329x m/JBZFAdlBMNBlWZGnWLcBNK6rvbHu/oJud9Qrvnf7QnmikptV7GrDnnfOoH2zVPYpi1 7RTBaRQRDKw8J9XLbZqx46FOcyFR8XUqmJuPpBVVCquM++yRcEPYJ/DXx6wFhnbiPTEg wB7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773789790; x=1774394590; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XN/qOC5CJ/bhMlRJKWhmjAU6IJC68YMTmoD5LWl17yI=; b=Y5EHKFo/+XLZXFHH5zMk3gzXrsuzDcKl+x5yNni6nBjl4GidfvPwOXjFkxDkcwQQmO zf0r41qBOfxz/Bh5IyItoioAXcw9298Iow8ZFJvtxk86qaN1tmYsW1AYdhvYrAtp3qYc LOHOLTYmzGQeKKVL18MFidqmucx0dsbMuv4eBzModKf2DX2rMk8ZhfWiKD79w1Rg8k+g MWSdtOg/QC8oKTsP+029wJ932qjlatV3bT+HZo7ylmZkX22eI9LubFksz8NIt0XU0AXT XmXVgh9vWMAWCTqsCzAGI/7AAJ5E6kaQ+H702HnlStzTDFZQqIUmxC7ZwpOYMqfD4sAb vaKQ== X-Forwarded-Encrypted: i=1; AJvYcCW5JoEfn6+//VgpJf5dwwj1+BMa2VoDvLmszFGIMccipQz4AoAE6BlPH2K6Tgla3VQoJF0uGuyb7BjErN4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu3OLZwxtQNB+ogwvn9XOBUNhF5dEGYDF7QSzsjm6K1b8Gnfu4 l0hDERjh/d5oIf3yVmESO3hp2HsTTPfEOQ069ieA6qiksKDkKqCH1+ejLwhF+aaA X-Gm-Gg: ATEYQzxkV1FRPAX8ULsehNbxBGAruPNse+qy8z/YEz0TuRDLkCJ4lpb1PC8vo8ElYwj rbgsK1lNf2kOZVOzrrVmqWTuo4PIGWf/4aZ/Szn/sqbp1slyuIW2T1YfBQh8dtrZDUo0Fso5h9/ rADDe1FAsha9T0h76fiAT4VfKCRTRA8yCr5PCaS3si3CU/s35f5RZs54f2+ArjmvJr5RdPBlf1A Wk3haMkrK0sRyN+OvsJ7Hahkicf7R68LexE1695mEEV0+PZOrSKJfXSiBQ29vR4GM10+NUoOwdr HH6Ju1v95UiqELotRiK17ZS4Ld8zStA2QoliDqmKyNDwKi3Sojt20WGQc3dr4E793fDbJT0C59A N/PdoCn0p4GjyGuJlf/WpAAnPmih4Cl1d4UgBdoouI67r0FjRQzdWEKio0oTt5jBF5WVrq5Br0P 3bI58/4H42NzZPhnnZhY5l+ixgCkNE2ZGjwOdtdTZ9BASMI+Rva+I2KOUzB50Sp9/+OsuWboRLZ cUT/uXHiJ20wbw= X-Received: by 2002:a05:7301:2e89:b0:2be:2f58:2ef5 with SMTP id 5a478bee46e88-2c0e4f5b103mr758591eec.1.1773789790054; Tue, 17 Mar 2026 16:23:10 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c0e55cd9cfsm1356744eec.26.2026.03.17.16.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 16:23:09 -0700 (PDT) Date: Tue, 17 Mar 2026 16:23:07 -0700 From: "Vishal Moola (Oracle)" To: Michal Clapinski Cc: Evangelos Petrongonas , Pasha Tatashin , Mike Rapoport , Pratyush Yadav , Alexander Graf , Samiullah Khawaja , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v7 2/3] kho: fix deferred init of kho scratch Message-ID: References: <20260317141534.815634-1-mclapinski@google.com> <20260317141534.815634-3-mclapinski@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260317141534.815634-3-mclapinski@google.com> On Tue, Mar 17, 2026 at 03:15:33PM +0100, Michal Clapinski wrote: > Currently, if DEFERRED is enabled, kho_release_scratch will initialize > the struct pages and set migratetype of kho scratch. Unless the whole > scratch fit below first_deferred_pfn, some of that will be overwritten > either by deferred_init_pages or memmap_init_reserved_pages. > > To fix it, I modified kho_release_scratch to only set the migratetype > on already initialized pages. Then, modified init_pageblock_migratetype > to set the migratetype to CMA if the page is located inside scratch. > > Signed-off-by: Michal Clapinski > --- > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index ee81f5c67c18..5ca078dde61d 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -55,6 +55,7 @@ > #include > #include > #include > +#include > #include > #include "internal.h" > #include "shuffle.h" > @@ -549,6 +550,12 @@ void __meminit init_pageblock_migratetype(struct page *page, > migratetype < MIGRATE_PCPTYPES)) > migratetype = MIGRATE_UNMOVABLE; > > + /* > + * Mark KHO scratch as CMA so no unmovable allocations are made there. > + */ > + if (unlikely(kho_scratch_overlap(page_to_phys(page), PAGE_SIZE))) > + migratetype = MIGRATE_CMA; > + > flags = migratetype; > > #ifdef CONFIG_MEMORY_ISOLATION I've just tried to build the current mm-new tree. I'm getting this error: error: ‘MIGRATE_CMA’ undeclared (first use in this function); did you mean ‘MIGRATE_SYNC’? 557 | migratetype = MIGRATE_CMA; | ^~~~~~~~~~~ | MIGRATE_SYNC >From what I can tell, MIGRATE_CMA is only defined if CONFIG_CMA is enabled (for x86 defconfig its disabled).