From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from jpms-ob02.noc.sony.co.jp (jpms-ob02.noc.sony.co.jp [211.125.140.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FF7520297C for ; Wed, 18 Mar 2026 06:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.125.140.165 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773813723; cv=none; b=nuYdy+VCDHVlO+DqZYDkVjosFTeqTMr6TyVsX9szhKy/WoHQ0MggOkR3W9dc54L2mZsHcS/FDq8DYY5pe8UZiQxRgux9IaNf900wvIAv6u6R+6HRWQV3BTDlbPfnacgaeoNaQHiSHhQCDZV0+91nrU3DtFsl6fnCex5fwjC0bfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773813723; c=relaxed/simple; bh=/C5kQOWqIAvyyYPwufWFbJlY9KGkT6jO9JiGW+9We4U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s7f4uCl18hPxM6Fawx/kYWXw1xBsP9vKNDB4gbdPHhg6IPp64vwivx8/E7gJPnCNfaypDm8aAXIgd8P3i50IH4UMyjqTO+HI3bNG0OER9xGQqZnn6QSpElphD4/Y6+gcUfqIrZFPCCRL0BKnG/7OWFX+rdr18yZfAK3LDAkHnmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sony.com; spf=pass smtp.mailfrom=sony.com; dkim=pass (2048-bit key) header.d=sony.com header.i=@sony.com header.b=D8RPFsmS; arc=none smtp.client-ip=211.125.140.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sony.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sony.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sony.com header.i=@sony.com header.b="D8RPFsmS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sony.com; s=s1jp; t=1773813721; x=1805349721; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=eoMupIu5zVSqyOQhuq6iQarD8KxsCTZiio2rS8ELzNI=; b=D8RPFsmS+Cb68U2ZY3Aqq+V9acp7n3WcPblZp6DkwJuMkv09JAkYdHoh ATKAZciEe/J8nIQK1alrOy3/bWXQUIsSx7nMuSfFeUTr2eZyo7hKT4uEg iJYvvW+IomPq+9NbaRuQsxsoy3IIqzicOuS007uXrutSdTeopyfnviTyM LGzklfSg7n1jAlCC88gS7JneWDs/KuHm1bwd5xIaoTDnWYKkv/3Udc4HV 3eKh8l9o5v14/KZMYyn0TZtJQsmvaq2thd12CZ0AI4ua8FRWQZCFr5U4B qMTjN/ax1DdE5ltq29ouZTMVZvxun3YQx4XRYGFJNOlOYHaRKjHUwq5jm A==; Received: from unknown (HELO jpmta-ob02.noc.sony.co.jp) ([IPv6:2001:cf8:0:6e7::7]) by jpms-ob02.noc.sony.co.jp with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2026 14:51:51 +0900 X-CSE-ConnectionGUID: rLxGr/LJTuiBO7S+Ph9nTg== X-CSE-MsgGUID: gh60nqK7RPO5TcdDQeuduQ== X-IronPort-AV: E=Sophos;i="6.23,126,1770562800"; d="scan'208";a="592821526" Received: from unknown (HELO rahul-Z690-S01) ([43.11.34.175]) by jpmta-ob02.noc.sony.co.jp with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2026 14:51:51 +0900 Date: Wed, 18 Mar 2026 14:51:42 +0900 From: Rahul Bukte To: Jani Nikula Cc: Suraj Kandpal , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915/gt: Check set_default_submission() before deferencing Message-ID: References: <20260203044839.1555147-1-suraj.kandpal@intel.com> <864065cfcd3baaff212135beb781b0a5990728d8@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <864065cfcd3baaff212135beb781b0a5990728d8@intel.com> Hi, On Fri, Mar 13, 2026 at 06:34:22PM +0200, Jani Nikula wrote: > On Tue, 03 Feb 2026, Suraj Kandpal wrote: > > From: Rahul Bukte > > > > When the i915 driver firmware binaries are not present, the > > set_default_submission pointer is not set. This pointer is > > dereferenced during suspend anyways. > > Which kernel vesions did this happen with? Should this have had Fixes: > or Cc: stable? Fixes: ff44ad51ebf8 ("drm/i915: Move engine->submit_request selection to a vfunc") Cc: stable@vger.kernel.org Suraj, you mentioned that you have commited this to din [1]. Can we add this fixes and cc tags to that please? [1]: https://lore.kernel.org/all/DM3PPF208195D8D000253F905FADCA379F9E36DA@DM3PPF208195D8D.namprd11.prod.outlook.com/ Best regards, Rahul