From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C80973A5E71 for ; Wed, 18 Mar 2026 11:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773832685; cv=none; b=SHLJTSLPkUm4iRwA4jg89iGGn2AbYu4iPXsxQKc/jpUT/excMyO/Pa4K/nEELvM4HA1HAOvBBNRJMGPGwxmEEkHdHwwq/TJ1Z5zEOjKkjXIdqFcT9kkY59jav6iVnl6zbi7/9Z0rZhUTUAzEMguFCb7xfzrQm6D+aJNShDgdBRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773832685; c=relaxed/simple; bh=XNqONWgWTe8jAN7PZU6G+ILHFEYLHk5DEAmh0CGR/PM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TCZjDq+Z3jygbfa/u+ezOFqF4b6sLLqia6HCFFnJ26r7IvmbI7YllDMSkFTJWYPedrzzG52zhmtsJeqvOJVYexHWDxkwvZx76OvGRoiYPJsJvqc7xsud0XBbgJQeTDxsH9Oatp0cRXPT/9BJ5d3CDdzPKR/9HbgY6Tw9i3n6UHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e8lapnTG; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e8lapnTG" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-439b2965d4bso4784093f8f.2 for ; Wed, 18 Mar 2026 04:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773832682; x=1774437482; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mprAVzmkazDIxuz7411i0uWNea/JvTXoL4j3+KJMyn4=; b=e8lapnTGn5c+gYgsFHuYNTCKXZ+94Oe2V/CYwS5oQhW4bQl1TQOHUiW5K7s1Y6EaS5 LZhFfyvwX+uCwadYaDhsiXW5J8pyXq8SWe0z/P5OchLxiffCA+Kz2nG+ktw3fgbKmk1O c/w6rwCWFlO180VUtKEJGjkpXKbOqboaz/E7tZR7zCJ6odq6jd37kt/SJxrQFKFr0KFs 1deBMQiuHtQMGjBySxc2fEGLcjnn/RWbyMDjc6GKbIqiMeiD/jk5LJYWUpQ8xXPHlCLa phvENkEs9qVwzvrxajptMJwkbxkfjDhWCrkmCz0FPiW/CCV4zLRg1JGjEsSBgRNjfr55 38xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773832682; x=1774437482; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mprAVzmkazDIxuz7411i0uWNea/JvTXoL4j3+KJMyn4=; b=eCBE6VsMU2m+jFGvsDBgrmmYQAs0a1jxNNd+UUGbcY+DR3gYv+Oz/v5H3vQsnFmbnw Z/3nEbYYvFnFjEZUaV5jacZVezs5BMktE/d7WdBkjtcj010Fy6bxyBaBT+dlP/xBwddR lGH6H9ups3rL6Ni+LFpK/OzA5m1od/wHPvGAGA4SbbCzIV4C8FlS9Av7bxAoo8cYc6+s U/i5fCAjM22DZkVr1gAj8MYnaak1cQd79+tdqFrhNvawpTk15TByB45Z2PUFS4w9Sxka ZOsIVtRhQsv2BzjWSlHQjkjT/tsaMlffBVhh33wnHJhgIoFOwydWnJE+YH6nBf/uUKFH c/PA== X-Forwarded-Encrypted: i=1; AJvYcCWumQfIVOTGZlWU2lX5g/4xZ1nHRoBP6KPIStGw5GuxGy38AYzyY/LRVKnL22ZGHpQ3rxjnXL0dMcePkVg=@vger.kernel.org X-Gm-Message-State: AOJu0YxUXYzvJLx+HIm57ZaSeythdGYxifX9kB/jfhxGhtDbwbs3CS0o aXJ8snnIswvyfqcyGmzegQpcVZtXQwAAch2tWEoHs7gSK+DMYw9C84gCXz6oV3FZQ0U= X-Gm-Gg: ATEYQzyc+aMfCDqtp5pqNXUGzXDE27QPohrfHZxtDbIWv7M1cHFqXcqev8nY4mg3IeM Kp+zx4D6vhmV5/6/R1vDIzX20t5foeIsaEtZZHKETVaHPkFbTyxqCuLuNK5Yb2J/obYEcs+seaw CWU5oueTNuOiOHd0n2UFu+9xHX4fwX8v2huAw8HFE3PHBaoTCG8O6Uz5nJa9Na2aKGE+oROybKv smVAcJ3L/ebOQJtF4cVmUcHQTOiscMCzX4g1ZbbBdPj59tn4de2DdDv85FL/di7W/SuXgf4+gHm eGH6K7XZY01a1Eb8MUawiy8Cp0XcT3qexrba5X/wZOWXBonYnTEU5Qf9EN0ROXLmoaDJgBmq3bL GZ6SZKENLOpbQFR1hb8chX92QxJOu3NeqG41gJXA/aiNFYJ04wCpQ1ca8qQZsYl0I1sGhmhTrYz 7oD8XjIc/jR5mPxenG0DL07a2U/CMj X-Received: by 2002:a05:6000:420c:b0:432:5c34:fb32 with SMTP id ffacd0b85a97d-43b527ad99emr4753737f8f.23.1773832682005; Wed, 18 Mar 2026 04:18:02 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b5184b7f7sm6962268f8f.4.2026.03.18.04.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 04:18:01 -0700 (PDT) Date: Wed, 18 Mar 2026 14:17:58 +0300 From: Dan Carpenter To: Aadarsh Mandal Cc: gregkh@linuxfoundation.org, luka.gejak@linux.dev, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, straube.linux@gmail.com Subject: Re: [PATCH v3] staging: rtl8723bs: remove dead code Message-ID: References: <20260318092639.27055-1-aadarshmandal9354@gmail.com> <20260318104332.32093-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318104332.32093-1-aadarshmandal9354@gmail.com> On Wed, Mar 18, 2026 at 04:13:31PM +0530, Aadarsh Mandal wrote: > remove unused and commented code > no changes in functionality Line wrap at 74 characters. Add a period to the end of the sentence. > > Signed-off-by: Aadarsh Mandal > --- > v3: > - regenrated patch from the clean tree > - removed unwanted addition > v2: > - accidently added the functions in the {} blocks > v1: > - some commented code wasnt deleted. > Note: > * This patch is part of the GSoC2026 application process for device tree bindings conversions > * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings > > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 21 ++++++-------------- > 1 file changed, 6 insertions(+), 15 deletions(-) It should only be deletions and 0 insertions. Review the patch and run checkpatch.pl on it before sending. regards, dan carpenter