From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 254A23C277C for ; Wed, 18 Mar 2026 11:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773833646; cv=none; b=oVoU2g9VHk6GziWFf6QswBMh5Yz01762hj5/YZBs2NsZt324tJof1fAJXqKazSmBqwMLno/vQQBiJch8B4sgD/mKgdrD6T515dJCq/pKw4qBbOE6ugIs/EntP8ejk0errg1vuwlPUlQv31Pkc7druXVt+R/3+MR7cMSl8HCU3qI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773833646; c=relaxed/simple; bh=kdknD7S1Wa/kH0COqcqsT4+BSXG3arhV1YtJjkrLx0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S41hN3S3UP+geBtm79sdu3JMhqV7wBXXSEBS0/UMO21PHBeykMUpEv/GodOypQixO3RPskA03Z+2z/0JyUZ6Fs4IOizZ01yNiYFeJv3ZGh+zZt729OX0tnzA3pGnZKdVPU3oFkn0zoTGpwfhaJ2yx4t6FPDN7qMiFNruplE18UE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aDBC3XLC; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aDBC3XLC" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48541edecf9so73791655e9.1 for ; Wed, 18 Mar 2026 04:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773833643; x=1774438443; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GHLUexF4lneyzM7zmTateSGTa362+OfyNu+myFVzahU=; b=aDBC3XLCjFhsN7bmOeNjoCGZPUedoMkmAPigOLYQmIq43rC/7twLONnZm+fSY122Ia A7b8Ctn2sDoY1yRUoQV4sEEfcwfZOPH2z6ZonEZAMsv2fSDKhhKDKPnjL3DkPSMBGqvC PdCqRt1bsDEJOMIlreX3jq8bCdsbIXdK/hot9iOIDZMj4chk1LwiK2ZTbC3YpxMmpCRj 3GBExCKHpC3+ASddle2uQEuYDtZHvF7fxzUl9DAiUvPVHRcM8Gg0RxT3PhasIXB9doTH T7YFretPZ9oiqQlfJnsdxGK7kBzxxJnsL6k6TTTvYU0d2Y0FOxD6cOGLOWQEL7xDGMAf LyBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773833643; x=1774438443; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GHLUexF4lneyzM7zmTateSGTa362+OfyNu+myFVzahU=; b=KR86ZegjBK1ykJeCzEpTMmOh/o2zq6SQoc3E519P/SL1eVJcyUPv2Wvdn6Pim8a7vk i2tzCVEJFNkNuBmbYzdKEt77QaqGWKSg6ycnLAeRRKHIVlfWt+8BMtV6BNrb9hFHbUjY NExoCnpG+pSek0YrcTRDtzs3/vBHjnF4K50SOYrFB+YikPOzctanKxafgL+UkhiQZU6G 2urtxydpGOSx+EG3FSPFGFo6b2zyHhhi0pm+qQFvy2PHR0hnoOeIdyhc+wciUJ8lfUdu 4I+7nj2jSHpJSc6SZo8AtBSU1ukDdSwE3sp7JyL0AP4xoLr9rRpTUugMNRTcgxB0AOCl AnzQ== X-Forwarded-Encrypted: i=1; AJvYcCX3+h2ssjv1p30lW9k1hE+BYrlmEDrk+8erxfvcM4NY4RFvyeHqBc4LLhWNpiUBk+xjAiibH/Bqf83aDM0=@vger.kernel.org X-Gm-Message-State: AOJu0YyVhXitWqQ3yk4V+PsUXMTfGsaXawMJuQP16oGA1iRCBvpFZYJx 8bx+5FWiHDPiDUNo+jajiC4GbQA282sl/bMzVvswrO0kcUAs44GwAm+Gx8dHo84cff0= X-Gm-Gg: ATEYQzzG6kT77Xwo74q1WsPd8TH1g+SdGCIkkN+ERfJgTkKQ8tfUQZYTmb/VPuw7sfZ 2C8RHE0zPhoJYFaLEM57+MqNy31owUMmttQQRiMT5+9hm0uqWlAwI8L5jDC1CVScKX71GmgR6B6 KVsuxNavQj6+whBXW4MJxkqC5X1AzvpnM6oNeCBgcT6PxMkvnntgEslQKlzMydlPC01DzqlflUL edSa2jfVb0UqxsIS6jQLL62Meqw02/ACJwMYHcAqM5fpXNsWeuzjd7lFCfrnsiOW4HfYGu/h3dK XYCcVf2k7BK5ra1OnhSDQYhByjKJJI+avXcka1SW57taCjPGV2QUlaImH/zDmMuRmFubvqa07/U wyDoDRKInFTR60d+d4nQDfU9IBK7IPD1Nv/NAawDwy0SxeFVPqXuhfmEte0gvUYq2JAQFw86qJw p5JMsnIrSFJfqRe7ytwun9lyulp5NM X-Received: by 2002:a05:600c:3b28:b0:485:3aa1:a7f1 with SMTP id 5b1f17b1804b1-486f441bc51mr51719525e9.7.1773833643426; Wed, 18 Mar 2026 04:34:03 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856ea98070sm128585175e9.6.2026.03.18.04.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 04:34:02 -0700 (PDT) Date: Wed, 18 Mar 2026 14:33:59 +0300 From: Dan Carpenter To: Aadarsh Mandal Cc: gregkh@linuxfoundation.org, luka.gejak@linux.dev, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, straube.linux@gmail.com Subject: Re: [PATCH v3] staging: rtl8723bs: remove dead code Message-ID: References: <20260318092639.27055-1-aadarshmandal9354@gmail.com> <20260318104332.32093-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 18, 2026 at 02:17:58PM +0300, Dan Carpenter wrote: > On Wed, Mar 18, 2026 at 04:13:31PM +0530, Aadarsh Mandal wrote: > > remove unused and commented code > > no changes in functionality > > Line wrap at 74 characters. Add a period to the end of the sentence. > Also use capital letters at the start of a sentence. Remove unused and commented code. No changes in functionality. Probably saying "No changes in functionality." is not really necessary because it's obvious. Where it's more important is with things like changing strcpy() to strcpy() which could look like a bugfix. But it's fine to add that. We would have accepted it either way. Wait a day between resends. regards, dan carpenter