From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 795C23783D3 for ; Wed, 18 Mar 2026 13:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841839; cv=none; b=RQ/OQe34DFw3oAes891Qy5//xqdKxpw3kRL5Pu+kDtmylQxvZZg8EhDMllUJHhwdb99DaXfjkntiMIDHn+ckFOZAVxVhFGT7YIp4ImAS5OgKNNszS857sOwMzgdcj70/clfU7S6P41dO9joo3QMJm7xjfs7hFa00lCPq3R4/Biw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841839; c=relaxed/simple; bh=FB4+uwl/h5+rFp9eBCTBTvVdz6NfYKIMZduaOHze3TY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h8fgSqFST8vnuenxxfi4qLC1rMmQIkCtguNcSwmO0SpHHL4PKxHMNZ4fJc8SNslMFAvBZHUmCB/io6mnEaE21vRtxoise70qy8duShwvS6sC07llKy8ETyZHUL6TrNyqQBqft48p98j95+D0PS3EcM9ydcZSOoPUqYaOZcwgcEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=VIB0j+Vo; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="VIB0j+Vo" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-506a7bbe9d0so60805281cf.0 for ; Wed, 18 Mar 2026 06:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1773841836; x=1774446636; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dNIKutHT8Sq4z/Bn/gSEZuEvYmflVIDZ+z7WhX7LpaM=; b=VIB0j+Vo7cnI1NLOT2ckGVb486YAmpFpsqQ1tVBSOA78Lsl2+3uCH1AijvaIa7ssMK DqwJgi9kU+3sNZ9vP08d4y2N1fKrtLn+hqhA8ODTR0EW9V0tp7aX3n9cGCK3v/kCzScq Koi7H+DiRNvjkMoR0NhB7WdT5jLw43+KUOeXU4C4Bt0Dmu01FUiLt2yXau5kj7/H2Tbg kfy8I/Af7lG4Okz2GutumBr4dwx7qfenCRnYolvE0NfDnvo/mzFfZx+PST1xM4MpmXXJ qBmY3C6NJ7v8B7MqyXlD3AnEQlZpMMAkCYxvBUu3Ulo3mafT7Tz/6LheSRsN3z8UrkcO IXdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773841836; x=1774446636; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dNIKutHT8Sq4z/Bn/gSEZuEvYmflVIDZ+z7WhX7LpaM=; b=FKa+CtSkXhMfdnuBKcJlnOqgzXfD4I8YX89XRqszH+el0+IBeKfUdjVV79Lohj8L3i gdYKtueLpDKSmZm8cggQENxx7yIPY/1N+k0l2pEeu7NmcPIUtoMXdUVC3OKuELPMvYQS aZnStpYP9UNvGyZf7dtpBVK+lCyg//xu1+EX06Gk7NFMVXYCPATtJPv4AGaxQaUl1Zqt edEv7wyIFBvrhhM4WrQvG9GB7uCZaju1D9lzAeo8CfFQlh+KozhVaDfsm3L2CItP2YjV c9bm4F+h1JiMDYTDojssq3diE5y5GAX+mbyfMYg/RxBGfgj++UC/fx7+t8XYHgooYW1R NokA== X-Forwarded-Encrypted: i=1; AJvYcCUShnGcxyEwo+IiY7pF4n0V48IvuZCU+B0Dh2Yedf0Dc6AeqBdW5Nidm3b6Evs0cnJKObMpNHA3XhFHUTA=@vger.kernel.org X-Gm-Message-State: AOJu0YxbwtWc4mDm+Nd/868Ga1YPZVo2OKWk56Faq+1cxW65ZtF8+p3R bBhAee9tBTWPtAAkP9lnGbnT1lyu+SgywUv3lKit7/UbtJ2YEeqrzGIYWQ5bW9aoiGw= X-Gm-Gg: ATEYQzyosyEO/F4Rlwgpaq+58Ic3r3AFun3u3BTnP3FnvLV1tk3LF/KUXkC0fCMionl EHD5nRV2fonIESwwUjE/05PtOfFOSAXu2+XKFUQadcnztc5IoxtCYqAmnrbZA38JtlqLCjjBOOp 9ghw5mkdbkQSlgDtd3O1+uoUSa9G/w1AFoyTqhPbx0VFSbfGTsf9FjqdlGlhUei4xOAeHiBN7r2 BFL8nb7Y0g265fBYqwzGU+XDkgChsItNy7C4KAbeYfxmcKUARiASkE9hTxEFt7zKH2IaEOZLskY fYPTBxiN6tCs/UeEpyC1+aGLF3zVqIGfqgBrdFe7LORboSlQK6EC1apJmKj6Jbcn7AU+bXqlFir rzdLdmDPQxx3mAqRiEa3Qx5EcfuDsbGCT1MH3EDeOgBfwZppjLz87+8Naoo1Zk/KG3nkL762XKX 8xraaTYtkLySCqP9CorfMaiQ== X-Received: by 2002:a05:622a:46:b0:509:3c8c:2405 with SMTP id d75a77b69052e-50b147aaa16mr42355181cf.28.1773841836061; Wed, 18 Mar 2026 06:50:36 -0700 (PDT) Received: from localhost ([2603:7000:c00:3a00:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50b13320817sm28740421cf.0.2026.03.18.06.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 06:50:35 -0700 (PDT) Date: Wed, 18 Mar 2026 09:50:31 -0400 From: Johannes Weiner To: "zhaoyang.huang" Cc: Andrew Morton , Axel Rasmussen , Yuanchu Xie , Wei Xu , David Hildenbrand , Michal Hocko , Qi Zheng , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [PATCH] mm: skip dirty file folios during isolation Message-ID: References: <20260318090656.1748509-1-zhaoyang.huang@unisoc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318090656.1748509-1-zhaoyang.huang@unisoc.com> On Wed, Mar 18, 2026 at 05:06:56PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Since dirty file folios are no longer writeout in reclaiming after > 'commit 84798514db50 ("mm: Remove swap_writepage() and > shmem_writepage()")', there is no need to isolate them from LRU which > could help to improve the scan efficiency. The reclaim scanner needs to sample dirty state to coordinate if early writeback is necessary: try_to_shrink_lruvec(): /* * If too many file cache in the coldest generation can't be evicted * due to being dirty, wake up the flusher. */ if (sc->nr.unqueued_dirty && sc->nr.unqueued_dirty == sc->nr.file_taken) wakeup_flusher_threads(WB_REASON_VMSCAN);