From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6AB1309EF2 for ; Wed, 18 Mar 2026 16:44:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773852293; cv=none; b=SLTeFx5jgU0d2Gq+4GY4zQAV5REdeLg8hGY+rHXUwC71x+U1IOLXXd3JnLGKop3AkbhUV48AQ8V7DbzRC0DjraZqs9ADopWcKl4U2D9agHrdfdwVOd80hLL9kv4yj0DXg1fxzye7TjpOr05bcdfUxGay17w0LcE90PTBovKMXOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773852293; c=relaxed/simple; bh=hI43v6u3mwBgqFH4TTw2FSSWIg2WK23fMDJa0baECiI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oXbu7C6gdSOnH5txAJH1Q4C2PaOkQyASVCZOL0H15SsNg07lZayJ69iQL0imOPowDdBeZW8VCjABqa7r2VPRdlbKC9oWLKhSSBHSg1Lg6zGIPBX7nmBYkorv0afed9IlIiszq+aeaFmxK4UqwAyZOCN78IAETwt4P/6gVmGdwQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZGYZWyD7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZGYZWyD7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39D4FC2BCAF; Wed, 18 Mar 2026 16:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773852292; bh=hI43v6u3mwBgqFH4TTw2FSSWIg2WK23fMDJa0baECiI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZGYZWyD7hI6Kq0H7PoRY31k37Syhi3MFoZA68anETvUz+vd/If1yDcuz3dWSbKoYJ O3PBUVSltU9AYNGPfwJxEG4cOFdfINOKyEgYeWZ2zmd1XRSejGX0iPdIup0LVZFHCj Ztp+epY/WGbxjRfRgZF7+Xg84O+Q9RDB78T9gKOryicV7C5SiWjHHsFlVsTl2APNfS 7LtYBLBowDF6t9TTPWEjb0AzgoRLZ64GiGH8D5wvnWj7uFzCKqH/PZV3ev4VCbQCS8 Zvde5zy9OuyPN8BP5PKkTpeGrjleKMZ+x+ZE9DyAEfFr6gFFCHFt3T1bocCzxK18Hv 9ZhTFy1yVttzQ== Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfauth.phl.internal (Postfix) with ESMTP id 071A8F4007B; Wed, 18 Mar 2026 12:44:51 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Wed, 18 Mar 2026 12:44:51 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftdegieegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhunhcu hfgvnhhguceosghoqhhunheskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrhhnpe ekgffhhfeuheelhfekteeuffejveetjeefffettedtteegfefftdduteduudfgleenucev lhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpegsohhquhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieejtdelkeegjeduqddujeej keehheehvddqsghoqhhunheppehkvghrnhgvlhdrohhrghesfhhigihmvgdrnhgrmhgvpd hnsggprhgtphhtthhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehlohhn ghhmrghnsehrvgguhhgrthdrtghomhdprhgtphhtthhopehthhhorhhsthgvnhdrsghluh hmsehlihhnuhigrdguvghvpdhrtghpthhtohepphgvthgvrhiisehinhhfrhgruggvrggu rdhorhhgpdhrtghpthhtohepmhhinhhgohesrhgvughhrghtrdgtohhmpdhrtghpthhtoh epfihilhhlsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgv lhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopegsohhquhhnsehfihigmh gvrdhnrghmvg X-ME-Proxy: Feedback-ID: i8dbe485b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Mar 2026 12:44:50 -0400 (EDT) Date: Wed, 18 Mar 2026 09:44:49 -0700 From: Boqun Feng To: Waiman Long Cc: Thorsten Blum , Peter Zijlstra , Ingo Molnar , Will Deacon , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] locking/lockdep: Replace snprintf with strscpy in seq_stats Message-ID: References: <20260318001426.2664-3-thorsten.blum@linux.dev> <1a5b1a90-6445-4949-abce-6ec799b959b1@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a5b1a90-6445-4949-abce-6ec799b959b1@redhat.com> On Wed, Mar 18, 2026 at 11:43:49AM -0400, Waiman Long wrote: > > On 3/17/26 8:14 PM, Thorsten Blum wrote: > > Replace snprintf("%s", ...) with the faster and more direct strscpy(). > > > > Reviewed-by: Waiman Long > > Signed-off-by: Thorsten Blum > > --- > > kernel/locking/lockdep_proc.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c > > index 1916db9aa46b..e458fa258d05 100644 > > --- a/kernel/locking/lockdep_proc.c > > +++ b/kernel/locking/lockdep_proc.c > > @@ -19,6 +19,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > @@ -488,9 +489,9 @@ static void seq_stats(struct seq_file *m, struct lock_stat_data *data) > > const char *key_name; > > key_name = __get_key_name(ckey, str); > > - snprintf(name, namelen, "%s", key_name); > > + strscpy(name, key_name, namelen); > > } else { > > - snprintf(name, namelen, "%s", cname); > > + strscpy(name, cname, namelen); > > } > > rcu_read_unlock_sched(); > > > Acked-by: Waiman Long > Queued, thank you both! Regards, Boqun