From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 013013A7F61 for ; Thu, 19 Mar 2026 09:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773911268; cv=none; b=NvD/tiI0KpLzy1BOXIXUPAEk1zIXD/Ctxuvy22n2BbvFIIUTbPnw2nhmQvCwhBFoMnq5JC8o0KJfoe4kV0yjRsyWAqqyiRKGlV86ais2Ayg5yOQ7rIBXFYVVfXfM62sAjjFuO5Pms1yffPKfqtWQrboPel/4nsVg+cv7LtM3Ct8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773911268; c=relaxed/simple; bh=o86R9G5fnyVuwrye1sXZ5WhIYoTZ+cpEGEY4sGc2ctU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K8eYQ4p8HYY/vvktqbK8n7ddU3flcU07VPP1YZzpEHoE+EEzvgXIJg/GUSh1P8Sg0KpfQNGChIqVTd/9b8UKvS47VGBAfdA1ZZHLQWyEDl1z5IwS42LBIJErorBszhiZ1cC8keN2L5aFnRLC5UxMSCPmEar1c9Qy83aglNVnSZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=O1bjs3nQ; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O1bjs3nQ" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso3513505e9.3 for ; Thu, 19 Mar 2026 02:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773911265; x=1774516065; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z0F5JNQiV35BL5CH81YZuUNB9w2WsW8N3Go7UxMq2lw=; b=O1bjs3nQ3iT8+helJPWzno9NyhWoXr9YuO1Z219BoMdTI3wK009UuyoEDqCRjFPoTn FuJI26QBtY8LxMPXx9tffTGAgp4taAydUxpiXdYvf2siO0CnuhH4JoCTkhyVGysMGNxn pbPLhgO1eYzRAWdQE7FEl51rtAJYMOlbMl2jCvGixnCAtZNkL0beqOcSl0yDJ5f6sPT4 gl8Lb3nLQjmS7TU1uqkzsMOzNmSeRLnrsauWE7vNQ2FqWOl1ZqeAIbXvVMJk3bLV3z3u 6AMbXfJcuwqdL1V8jjgU9NtY3uWfJZl5wvOzG91050F+alDpme/WymEkenBay4BbWS1Y Y4jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773911265; x=1774516065; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z0F5JNQiV35BL5CH81YZuUNB9w2WsW8N3Go7UxMq2lw=; b=PHEJ3nb7fUtqGPLqkoAxyHaLrxAJEHPVyHsdkMHiTEAv3nG39M4kQTxN31Xi2xvnzi L98Uq7MmcTo7GjLteLRCTAQhSEVyBCWD438HMjPYzNEqNAYCBLsok0ouQIPgjR8Z2hYq TeTSjnwn0OZ1jjX2tGKn0iWIwrY80Xw/fa6pa4UDzD3O6emzxacMhcNs1+P2+vBTtljP /2JmVtWglXR1TG102lk99PhRpHejzsnIJVx44DZajfRJlQSS3my30TmeHWkxrPsmSHJL G7QAHk1qYISq9vtQ+0a24zqMYXrb9ni/BrpNAHvRkSBuQSu+vPL5NtGF6iFbJcnCUipM aGrw== X-Forwarded-Encrypted: i=1; AJvYcCUODIt4tQxB1r5H+Uyy5awsp2KnYevhlZFQdGCXCwt8d6odMaVBz1w6sSPPYLJ5o8/ND5pghV5iLY1KDdk=@vger.kernel.org X-Gm-Message-State: AOJu0YxRS0k01shja7/O++yoIaE4fNq2viLQ6yRGamXS75PZ8r7MdLxq miXX3Lq/QXbP9jeFCCZHXaEfEPXwsji3J5VGx+D5AdaQxG4hqQ3wQOlkePBOd1xgM/U= X-Gm-Gg: ATEYQzxhUwK8i1Gro1IL4EgJErdP+3TNYzXRQH16qvVVnih9p16LWDhcGVUz6kMPGBA xpqexDvttOosJOSF2w8cagGIooZ1TZy9BjbaB+Sej1ElZZVPsg5pNolLOG1XffWOdozM3eZYxIK euaL8ygbXX5z7ORSZ/SwPn/L6sdFHnrV/4Ye7JWG3gEFooeGragdB4U/PWnVzD82rT4yesZBXcu r0k5nqOtGJeverbtUvSY+uofYi9GErR8oOkzTuXU5lcPlFfg71Hl+I7wFNzY3nymG6AWrfq1dmf VovlAQIbL+N6BAptsfzk1VslU4q6JzsRUGPtRP/uRhFmXBNj6gBjZPBAmakGUoDXuffZMZEcOsI j1wg2TFmFN3lWuODe/dmPgd7d2qwwZqOBmQFi4xuFtwU6vvx6HlJ/PZ8TQ0/OxyLyAUHO6Z9n5+ w6Nl63U9eqfOXckzcQrZd5T1JmnEQb X-Received: by 2002:a05:600c:64c3:b0:477:6d96:b3c8 with SMTP id 5b1f17b1804b1-486f445e17dmr95988505e9.23.1773911265193; Thu, 19 Mar 2026 02:07:45 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51852a64sm14866983f8f.14.2026.03.19.02.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 02:07:44 -0700 (PDT) Date: Thu, 19 Mar 2026 12:07:41 +0300 From: Dan Carpenter To: Malavya Raval Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: Rename TrafficTransitionCount to traffic_transition_count Message-ID: References: <20260318195924.2096-1-malavyaraval@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318195924.2096-1-malavyaraval@gmail.com> On Wed, Mar 18, 2026 at 12:59:24PM -0700, Malavya Raval wrote: > Renaming CamelCase variable to snake_case to align with kernel coding style standards. > Line wrap your commit message at 74 characters. > - if (pmlmepriv->LinkDetectInfo.TrafficTransitionCount > 30/*TrafficTransitionLevel*/) > - pmlmepriv->LinkDetectInfo.TrafficTransitionCount = 30; > + if (pmlmepriv->LinkDetectInfo.traffic_transition_count > 30) /* TrafficTransitionLevel */ You moved the comment out of the parentheses? Why? What does the comment even mean? So many questions. Are we could to keep the TrafficTransitionLevel name after we renamed TrafficTransitionCount? Probably sort that out in a patch at the start and then do a rename. regards, dan carpenter