From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB0A93B7777 for ; Thu, 19 Mar 2026 09:11:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773911491; cv=none; b=tbWMPg1PqBeVPI77b6HpfDLAGflGcncv69onJ3nwZxg70hozWd/8v3WMc3f/RChq7uNK9zV8dElaOlr9KPLt5IoWywTnQdct3gipKpQEyOCX0u9AP6vALcsP2Sclx8J6YjGrdpoGIqI2+8EwwlREJsqtppuaW6MtJLQjv06C5rg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773911491; c=relaxed/simple; bh=VlMFGqFNa6qHJXYwlaOw0p65lxbN+ZKNFr8Tvj0r90Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JiOHrkius3gqSIBXVPzrJYYgssKb1auMag5eYcaYa0JV33Y1q5qPQ7RrYAMEq/DYia1elcUbDfBBxTLbmxKU3BVtSAdpr1Xl4AZFZLgUWiwKy49bVLEsgbTCJ7eBrlfZq6QComzxhVFffJIs/CiFfXDuoDxGVBfJvMnnnBdZ5mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cXjQJyHi; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cXjQJyHi" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-485445e80bdso5858825e9.0 for ; Thu, 19 Mar 2026 02:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773911488; x=1774516288; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/KMsuMASLWqV4kBldHiypQUMWM2QEM26nQoK9tIBKiA=; b=cXjQJyHi4MmRxG8QMzZPdXy187FxpcqIhpigzx7VH4k5VU4wf+XvO5aDdGqzdXsxa6 w9bfeH79BYTVXHv6m6BwvPwAxEnMU1lJhChRUmKA5v0Cnou68mq9Dl5ANlfaBsLL2PO/ Wfx2EYsX/XGPmEfIWlSzc4PyYtArk66bSuSKcQrYFscFCdQg4gZ6rlPyWPYxVKCUshIm kj5o2CT7V8tHA22vm87E5IH/g+ZkzT0l2MPRfH7ZwtZ/D5ll6HPPrRGkgKBabHQmouDs XubrSmaKSfrqupICw1yQqkQzjxuPA7kbLt7V15wTM9kj2l2j3zDQEh86Bauvnkwwfc5P wXVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773911488; x=1774516288; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/KMsuMASLWqV4kBldHiypQUMWM2QEM26nQoK9tIBKiA=; b=S4w4jTcUpJJAx0uEzcwenFoyHEu4wth9cW+NL25/lvnXtqC/EqXGi++aTlH/RPt29P E2zYJvottmTk9HqqKQRFGwnjyG4AJS75EWbxaMcfa1HHRTcsximxBNVnTcE7s4ggn3xm /kmUdFIg1bD8Wfa5CtSBts5OmQ3OO8vEWwe6cRFwrSwduRhAvsxVNgJBWkEtoqhYh3K1 3ZgR0Vk46dNINn3hIM78CHXC2syrw7JF8s4qrR/aOiIBE8MryLNFYjSaS3M8MXfIWlTk WRaUZEOUYJ74QP8P6u8rVM7RXNHhTvTWiLkojA2F1wlcAb/oPZW5w9WEIUzXlcooMIo2 sOsg== X-Forwarded-Encrypted: i=1; AJvYcCWEJQGxovlMsOAbKUTgjZ3MDG/0uSWGnEmYpBYPn2wh35fUvTBN2S6N4CnKxm/9cmKUOszAObnMSoj3Hx8=@vger.kernel.org X-Gm-Message-State: AOJu0YwDHP10ljX+ajeIjO361NuxjmLycRhCjXePk2FeMShiEKIrQx3k QVyhHXoPju5o0ipp1YKlIiTuhVCSzwkW5s9vRWyJ92Evf2o3grW/xjbeMHmt4jA1hIM= X-Gm-Gg: ATEYQzwt0uR/l+dFXtqbCYfot3cEAGdUYrsmRl3cXMZsLWtOUE6RmQcML8u9uvmO8Nk uR38HlVrgeASLqjkETidWFAa36lCaLcwzVA/iNT5rSp7Al1vOLAyQ60VAZmeRToiYbOY1cOJjkn RTDNvtNMrnxRaCjPscAzrBB3ZdKjXO1Bd+4bgyz/qYdZemi6aU+3IsmMC03ezfdrUI8QOfe0l5E M6FcfVYE7PhJnO/NnVQe/ijs9PBQN64oX7P4lTpuK+9iMEH3sn+pqHiJ/7Bz+3YZaPVfH3hsDWa aoYYtXNzw/Qv85maUaRQh9tg0u2j0J3nNmSEGzOZhUKoqVqQTTlaY/lRO4c8be9D5olKfpTL3MF e2ZW9X9yWZfCaGpsViWycksKaGnWB8Bz71o4Wf9bS3WnuogVchbcxJUb8UGc17pnAz4qG6LUBTQ 8gWTbt2HwpNwCwKUAmqPwRuLDVrsUN X-Received: by 2002:a05:600c:b8d:b0:485:3a27:a961 with SMTP id 5b1f17b1804b1-486f421ef58mr97208055e9.0.1773911488270; Thu, 19 Mar 2026 02:11:28 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f4e48ad5sm167617435e9.1.2026.03.19.02.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 02:11:27 -0700 (PDT) Date: Thu, 19 Mar 2026 12:11:24 +0300 From: Dan Carpenter To: Oskar Ray-Frayssinet Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2] staging: rtl8723bs: remove unnecessary braces in single statement blocks Message-ID: References: <20260318214117.10285-1-rayfraytech@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318214117.10285-1-rayfraytech@gmail.com> On Wed, Mar 18, 2026 at 10:41:17PM +0100, Oskar Ray-Frayssinet wrote: > @@ -403,10 +385,8 @@ static u8 halbtc8723b2ant_ActionAlgorithm(struct btc_coexist *pBtCoexist) > pBtLinkInfo->bPanExist && > pBtLinkInfo->bA2dpExist > ) { > - if (bBtHsOn) { > - } else { > + if (bBtHsOn) > algorithm = BT_8723B_2ANT_COEX_ALGO_PANEDR_HID; > - } The patch introduces a bug here. > diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c > index af6cdda8238d..f4b2854bada7 100644 > --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c > +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c > @@ -25,9 +25,8 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, u8 msgbox_num) > > do { > valid = rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num); > - if (0 == valid) { > + if (valid == 0) Don't do unrelated changes. > read_down = true; > - } > } while ((!read_down) && (retry_cnts--)); > regards, dan carpenter