From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45AFC2FF643 for ; Thu, 19 Mar 2026 07:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907177; cv=none; b=u83VmAmXDk7WnB3DhKmkM4C4M2kULtJFoOjYLmwWQfO5oejg7PlAk+i3hZ51IHFj7a6I10OqxPhrlJtrI96br3o2JeeagF2/rwaMlTZ0zjxa1zTvtZVWmqCDvKyuE2ep3bicjR1bsH626QMwaqEBYPgR8WxUXFipVADmYpUlySs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907177; c=relaxed/simple; bh=ELCzqXit/oe83VIDIh89/ZDRU54F/m5y80ods+85gAk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E98Vbb4AnFyYKrPYm9zEiq2wv7a71o9Exs5u5afPLo+7R73FbD/Ump61t1o5JSAqPT9JLT55zCoaHBE5VRrILQDpRWiOkcvI7G4vc+ip00VuYWohKQ0sgWf1KFtsF3SX4FS/aj7Xw7MgJB1xQ+1deWKiVxdS0i6qTfpZQdOIC3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=l5FAziw1; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l5FAziw1" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4853aec185aso2372855e9.1 for ; Thu, 19 Mar 2026 00:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773907174; x=1774511974; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iSK5A1S1NLHAbiNruCvB/8A9CPcmcJkE4A1kCXD3HQw=; b=l5FAziw1nw+6d7lxF9/G9QQN5YoNSgs17ch09Tw4SdWSH9kQqE7xFBQklZCfby9+0i 87PZjD60ObylDZ6jj86YOgJKBt+XmC+rAHAdOC72P1W/EJLdXBGxTxCDIM1hQ3eRadV8 XatnEwx5SU5J/gZfK1YOmcz24K0nrWoDh8fKWBAfsoLXNsfkR6fN4hu6AjmU97FEi0os 7ga8rHR5/U4t6CxbIjIbxkF6GugrE/lMah+MGwIpOosbLV1NSsoSB0k5Nu9MLgQUe3bR +ljoDOcIS1egQhQlHia6IlvzAuV+F4jDW+eanNPFD6kABo5q+MP1Q39KoQRUXpvsVtwG YqPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773907174; x=1774511974; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iSK5A1S1NLHAbiNruCvB/8A9CPcmcJkE4A1kCXD3HQw=; b=JlYZE19SBsDai4lCAKX08pb0ENxRw13TGzenl7z8+q9WGv4XBQBIcG7t7guMZGNhST hX/nCZAv9yRunixvuWJcZvMPK3HPG68xrOp3OCUpqHnZpKPm9ptZS7g+1mgmkGKYhZPq 3cGFH272lQjdHWe1u7Up/y0xT2MJ+/DcB9TZCmhUC8FYtesKeeGbUN6k+XdSYRrzAL5w wBH/1qIxLuin4nL/lXRxlV2JgamWAg7px9MyFCf4MjOEklJlxN6Qc64YdIR3U0mZMvWH 6Xare6YE3fOT6AKNo6yTYSENTzUd1JvnT0XikWKqDf0OKwQqOUrO1yJ14afKgD7ruAhJ pN/A== X-Forwarded-Encrypted: i=1; AJvYcCUXE2z3FAJiUyrceQ6ZrXE6LLHdXRXsDMrTZgi7inu+I9nByHcI84X5yYv4CYpTN41PwjQeJW/fYxCDyds=@vger.kernel.org X-Gm-Message-State: AOJu0YwOffu2jFBhwoUkXUY2n9BpRflFB2ZOvXs4QZsv7moOkLY6D+/P pYnCmNSr+mIpVpW1Ncx3pfDPz4W/hEAyjtBBX+ec0XdrhUoHjdDFnlFciNq0UmXe648= X-Gm-Gg: ATEYQzwGxXZ8m+0HlMYMVEMFBCR9zrNLmRETOWhqRdCtYz3Aiwre8fk9sY9hzoKVk8M jSswrXJAj0vpWW6E4C0vwQND1jrGbYF7sThzu4SJCgKdjKtaobJtgitV7hQcUgUIlYXCUfkH7Vd 6w99Rg071OxSkzNG6vhzNbztXjtWSyFKQ/W4zKnnFk22R+FQBTnpL9ugmL5czyKw9U2mRCoEwXh NgiYr8SU3gE6TOB6R470kBmGwBNx0+FoGiPbBOS+N/7oBXmTfhovVi/vAMMQgL+jYx+u5BJL6SC yL/Il6R0XgA4nBthAblXjgFsPojMcc5BATzsL818ZwPsiiE+C6XjirwPXegjMMg44gFFLPf+/fV 731PMe8dnzhhxH1Iy2kAIE9v276SVOXhYcVw/Xhjzmsm7v/U7kvGNObYdsQ9WZSNDWLCT1YMNWV SXBpU5kImbJ6R4MA28h6yqP09rmKLz X-Received: by 2002:a05:600c:1f11:b0:485:41c4:e2e5 with SMTP id 5b1f17b1804b1-486f445fad8mr98623725e9.27.1773907174592; Thu, 19 Mar 2026 00:59:34 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f466701dsm69781355e9.2.2026.03.19.00.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 00:59:33 -0700 (PDT) Date: Thu, 19 Mar 2026 10:59:30 +0300 From: Dan Carpenter To: Lin YuChen Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: use guard clause for AES check Message-ID: References: <2026031810-kitty-untamed-2812@gregkh> <20260318215124.22612-1-starpt.official@gmail.com> <20260318215124.22612-2-starpt.official@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318215124.22612-2-starpt.official@gmail.com> On Thu, Mar 19, 2026 at 05:51:23AM +0800, Lin YuChen wrote: > Refactor the AES encryption check by using a guard clause to > reduce the indentation level of the subsequent logic. > > Signed-off-by: Lin YuChen > --- Let's do it a little bit differently. See the other email I just sent to v1. regards, dan carpenter