From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754B73A3835 for ; Thu, 19 Mar 2026 08:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907911; cv=none; b=EwnqjORH6FgWSBfLSepzwDwOdP4FYMqoNPjvtUaMC5AmLu6iiyg0iTa0YteFfBArRLgWapUdyNop4JE693gbUUYCO8T4zlI/DHiL2l8lMhdunDB4O0EjWdmN7QscjqkgsO08xCLg1pRFDcOYheNU28UGbBQWxudcoOZ512XbTKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773907911; c=relaxed/simple; bh=AvTlZwl3Eq3gEVAQRBcNEHdpUnSGv301KvWojdi2zIU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tnsS2jiSefhlmDXSNmZhdHl5RQbikw4vpald9bLTjzBDjmN11l6SNrozOFGODvD//RSmh//WGBo45TfOtJStgDayLX0MvcwhMkUPc8B0K1P0gxYJaNvqFFolgbWUL1EKmHIy7UXodpIVVItrPlsgbm6bg2sB9sX9EOExvG/w/b8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vjNu1FAH; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vjNu1FAH" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48541edecf9so7239605e9.1 for ; Thu, 19 Mar 2026 01:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773907909; x=1774512709; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=m98HIpnhM5vgvcVCxZI7C0rfqkBDtUJKk8BrMpO2jjY=; b=vjNu1FAHU8vd8DNTX4Mpi7+Fx21rT8lZ+9Q8aqg+8q2BSv24Zhe3d38tGmZUP7t6WK bAv4xpC6c1Y3FMSptEhzp5TsY8iaF1V/chxz4mIjuAP7u3ynTFD7pwWIw4ekiNqiwNby v+huI+voFJj5En1Me+8NKwyVFfT3Ay0hOuSYktEsu5VH+Cc+YvJh6OVY1TkBcDUT1m8A HaO3NwIIw4U2bJVXFSD+eR3s+sbLwmCaJRcTmcGJ6CfpXVjDsdc0kJPX3vF6h48ZvGjl 7XnsufGXxBi6i7swS1ZOEYzvelZMFXuv1rEEpYoZxPST1QR20KNxJ88gl8fJhXOREw52 EcjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773907909; x=1774512709; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m98HIpnhM5vgvcVCxZI7C0rfqkBDtUJKk8BrMpO2jjY=; b=aDKoB9LCWEsZ4A61b8sVQt8EQaNomH1A3f/LDDVYt+04sKRrRRccAfvwZ69aaLGWmP Ik/opJdjsRD68CSzrEBfZHTZLD2S6CXwKW21BqJR5o86kjCr5pNQcEMKcZsGuwFx0laY VtdwA55+4LwrmxmyWhGqqG/4uilvA9/yyzN30dhGNrLfZopp4/Oz3WrUNDM2YJZp16L+ NxXX421mGNfpFUnWLYYDb/Pqvcb1nwFj1x+Eb6mmjxSbEiSlo8BL7axewSSl3N+Rxoz3 azyd8efN3KuH9zw433bs4K2vVFSFjAIM8TSEAIdq0iBdgCY81xzzZLIc15Ibry52moE2 W5iA== X-Forwarded-Encrypted: i=1; AJvYcCWesaRT7ZXKyyw71sX0AFoSJ+KET/H9gDmRpXJNE5jHRHZ4Y+bB5sNkPBC9T+zgQ2hKmrrRcet9Ml3nuVc=@vger.kernel.org X-Gm-Message-State: AOJu0YzV4X0Dakkb2lZuwKhm+a/GU0BpQCaLjCFS+QfHHRtGvJDOP5/G bf5giHIUWnaJJv69L0dS3sKUlRxiqy4hcoFbmWNclrHrh/p1O4nvRuB+0ie6o13wtMM= X-Gm-Gg: ATEYQzw6Vv0Cq0H1sxjuWlmBysDeBpO9i+8S1ylZFxRVOuSMuf+Jt1NKg3TH+JLH2FR YpqgYJVKLfU8b1AmEp5OSOnECd5gfB5GwsE+GiR3NHSegLMhsZEcl5koU2MXKy5ITUldJpMtAnx NJ7E44bdoka4KyaZgXzxRaYc3jrSbhuTIwhve4E3Gn5EylIxEM+4cT5T/NLQt43RHkOKtFjbFOQ /TFDRxojtDb5Id8CA3DlfKVdcprtgEiYps9vgZ/AhC9lsYE8dAImxSXGKcGtwLLMUs41BoPSjRf bmhWuxRYoK8l4aifOhkWgjWRTXxyb8NCrw1RHc+L/CcyU2NknJ8iDK/8H0rP72PqUqSt5q+flZf hRD1ysafztXWJ1UNEYHzRX2vrxiI6urwoaq1Vwk1SZazE7GIiTQ4vdQ1othh/S7e5rdJE6pJMff yrEtjBpF2y7xVNNulrlK86TTrMYoco X-Received: by 2002:a05:600c:c490:b0:485:379b:57bb with SMTP id 5b1f17b1804b1-486f441bc19mr101424465e9.3.1773907908693; Thu, 19 Mar 2026 01:11:48 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fc3b98f2sm12630455e9.14.2026.03.19.01.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 01:11:47 -0700 (PDT) Date: Thu, 19 Mar 2026 11:11:45 +0300 From: Dan Carpenter To: "Jose A. Perez de Azpillaga" Cc: linux-staging@lists.linux.dev, Greg Kroah-Hartman , Michael Straube , Hans de Goede , Khushal Chitturi , Vivek BalachandharTN , Luka Gejak , Ethan Tidmore , Artur Stupa , Zhuoheng Li , Nino Zhang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: Reduce indentation in rtw_joinbss_event_prehandle Message-ID: References: <20260318225550.535368-1-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318225550.535368-1-azpijr@gmail.com> On Wed, Mar 18, 2026 at 11:55:44PM +0100, Jose A. Perez de Azpillaga wrote: > + if (pnetwork->join_res == -4) { > rtw_reset_securitypriv(adapter); > _set_timer(&pmlmepriv->assoc_timer, 1); > > if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) > _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); > > - } else {/* if join_res < 0 (join fails), then try again */ > + goto ignore_joinbss_callback; > + } > + > + if (pnetwork->join_res <= 0) { > +#ifdef REJOIN REJOIN is never defined. Just delete this code in a separate patch at the start. > + int res = _FAIL; > > - #ifdef REJOIN > - res = _FAIL; > if (retry < 2) > res = rtw_select_and_join_from_scanned_queue(pmlmepriv); > > @@ -1260,21 +1197,92 @@ void rtw_joinbss_event_prehandle(struct adapter *adapter, u8 *pbuf) > /* extend time of assoc_timer */ > _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); > retry++; > - } else if (res == 2) {/* there is no need to wait for join */ > + } else if (res == 2) { /* there is no need to wait for join */ Don't do unrelated changes. The truth is I haven't reviewed this patch properly. I see you have made other changes unrelated to indenting. Don't do things like: - ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, cur_network->network.mac_address); + ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, + cur_network->network.mac_address); Those make it harder for me to review and they're against the rules. regards, dan carpenter