From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0248202F71 for ; Thu, 19 Mar 2026 12:46:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773924393; cv=none; b=lveqMpQRrHKSBfZuNmefpj9pQE0XNMhd/1LU/6frpMpvGC18oUugH1TqhauiPtmhVOlKq5+LwO2kENvsexr2JFo3Sbj6/U60A8KSiETCXaEFeLGSIWm2VkC9nZxknt33eQW/T5lL0wDb9tG91VweADFAwgGOwhhKjPP1GEOMing= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773924393; c=relaxed/simple; bh=4VsJGYB1khL+bEjHRCcfatL2q9eXJP+N5l6uJg4pMaw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sjqL/VCUSq4niTZdMgGb05M3Q0KiPJMUbnP9OwxFyPaFrGESrfdSic0l9psx+RG2xNBof1/eqXvK5L3ePVpOsXNW7uZszcO54hSX8yeZXWJqOxDZE432Z0JkbHhb23sPUItJw2cuEPM92U3lfH24okMlLRIKK6/EuW3Dj33Plxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pvHZk2z6; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pvHZk2z6" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-483487335c2so6744855e9.2 for ; Thu, 19 Mar 2026 05:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773924390; x=1774529190; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jrdVngQux1zt6cpTj5rJVFELPvPZPMx5dul8K9hvfKQ=; b=pvHZk2z6GxwVg0BtDXOJegUhloUUWH2uCMg2vmOR/4Kx0x5cCHOykWEUiu2I5tQyEy 65ShGNsKisQ8V3VLoNqsV11y7WcBM+U0zQ23mc8ld1Dmpb17ABu81MfjGoRlMEFo6n5a sxFVrOkRSvQn8F+O8uFNm/ZwGtzLCsJ4LyntR4OcOvAFwBJL51knW1TND1lAkFFoeeTi PSvsrFDcbT9MNfktC0QxErW8E8m3J3rYWhVgAkph9fRERd/0jlKlPlBdJtRpjZcQXBPA VYYQulx5vjh5p4/EivBZzXQlWiPEVvkc+7405btAKjfzMFx6ECB5ZxEq7xLAMR1ZqSpi 2Q8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773924390; x=1774529190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jrdVngQux1zt6cpTj5rJVFELPvPZPMx5dul8K9hvfKQ=; b=Hbx70po4YtA87W0CTObHRCaxpU0WSNhovFPJmtbv8kivgHXOmeIPQ9JlLuRP6MUKeF EB4hUv6J+OVJXqww4Cnc33MdzioVjsC4f3NurrkhLPxeIqpzZn+fdNxA/In5Vtzd7yPE cZoGFr7WgDO+PYftkf2TyjT61/A3vycBRgRO5V9YFgf/WV+D6p5ZTdGqgatKf/GA2XRO s7j6kptKA4MBrH0/gwz2hE7dmL7YP6OsveuADOwazeLOe/7x26wNayg7CLBX60DRPB0V Em6gHA9htn9Qub4lWtJb5x5dJXnefkQWNfvl4HIjHkS0Wkjt2heL/kOHBmTFH1WGxs+/ TTJQ== X-Forwarded-Encrypted: i=1; AJvYcCU9VH0/BmWH5PLex6Ee/X4hUZ8hdlntbsuJLlvaAyYfrS8XvqCJulA7urAfa/o6/xwKgaEnkOk4e5TUpkU=@vger.kernel.org X-Gm-Message-State: AOJu0YxXL2ruhCygnjhdqMYKDGBAlO+iAW6EmylybqOQcwSJGN9rEMMT Bt/7sI+V5eNTbG2eHMWk5iZeXt0kOeLfLP/z9e/Uq1gnEA9I1Ie3uBmBxoHmyLacRTE= X-Gm-Gg: ATEYQzzLt/HZLcy9lYEePWUkpOwFAWgOdi/CKH8eNCuTNSyld8sMRbp9obM9GgnVKom +PhnT93DhuG2Qz/vLCbun9Q7JGrlxOS/H1baMjycXnmtvJrDcngBqvpMcHc2Mw72HQXVqwKv+uD 9nwLhpZjrGc+k2YuWLzK5kQMp2rUWJyMTOuCjbNMe8KJHbZvjr6ooAzzJK4xfxenbpNJhx6IPM6 qUUV3w59dR9A9G+mx+9TV6Fm78rwGhEabMmxvV0Xvu6ctT/SwNYwERJp3aOuRUjNkUTGhHdf5/x liWfxl79fOD9tmRmp3d2kT58Wy2XMtiUxC349Hi88PgHIVdZOG/JNytNkZkcHU3gs6pgC/F5Mrr 3OSm05e/s5SquRLa675RoZ9ARRHEIfIOu3tUaZYjwI+2hz3iiNbHu0+PKYHcGBlQTJNQ/ioqrWE BaBdXnb8mTvURHuf+bDjo9CKe02BE= X-Received: by 2002:a05:600c:4712:b0:485:3f72:323f with SMTP id 5b1f17b1804b1-486f442922fmr112465505e9.11.1773924390109; Thu, 19 Mar 2026 05:46:30 -0700 (PDT) Received: from localhost ([41.210.147.106]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f5e23874sm74124645e9.6.2026.03.19.05.46.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 05:46:29 -0700 (PDT) Date: Thu, 19 Mar 2026 15:46:25 +0300 From: Dan Carpenter To: Lin YuChen Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] staging: rtl8723bs: refactor rtw_aes_decrypt() Message-ID: References: <20260319120737.29692-1-starpt.official@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319120737.29692-1-starpt.official@gmail.com> On Thu, Mar 19, 2026 at 08:07:35PM +0800, Lin YuChen wrote: > This series refactors rtw_aes_decrypt() to improve code readability by > reducing nesting levels through the use of guard clauses. > > Changes in v3: > - Follow Dan Carpenter's suggestion to use direct returns (e.g., return > _SUCCESS or _FAIL) instead of "goto exit" for the newly introduced > guard clauses. > - Revert unrelated line-breaking and formatting changes to ensure the > patch remains focused strictly on the refactoring of indentation > levels, as advised by Dan. Thanks. Reviewed-by: Dan Carpenter You don't have to do this if you don't want, but unrelated to your patch but the last two bytes of &le_tmp64 in rtw_BIP_verify() should be initialized. Just set it to zero at the start of the function. Otherwise it's an uninitialized variable. drivers/staging/rtl8723bs/core/rtw_security.c:1308 rtw_BIP_verify() warn: not copying enough bytes for '&le_tmp64' (8 vs 6 bytes) regards, dan carpenter