From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3209C3E8C6E for ; Thu, 19 Mar 2026 15:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773935375; cv=none; b=CDcKsB82xxBZEthJtUC9lOzZIXfLTLSCF2KuhgggF80hz/UVeRyDm69qOERktqzz38/6zU8TSv/duKPwkdjJUGGHTeX/iK1ujs2qSlPgpIP5IdApxIuNQjKzfc4TkY8inopQJC2o9aPACPjfhS9ETWLwga6poPjd14R9F8+dVcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773935375; c=relaxed/simple; bh=Lhy7nT8i1Vns4v+z0g3j/P9O2EN0ixqxwjwqT4F3Zd8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=db6hkEuuSFs957TIZoMvNu5b7D1ZIa/QTnIEjiFasLhxL7VM2oVyiABbuUtOtIMeb1dV5TLObTuY+K8QeUkIfrH2rPY2SM2N+63DUVpVzwmyL5mGwLZp91FV3Dop1xTg0dXvJKBCF6hV0YTfBI6+1o72/XAlfkkSa0UxdoGXP+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=raHktRk8; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="raHktRk8" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so6041655e9.1 for ; Thu, 19 Mar 2026 08:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773935372; x=1774540172; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WOygSq0gymlMWHm64ER/xpeBmO60xp2f19A5m9z4Lno=; b=raHktRk8qzhOoYyrnNTXjzxfFvKTV5nYYoobzzyRox9NBdHxFbI6e38cgosWNsY80O iwVI/MPSAKX7JzMSmgq8Yn7BuiZEFTlcy003G/nMEpUlw+Qa3AkSShAe8xrlCkJGvF9k Imd7sNnkHESE2icsvo3eQ/NQqBQ31bDDvP9jzgHowMP8SXXwCo3nhUpJLHm1NaBuixsR MV8fPi0dqzOxURaDG3JAe+W8D0euu4o7lqy2paGkfJbmFHVzPjSGHzoJKLcM7Kj3vCBj y98Fw1glB3o6vGNUYmeWQ0WZgFxJ6FiVMmJheD9IyBDckakE1dslZ4E5vQQnz98Vzon5 ICbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773935372; x=1774540172; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WOygSq0gymlMWHm64ER/xpeBmO60xp2f19A5m9z4Lno=; b=TN9aZq4CpUTMadp0ljBsxHFEmiVw3Yb+rbuXsH13oMxisp+h9rdkVF7e3Xw9ATqxcm eniWz8pJe3J4lDSViem3H04VvCUDRUJdlNsbgPss5pQNYL6DHtD/vP9Hm6M2mJHkmCsA 7gYq1yn/yrhZz9oqAbOwP4J0m7gwX0gCaSzkoux7y16CNljVSagR/5/fp3Tc23aLTC6P Km15jK4ZgSXU3l1moMUYKUhPZy/iiAer3/XWaIja6VQUXp5p9b9Nmrp/1RaVdZjto600 oeiyjQsBBu3jL+N27VlitIQGzCdgRH4ioxSZiTPwozGu9lUck/+AIST+xMqSs8PQcfy9 ebBg== X-Forwarded-Encrypted: i=1; AJvYcCWhTS5KCSkydlIU7gZhK2MWmsxJgWftHsuwchfmUuAtrsVX8gxhV98yHwiyzqEZOc8gxA0ELfbD7ZCKEEs=@vger.kernel.org X-Gm-Message-State: AOJu0Yysr4BnDha4f8aOLpkgy/hlPltptEBxRurAwqyT7AIxV6Is+HEe fLO/LANOib2Y/Jbf0dc9pPjoTPsjNS86geHG/80HFSNyya6rO9uyf0tAjCEWt/iAbu8= X-Gm-Gg: ATEYQzweHfDeeKxqyxSW+EiqY/AHLWmddv2fQOfbqDlsauiGp9YArdVB1/9C1TZOoVk dA4CxUFuxQUFEsV967pxNKcAFhcbbrZK9lIak6hq2zPYRTsHqk7Y/SntpGGWubwPJgxA977jiK7 2ZaV8+XttXs4gy4E3chWrLWMd+TB58SakxS1zuHNw1Ivx6TkJzu6GRuai3+wbZyV7M5yaji+MxX bfVgHmaj4P0DT6Odrvg2O/1bR6nHh4mgMfWBBjV8AgXAYpS7tm1sfh7WF7eFusPvllR0MR68+AY UgmAtcgr57Iq3qD/5mZMA6/JVqDFa0UWHEdyUoV1aTcwssuzfvOUdRL3jFnNpe+L4JfG1uV19U3 tkwkFuRuCiWG/XIZJf/OROFPolTAYRmQ5Dy5HIHAJBiLqawAIg59Q1jOD0u+A9muuSIcgDvLNw2 WEG8Zc/nQ3gfhTZqMxvQqu5yzGs6SZxgvTS6voAtk= X-Received: by 2002:a05:600c:55d7:b0:485:4f11:aabc with SMTP id 5b1f17b1804b1-486f8b80e07mr53687185e9.15.1773935372486; Thu, 19 Mar 2026 08:49:32 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b518522d7sm14543730f8f.13.2026.03.19.08.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 08:49:30 -0700 (PDT) Date: Thu, 19 Mar 2026 18:49:27 +0300 From: Dan Carpenter To: Gabriel Rondon Cc: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: audio: use sysfs_emit() in show functions Message-ID: References: <20260319120201.25210-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319120201.25210-1-grondon@gmail.com> Doesn't apply for me. On Thu, Mar 19, 2026 at 12:02:01PM +0000, Gabriel Rondon wrote: > Replace sprintf() with sysfs_emit() in all sysfs attribute show > functions. sysfs_emit() is aware of the sysfs buffer page size limit > and should be used instead of sprintf() for sysfs show callbacks to > prevent potential buffer overflows. Please clearly state that there are no buffer overflows in the current code. > > Also add the missing trailing newline to each output, which is the > standard convention for sysfs attributes. > This changes the user space API so it could potentially break a script. regards, dan carpenter