From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0437283FE6 for ; Thu, 19 Mar 2026 16:48:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938889; cv=none; b=KHb4TO/FRTaFHnjqIdnolM8411sLgnX3Gk+EsomzqjJv6OiVJlEvCCzDlKRMgQlMhyT7A4UJdOcNeiP7jK1tqKIgzgIKBfDny+aQoVLMmvmj5jbeLNff7K7WaXbxUicsFF4Wh9MJPB+9gLfGaalXwf6Xa946W/9IXC31B4NPLgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773938889; c=relaxed/simple; bh=teN9rHC+AlZMPQ01gDcV+h1Z1akhTATVIwlsU6sLgQk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZLdNRArtA3Kc7suLFqLCvum+HdAgZIlrPJ/CmAnCCtrzXOXd+GXp2qV+VTDvEaeU1FAOVNppFCjxCcecK218IJWB7Aqj24Ja8+P5crHovSH+PtouO2cDoUSjFdllHyT+uXAW406n9D9zfgIXc6qbbg2JLKsgnB/41MDXyRTIQII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Xw+O7FG3; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Xw+O7FG3" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hXeCQjktyUwgTu4HadNZz99uSY2R38PEOAIiPhcfa9g=; b=Xw+O7FG3kRKKHHxXyr7VPkkf2y cFCq3KYqqXQrziE6sRmP/vygsVDPSqG2iizJbYDDB7v+Ie26k+NvwZSsIXB3BsTEXbr0JqtbTwSS+ hqY+z5U3enykK/KJyHy8YmWq6PC1k7y7eRot3E3gW7aXxpko5NLaMmttTY9lXXewOke/eHI2VTJPr Yc9so2BFMypj5U4k6Fd0zZDZTW9c4pYWn8Hn+02xgEmi8+0pPk7d40IqSvLvW55Cwn4UqxZI6gh+t 7TVBhQ4KkP32qovhVhotAa6iu5NgoxFYisyVAvNdLsKb2CbOEVDeiK7c2jc2PMb7CsB/kCJOYLX2J qpmwYgfQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1w3GWy-00000006ODA-0kn4; Thu, 19 Mar 2026 16:47:32 +0000 Date: Thu, 19 Mar 2026 16:47:31 +0000 From: Matthew Wilcox To: Dev Jain Cc: "Lorenzo Stoakes (Oracle)" , akpm@linux-foundation.org, axelrasmussen@google.com, yuanchu@google.com, david@kernel.org, hughd@google.com, chrisl@kernel.org, kasong@tencent.com, weixugc@google.com, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, riel@surriel.com, harry.yoo@oracle.com, jannh@google.com, pfalcato@suse.de, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, nphamcs@gmail.com, bhe@redhat.com, baohua@kernel.org, youngjun.park@lge.com, ziy@nvidia.com, kas@kernel.org, yuzhao@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com Subject: Re: [PATCH 6/9] mm/swapfile: Make folio_dup_swap batchable Message-ID: References: <20260310073013.4069309-1-dev.jain@arm.com> <20260310073013.4069309-7-dev.jain@arm.com> <18928285-20c6-4cd9-842f-c0aef91421a2@lucifer.local> <26631dbf-1a3e-4d30-9a07-ff64319cbf2f@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26631dbf-1a3e-4d30-9a07-ff64319cbf2f@arm.com> On Wed, Mar 11, 2026 at 11:12:22AM +0530, Dev Jain wrote: > On 10/03/26 2:19 pm, Lorenzo Stoakes (Oracle) wrote: > > On Tue, Mar 10, 2026 at 01:00:10PM +0530, Dev Jain wrote: > >> Teach folio_dup_swap to handle a batch of consecutive pages. Note that > >> folio_dup_swap already can handle a subset of this: nr_pages == 1 and > >> nr_pages == folio_nr_pages(folio). Generalize this to any nr_pages. > >> > >> Currently we have a not-so-nice logic of passing in subpage == NULL if > >> we mean to exercise the logic on the entire folio, and subpage != NULL if > >> we want to exercise the logic on only that subpage. Remove this > >> indirection, and explicitly pass subpage != NULL, and the number of > >> pages required. > > > > You've made the interface more confusing? Now we can update multiple subpages > > but specify only one? :) For the next version, please lose the "subpage" name. It's just a page. folios have pages, not subpages.