From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B2A935DA7C; Fri, 20 Mar 2026 07:27:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773991642; cv=none; b=Wq4aT3rZ/v056WvJkH5amLn63M2kHksXATpqZTWHa1JyJH683G3R2/6ZupL8oL5PuII9dNE7rqb1pfsdHeArgcRdw7hw0y2iopJ4s6IpTVFRLlZJtmx2AQxLt/4VUDxzRa+S79tYNzFvbslC0Oe4/ArvGdBMaIVCuzQycnX7Hug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773991642; c=relaxed/simple; bh=v2ueppRZhgGBBJgxqshadTQ4Qg0qsu+2KG1AFV3N02A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mxFGdgAk65kydQ/B+Hov3YSlQZ+o37z6msQTYMvoDkvf5csSMh6Rwl3gIPhkHnbfgTNcurW5AQaeL+nPkNW0FAz7KnRrYt41v5oWtXzVPCSOjeQC4XypZ/F25qY7S4t+oVOY8MEH6+8O0G5q6CL1k9yQ/wHz2fPZE9qFQLXCyx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EgcsTS+B; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EgcsTS+B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773991641; x=1805527641; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=v2ueppRZhgGBBJgxqshadTQ4Qg0qsu+2KG1AFV3N02A=; b=EgcsTS+Bo6Gwke1ygWoGnyRWUOTMMJAbZr+xNQ7yp2aE6UhsWqO83k5k +hk7JP2LOHRhpY6rxLXypT2Fg/vMrgllNevAjXLHgwBPnwPoGiahl9Rjo FSb7FuoMmq/RZRCMtnAHmPfEs3zCbaj7sSJogchIkyiyxWxwpnaKvkw4u jYfMy5PlKsKsx4Cs3wJQ0gZa7K8g2jzbkZt4KWpQHNNStltk2wjk5XUOv +NkhvlpO6pHrHwvK0HHHrYbv2xWysvuEqZeQZR23ECurUZtCdpwoiDy4t k6ZydkoZVi9WwEXljTnjs9/RmMgn/Anml82w7rL3ob2/+DX8jz+aKJBmt w==; X-CSE-ConnectionGUID: YxfzX8+OS7ystrRObA9Rgw== X-CSE-MsgGUID: tWl9Jyd6RVuGW5UKFaBIbQ== X-IronPort-AV: E=McAfee;i="6800,10657,11734"; a="77680718" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="77680718" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 00:27:20 -0700 X-CSE-ConnectionGUID: vqIb96FlTFeCm0/BF0yiEg== X-CSE-MsgGUID: TSZma3MYQ5aO0fka3UkAtA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="219042268" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.245.40]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 00:27:19 -0700 Date: Fri, 20 Mar 2026 09:27:16 +0200 From: Andy Shevchenko To: Lee Jones Cc: Brian Mak , Herve Codina , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] mfd: core: Preserve OF node when ACPI handle is present Message-ID: References: <20260311190225.22426-1-makb@juniper.net> <20260319181231.GC2902881@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260319181231.GC2902881@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Mar 19, 2026 at 06:12:31PM +0000, Lee Jones wrote: > On Wed, 11 Mar 2026, Brian Mak wrote: ... > > + if (adev) > > + set_primary_fwnode(&pdev->dev, acpi_fwnode_handle(adev)); > > + else > > + set_primary_fwnode(&pdev->dev, acpi_fwnode_handle(parent)); > > Sorry to mess you around again, but how do you feel about: > > set_primary_fwnode(&pdev->dev, acpi_fwnode_handle(adev ?: parent)); If you think it's better, no objections from me. Some maintainers prefer avoiding ternary, and specifically Elvis, some not — hard to remember everybody's preferences :-) -- With Best Regards, Andy Shevchenko