From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D77D831D371 for ; Fri, 3 Apr 2026 13:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775221930; cv=none; b=ltjv/vyZCvQXeM22vpq29J+KiKaKK5hlO3Shy1+VHPq2z2/GjErncVv3cHzye+zJ6qrgnH0SpkkF4NpBae9J2qwn1LqarxqYdmGixTITyO7Q4uAzcMmvrR4ht0CtZHNTNx55h1T5Yx5lzGOdhmJs6KjLT3Xbl1qhdHQQS4vrwW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775221930; c=relaxed/simple; bh=C5HpB7cwBA7h4owSYyTuqyCl3SRJC+tWTRzu6eCAtS0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TkP7oc6XOmE6QTmuLXt2xP8B3JdIQeOxzOKGAx+r7fS43tig+krBoboFHbEt4kpQkDi/WJfODQHuasbcj9rHmzTAfPYffQ5xYxqVCBMQVMaB4Yg2iFapJj8KdazFmm1RzEmepGrxqUnE6BJyi4qc+jm90D1R7W0Xu/QR95KSvHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=XVpfmjrp; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="XVpfmjrp" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7d744d9acbeso703897a34.1 for ; Fri, 03 Apr 2026 06:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1775221928; x=1775826728; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=i4r1mYXYMFAjYkAi3r/abuqzd7ILh9e8TERfZN7EjXg=; b=XVpfmjrpEtPdJ/K4VjYECNInV9BH+QH5tj6abU03qO1vZQ042OOmQgNYhpVyzMzNyf NW7NoYej+cTwyKwsLa0oz3DHyVmjDR0fZ9HLADeC73Hh0q03i0yb3klQY+iKRYaOQFld MN8FsjUP8JGlwkH5QJQZBHv0pgYQv5mqgdqkZm5Iru+JPuYItlxwGLWuq+OAhkw0/7H+ LbpINOHX59oTvm4jYMuq3hr4JCipAqt11aHv5tH0u/n65PiZ3akgxmYGW6WHKRoJKF4K EgGwGD45SXZYO+tBJtRrRMk0FZQPNd50X7Pa8LnO+Ttba16RcE0oEdd89YmiGHN8DYfT vFew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775221928; x=1775826728; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i4r1mYXYMFAjYkAi3r/abuqzd7ILh9e8TERfZN7EjXg=; b=gsB2LY2Nqzg8uv5KNtGf6yA1UswCdkMoyHmvByTd1rGD8CumsSMXSBboEHliP+oT/V l+T/9btBGuwLKDjnL1qOev8mG8jkuUcPCIXeU9XhPPQ+ZrM5gpO7mWwiFJVrs3s0u1i6 85WE7IMn154Vq9laZBjxqvJxYVmXJlSFACEUsQFxVvrjxf2/wXxIRm1PBU5dLI0PQ7Xa Hc4plGyxmxmci30XioUUFJnsiAO/NoIVpVWJP6kq2uslrFQgQAf47skaKaP9oMHo0nxn rbSyYPx900Fq7NxmkiQKmcJd//mqQvAIv/RyrIdKn9yat+iAq8khbSHLU6Px9VM+CtPC bt+g== X-Forwarded-Encrypted: i=1; AJvYcCVk+TOf1ORVD+susgH7wSP5xJVUdLrqyxvzpqCfPxREIljFv75OA0hz0LMUv4EDRYsJCXGBwzi4rSNqxf4=@vger.kernel.org X-Gm-Message-State: AOJu0YwGjypBUCxTNFRAXV9DI68R7HjPG3ycykHQv6ShIpiGBHHxsMAB 349UNHSFYNiNMTEmWYT1LTbal8vX2w3ihxvVAyf5PAmnEqQbSVwVqH3uH3JTF56NeuM= X-Gm-Gg: ATEYQzyK0TryjJg3hEaAn1QiinYnPAMH+pIPLaDJtumpJcr+korOAVVtxP8FpKUSXYQ qAVZvqGN0TQX+FgVkXH0C+EtSWA/XztW/3pKHrpnC7xRwXgcLOXd10+DRbQ57SU4TIpxlar1YNz S1UtffGCmtXtVgN15G8HXP5XNmguDKynsUhH6fKlK4tT/MClL4C0eGIR4Uzl1fqVCcwEbc30xgZ 94Vr3sbr/Djd7RKfvexErq3lTb7Mlhjvua1yiRZWRCoBZkXKC7DX8Z5WrEPfM2dpIMF5FMVsY6v TLUw3OvAJhmX3yZ18oxpASh1U1M0VZW7hhNt6VUTNORApzvoz8GuAE8abB9cBHNzahwCF8y9TnW B6F0jdNwydbt8qouMwqYzOj/ud+KKdxJXUSNaEM149A3WzQj+Pf/jHnOT2+dEmu5Lc1PcHXO29j 2CcbI5zEupH+sSRWFWZAZ3KTp/QEfSi19LY6E366vIdJHafMkMYbLJzUY5rAz2GxywxXCsHmB2H fExRlXWieXKHQk= X-Received: by 2002:a05:6830:630b:b0:7d9:ad99:9ff0 with SMTP id 46e09a7af769-7dbb75c800dmr2010902a34.30.1775221927647; Fri, 03 Apr 2026 06:12:07 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:67f7:eb47:a398:6ff2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dba6f47012sm4298577a34.0.2026.04.03.06.12.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 06:12:07 -0700 (PDT) Date: Fri, 3 Apr 2026 08:12:03 -0500 From: Corey Minyard To: Jian Zhang Cc: Quan Nguyen , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] ipmi: ssif_bmc: cancel response timer on remove Message-ID: Reply-To: corey@minyard.net References: <20260403090603.3988423-1-zhangjian.3032@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260403090603.3988423-1-zhangjian.3032@bytedance.com> On Fri, Apr 03, 2026 at 05:05:58PM +0800, Jian Zhang wrote: > The response timer can stay armed across device teardown. If it fires after > remove, the callback dereferences the SSIF context and the i2c client after > teardown has started. > > Cancel the timer in remove so the callback cannot run after the device is > unregistered. Thanks for the updates on this. I have the new version in my tree. I have one question on the kunit patch, I'll ask it there. -corey > > Signed-off-by: Jian Zhang > --- > v2: use timer_delete_sync() to cancel the timer > > drivers/char/ipmi/ssif_bmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c > index 7a52e3ea49ed..dc1d5bb4a460 100644 > --- a/drivers/char/ipmi/ssif_bmc.c > +++ b/drivers/char/ipmi/ssif_bmc.c > @@ -843,6 +843,7 @@ static void ssif_bmc_remove(struct i2c_client *client) > { > struct ssif_bmc_ctx *ssif_bmc = i2c_get_clientdata(client); > > + timer_delete_sync(&ssif_bmc->response_timer); > i2c_slave_unregister(client); > misc_deregister(&ssif_bmc->miscdev); > } > -- > 2.20.1