From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55923396571 for ; Wed, 1 Apr 2026 15:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775058897; cv=none; b=nZgn+lomk9OFMVie3ddHlnsvzN7VIEk3AIrlbzoceHXi9kZKEFuFEUDWMIyt8oAUKsN9Fk97Hi7M0jlElPuGrxO/zd6CroBNUtBngzA5cyfy7uDaaHKjo/W9vaDJwHy5cR1oEmeyWIt5u4vp7CaM7tih+F9e+fIEU2RMQhX3vtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775058897; c=relaxed/simple; bh=+qbkO2vGbvThK38+UmgQuZI4Qx1NmsWO4jJxe2qo63Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iSrcXC8n/xXckNY16Fajaue8f28RmyAktE1BnABO8YlGrKdfNMeZnlRsh7McV4Q50vkJOSqhZjzuF/W3RF6cKojU+T5RHXLefwgjHXHDSqaPRADZ3VCQYzSqxnCUEx0EQfqFsRgubh0byIFgbPMDIXGhHPx66nW+xvgevjCLNsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OuuXGirx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a47Hpemp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OuuXGirx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a47Hpemp" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 631EPu6d1881835 for ; Wed, 1 Apr 2026 15:54:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=zFK+mlQujJNjbomDnjjDvyHU Xm93hR7YZ2pRnFwT7mo=; b=OuuXGirx76+DLKs8D3co8hfTs8lZsoHoBcGmWewF KYEH/KyTXvc5JaGHRqQHQDvde1/41yTFPkehGov046JYtSFPWQE2Fqr1MG3C3nYT aZXsg5L4TS30gImaoeY7rpG4F/0eQxOmgcukOjgg1YrA4ovhTo2tePixd7/rq75u 1jXvRjA9lG9CCQ/dJI3zklmg445aB+GCCg+XpMTLM8AF6TcPCUngF/CzotG1dx25 PpTypfkYUytU9SxVB+jDc/lynX5nG/hSJsI4uGz2qa2hFriO5IQobShO8gWE7kJ+ gpT9qWK3Lgy6dYpwq+Lvy2oavWsfcHYjYYre2kWxFIGkaA== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d954c8gk2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 15:54:55 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2bdf6fe90a9so7026747eec.1 for ; Wed, 01 Apr 2026 08:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775058895; x=1775663695; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zFK+mlQujJNjbomDnjjDvyHUXm93hR7YZ2pRnFwT7mo=; b=a47HpemplwS3r6OUDeebyPe+Tj1jtWqNONw9wCJEV8lk27gBLApUeiVSgCKVn1NSQ5 Wsy62sBT4In3qIyHJdsSWcqh/3n8QUx+Lp2gjShAKtjhu/zPTrld3f2bbfXYOToDUdRf p3yaxO+7s4r75MxpcPujRcp/rtZz36+i3F+MXDX36K0ANcF6uXLAbH9gi2pETiR7LrCM GZ4J0Gv9HefEA5Wn32EZC6yiEwOavWUhzggO1BtcPfamnAUJJz8FEJk5zmNxiQ/WYxXs IwlgOQhSiz6s9Ox/VKab2Ot574KyncPtxYg1tvYD/spK9PyYqbvXNZu3TJP98dyh9aHW BcpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775058895; x=1775663695; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zFK+mlQujJNjbomDnjjDvyHUXm93hR7YZ2pRnFwT7mo=; b=pTXWRKadaIpylMZ9y/lLo8FUjEWobS6ntpi2ymHVVETa2NxI0HpwB8+FAI8ihTAoxX 97yoZdo+9SYK1Jdp9nMH9gKfvKQl1HvskQjIb4goUwpvqz8zJHLcDyf4cZ23gSvz/wpE XM+f/gupS0+NW2jviGqRCngKRdJTssCoOTojxjAo3YNqYWjxJ1wmy9+SAld7jymaSDiC mwcQBa5zCP3S8C3jdyfKMumcMCuD9HZt13kryfHP4WcOZDHIFGa2BxCnkWW7vpEFdhJc ZQmF68SvPlr8i7r4g6g1Ff04jQsy/ObmjJKG0VMWI7p/fGeTz3HRAeSYLEgiOiYQulzQ FQ4Q== X-Forwarded-Encrypted: i=1; AJvYcCWIT4omoSnuS4hfnPQQc8qWrmwq06RYHS321T8GCPMV6ddBOVZW46iXgGJzAYJ/OHqFh4KOMRas7coiZGo=@vger.kernel.org X-Gm-Message-State: AOJu0YzcIitXFth9eWg8/8eEs8EbcsTS4+VCctZYeeVuFm50X1Td73/V UbhjTTe/PUXjDCW3mH7YqEiMAUdYBeWHGIk106iRfOZSTEj3N7WXX4tPoFdPPfYU+IRXHQyapsE LSIOY4ZbdFbd7Jxnu0agfwT7gidRpFqAMr7LOyokVo35DoYCKlr8Sb7ekswYgzqYoWfo= X-Gm-Gg: ATEYQzydwJtr9ZO24aDTt0OnEUEFoigSEG2/pmOGSkHJ+6ehxuoigEn5DfvU3YvPN2/ NnYpQZMmv22jAt0a33SIllpPSLihweACN+3FmS+BFMnliczyUdRDC0fiu/45sTYInYOofLapAfp 9y5YkEpA3qXD4A36BhyO4vB9GTaSQAz5A/A3UgXxtseJwfJVoM7yPhSZVEoUHVX1oXJSK7O0vzJ utq/Eon5OBaLGuBfeGcYMhy3Q8ZYnlV7nih5AP+D+h7C8CPxmz8HR4CsFy+dzOfNdZWB5+rN4XS dTKPt24OPxfZa3iaZvcwAn1j96GWVgMiKHI9O67BGdKqmGCeFS75XhIeZiDMd7i6uk3dWOFuJmG RBm/Y+i3ER2Tjhuf5NyAzst8N5wTQsyMcbMPO1j/cJkIi3o7tAgMqaeoVZ/5cEzzagFZ74+aylt Y= X-Received: by 2002:a05:7300:6da8:b0:2c7:2c0b:f334 with SMTP id 5a478bee46e88-2c9325b04a8mr1993416eec.18.1775058894777; Wed, 01 Apr 2026 08:54:54 -0700 (PDT) X-Received: by 2002:a05:7300:6da8:b0:2c7:2c0b:f334 with SMTP id 5a478bee46e88-2c9325b04a8mr1993370eec.18.1775058893825; Wed, 01 Apr 2026 08:54:53 -0700 (PDT) Received: from hu-mdtipton-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca7caeb83dsm103983eec.22.2026.04.01.08.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 08:54:53 -0700 (PDT) Date: Wed, 1 Apr 2026 08:54:51 -0700 From: Mike Tipton To: Bjorn Andersson Cc: Vivek Aknurwar , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] clk: qcom: Add support for global clock controller on Hawi Message-ID: References: <20260330-clk-hawi-v1-0-c2a663e1d35b@oss.qualcomm.com> <20260330-clk-hawi-v1-7-c2a663e1d35b@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=WMlyn3sR c=1 sm=1 tr=0 ts=69cd3fcf cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=luiUJp0ABMwvOzxM0bgA:9 a=CjuIK1q_8ugA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-GUID: JogWVDnvz-tawDgJppyWo-yObBRQNm7g X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDE0OCBTYWx0ZWRfXx6qJenf175Tw QeErVlD1aZJd02YiRPYMIazXcZBbNVVDgYeGyFIuuUZJ4e7GFPxxbsyOabAC2NHf/tODoT4uXyg 55P017TXY8k4COobc2F/uFyziXlnhywflXJHsexssURyrtP6YmnZq+SJSgtL6NLOkAGRgUFbNpP MjWcxDK0+eMl7qhZJy0eJUYiGwhvmiVSlSV/VkEVHTZkblSqzDB6pTblI6kz1nENtI1ouoK2Z61 h2nI7whyY+en1TQU0CnU9vr9zsTbOk8AtUxtr60GNWU6tMcJ6U7blh32z4PWL+CRiiS0d4lHJXi /fLNZDi1/eUL9h4QdC7h6GJmwWFcc0yLQjWlLsYiZoVfHFJQESyJxuk80qEa3Ygf67FBALCg05o K2+d2YSdDGX9Z9gLmOZ+YHLBszyeqT2G7MVVRT93laLmiMcfZ3Yzvutrs15u3USxZYOAh6Loxb0 lgl+HTscu8LgTtPOxug== X-Proofpoint-ORIG-GUID: JogWVDnvz-tawDgJppyWo-yObBRQNm7g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_04,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010148 On Tue, Mar 31, 2026 at 04:11:22PM -0500, Bjorn Andersson wrote: > On Mon, Mar 30, 2026 at 05:35:02PM -0700, Vivek Aknurwar wrote: > > +++ b/drivers/clk/qcom/gcc-hawi.c > [..] > > +static const struct qcom_cc_desc gcc_hawi_desc = { > > + .config = &gcc_hawi_regmap_config, > > + .clks = gcc_hawi_clocks, > > + .num_clks = ARRAY_SIZE(gcc_hawi_clocks), > > + .resets = gcc_hawi_resets, > > + .num_resets = ARRAY_SIZE(gcc_hawi_resets), > > + .gdscs = gcc_hawi_gdscs, > > + .num_gdscs = ARRAY_SIZE(gcc_hawi_gdscs), > > + .driver_data = &gcc_hawi_driver_data, > > Sorry for not spotting this earlier, but don't we need a ".use_rpm = > true" here? > > In line with > https://lore.kernel.org/all/20260309-glymur-fix-gcc-cx-scaling-v2-2-d7a58a0a9ecb@oss.qualcomm.com/ Yeah, we should. Same rationale, which technically applies to many other GCC instances that aren't setting this today. Mike > > Regards, > Bjorn > > > +}; > > +