From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai1@huaweicloud.com>,
mhartmay@linux.ibm.com, bblock@linux.ibm.com, bvanassche@acm.org,
hch@lst.de
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"yukuai (C)" <yukuai3@huawei.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi/sg: fix checking return value of blk_get_queue()
Date: Wed, 19 Jul 2023 10:34:11 -0600 [thread overview]
Message-ID: <ac099071-a16d-46a4-a1b1-2cc786a0a337@kernel.dk> (raw)
In-Reply-To: <d112d30e-d144-4c76-db98-5de4767f5945@huaweicloud.com>
On 7/18/23 7:09?PM, Yu Kuai wrote:
> Hi, Jens
>
> ? 2023/07/05 10:40, Yu Kuai ??:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> Commit fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
>> make a mess how blk_get_queue() is called, blk_get_queue() returns true
>> on success while the caller expects it returns 0 on success.
>>
>> Fix this problem and also add a corresponding error message on failure.
>>
>> Fixes: fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
>> Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
>> Closes: https://lore.kernel.org/all/87lefv622n.fsf@linux.ibm.com/
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>
> Sorry about the trouble... Can you apply this patch? I notice that the
> original patch is applied to stable.
I can, I had assumed that Martin would pick it up on the SCSI side?
--
Jens Axboe
next prev parent reply other threads:[~2023-07-19 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 2:40 Yu Kuai
2023-07-05 6:13 ` Marc Hartmayer
2023-07-06 12:52 ` Christoph Hellwig
2023-07-07 7:07 ` Marc Hartmayer
2023-07-13 12:21 ` Shinichiro Kawasaki
2023-07-19 1:09 ` Yu Kuai
2023-07-19 16:34 ` Jens Axboe [this message]
2023-07-20 3:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac099071-a16d-46a4-a1b1-2cc786a0a337@kernel.dk \
--to=axboe@kernel.dk \
--cc=bblock@linux.ibm.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mhartmay@linux.ibm.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®