Re: [PATCH v1 1/2] cpufreq: intel_pstate: Use CPPC to get scaling factors

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: Russell Haley <yumpusamongus@gmail.com>
To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] cpufreq: intel_pstate: Use CPPC to get scaling factors
Date: Thu, 1 May 2025 16:33:24 -0500	[thread overview]
Message-ID: <ac0e5571-15b2-4b7a-adc9-84bbca96cbf3@gmail.com> (raw)
In-Reply-To: <b1bc2569b0da4c6749e896eee0fdf0af97c18fea.camel@linux.intel.com>


On 5/1/25 12:13 PM, srinivas pandruvada wrote:
> Hi Russell,
> 
> 
> On Wed, 2025-04-30 at 20:28 -0500, Russell Haley wrote:
>>
>> On 12/5/24 5:39 AM, Rafael J. Wysocki wrote:
>>
>>> +	 * Compute the perf-to-frequency scaling factor for the
>>> given CPU if
>>> +	 * possible, unless it would be 0.
>>> +	 */
>>> +	if (!cppc_get_perf_caps(cpu, &cppc_perf) &&
>>> +	    cppc_perf.nominal_perf && cppc_perf.nominal_freq)
>>> +		return div_u64(cppc_perf.nominal_freq *
>>> KHZ_PER_MHZ,
>>> +			       cppc_perf.nominal_perf);
>>
> Can you dump the output of
> 
>  grep -r . /sys/devices/system/cpu/cpu*/acpi_cppc/
> 
> Thanks,
> Srinivas

Running microcode 0x117, CSME firmware 19.0.5.1948, shipped in BIOS 3.04
on an ASRock Z890 Pro-A Wifi motherboard:

> /sys/devices/system/cpu/cpu0/acpi_cppc/feedback_ctrs:ref:127316207577 del:142876300546
> /sys/devices/system/cpu/cpu0/acpi_cppc/lowest_nonlinear_perf:36
> /sys/devices/system/cpu/cpu0/acpi_cppc/highest_perf:87
> /sys/devices/system/cpu/cpu0/acpi_cppc/nominal_freq:3900
> /sys/devices/system/cpu/cpu0/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu0/acpi_cppc/guaranteed_perf:63
> /sys/devices/system/cpu/cpu0/acpi_cppc/nominal_perf:62
> /sys/devices/system/cpu/cpu0/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu0/acpi_cppc/reference_perf:62
> /sys/devices/system/cpu/cpu0/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu1/acpi_cppc/feedback_ctrs:ref:30806048910 del:37298826546
> /sys/devices/system/cpu/cpu1/acpi_cppc/lowest_nonlinear_perf:36
> /sys/devices/system/cpu/cpu1/acpi_cppc/highest_perf:88
> /sys/devices/system/cpu/cpu1/acpi_cppc/nominal_freq:3900
> /sys/devices/system/cpu/cpu1/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu1/acpi_cppc/guaranteed_perf:63
> /sys/devices/system/cpu/cpu1/acpi_cppc/nominal_perf:62
> /sys/devices/system/cpu/cpu1/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu1/acpi_cppc/reference_perf:62
> /sys/devices/system/cpu/cpu1/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu2/acpi_cppc/feedback_ctrs:ref:30104856912 del:37149315858
> /sys/devices/system/cpu/cpu2/acpi_cppc/lowest_nonlinear_perf:36
> /sys/devices/system/cpu/cpu2/acpi_cppc/highest_perf:87
> /sys/devices/system/cpu/cpu2/acpi_cppc/nominal_freq:3900
> /sys/devices/system/cpu/cpu2/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu2/acpi_cppc/guaranteed_perf:63
> /sys/devices/system/cpu/cpu2/acpi_cppc/nominal_perf:62
> /sys/devices/system/cpu/cpu2/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu2/acpi_cppc/reference_perf:62
> /sys/devices/system/cpu/cpu2/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu3/acpi_cppc/feedback_ctrs:ref:28864792476 del:36395338959
> /sys/devices/system/cpu/cpu3/acpi_cppc/lowest_nonlinear_perf:36
> /sys/devices/system/cpu/cpu3/acpi_cppc/highest_perf:87
> /sys/devices/system/cpu/cpu3/acpi_cppc/nominal_freq:3900
> /sys/devices/system/cpu/cpu3/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu3/acpi_cppc/guaranteed_perf:63
> /sys/devices/system/cpu/cpu3/acpi_cppc/nominal_perf:62
> /sys/devices/system/cpu/cpu3/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu3/acpi_cppc/reference_perf:62
> /sys/devices/system/cpu/cpu3/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu4/acpi_cppc/feedback_ctrs:ref:29591299374 del:35708084379
> /sys/devices/system/cpu/cpu4/acpi_cppc/lowest_nonlinear_perf:36
> /sys/devices/system/cpu/cpu4/acpi_cppc/highest_perf:87
> /sys/devices/system/cpu/cpu4/acpi_cppc/nominal_freq:3900
> /sys/devices/system/cpu/cpu4/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu4/acpi_cppc/guaranteed_perf:63
> /sys/devices/system/cpu/cpu4/acpi_cppc/nominal_perf:62
> /sys/devices/system/cpu/cpu4/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu4/acpi_cppc/reference_perf:62
> /sys/devices/system/cpu/cpu4/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu5/acpi_cppc/feedback_ctrs:ref:27347351382 del:35000915045
> /sys/devices/system/cpu/cpu5/acpi_cppc/lowest_nonlinear_perf:36
> /sys/devices/system/cpu/cpu5/acpi_cppc/highest_perf:87
> /sys/devices/system/cpu/cpu5/acpi_cppc/nominal_freq:3900
> /sys/devices/system/cpu/cpu5/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu5/acpi_cppc/guaranteed_perf:63
> /sys/devices/system/cpu/cpu5/acpi_cppc/nominal_perf:62
> /sys/devices/system/cpu/cpu5/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu5/acpi_cppc/reference_perf:62
> /sys/devices/system/cpu/cpu5/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu6/acpi_cppc/feedback_ctrs:ref:28117737882 del:34854014824
> /sys/devices/system/cpu/cpu6/acpi_cppc/lowest_nonlinear_perf:36
> /sys/devices/system/cpu/cpu6/acpi_cppc/highest_perf:87
> /sys/devices/system/cpu/cpu6/acpi_cppc/nominal_freq:3900
> /sys/devices/system/cpu/cpu6/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu6/acpi_cppc/guaranteed_perf:63
> /sys/devices/system/cpu/cpu6/acpi_cppc/nominal_perf:62
> /sys/devices/system/cpu/cpu6/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu6/acpi_cppc/reference_perf:62
> /sys/devices/system/cpu/cpu6/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu7/acpi_cppc/feedback_ctrs:ref:29586359166 del:36871078184
> /sys/devices/system/cpu/cpu7/acpi_cppc/lowest_nonlinear_perf:36
> /sys/devices/system/cpu/cpu7/acpi_cppc/highest_perf:88
> /sys/devices/system/cpu/cpu7/acpi_cppc/nominal_freq:3900
> /sys/devices/system/cpu/cpu7/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu7/acpi_cppc/guaranteed_perf:63
> /sys/devices/system/cpu/cpu7/acpi_cppc/nominal_perf:62
> /sys/devices/system/cpu/cpu7/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu7/acpi_cppc/reference_perf:62
> /sys/devices/system/cpu/cpu7/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu8/acpi_cppc/feedback_ctrs:ref:28808115336 del:32798153181
> /sys/devices/system/cpu/cpu8/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu8/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu8/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu8/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu8/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu8/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu8/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu8/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu8/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu9/acpi_cppc/feedback_ctrs:ref:28808446524 del:32557156736
> /sys/devices/system/cpu/cpu9/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu9/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu9/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu9/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu9/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu9/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu9/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu9/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu9/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu10/acpi_cppc/feedback_ctrs:ref:28466858472 del:32126528930
> /sys/devices/system/cpu/cpu10/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu10/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu10/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu10/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu10/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu10/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu10/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu10/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu10/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu11/acpi_cppc/feedback_ctrs:ref:30158667240 del:34095663687
> /sys/devices/system/cpu/cpu11/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu11/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu11/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu11/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu11/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu11/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu11/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu11/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu11/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu12/acpi_cppc/feedback_ctrs:ref:29056752036 del:33047611525
> /sys/devices/system/cpu/cpu12/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu12/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu12/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu12/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu12/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu12/acpi_cppc/nominal_perf:33
> /sys/devices/system/cpu/cpu12/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu12/acpi_cppc/reference_perf:39
> /sys/devices/system/cpu/cpu12/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu13/acpi_cppc/feedback_ctrs:ref:28868999796 del:32974873909
> /sys/devices/system/cpu/cpu13/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu13/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu13/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu13/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu13/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu13/acpi_cppc/nominal_perf:33
> /sys/devices/system/cpu/cpu13/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu13/acpi_cppc/reference_perf:39
> /sys/devices/system/cpu/cpu13/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu14/acpi_cppc/feedback_ctrs:ref:32754342192 del:33580705618
> /sys/devices/system/cpu/cpu14/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu14/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu14/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu14/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu14/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu14/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu14/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu14/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu14/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu15/acpi_cppc/feedback_ctrs:ref:30756411036 del:33232643243
> /sys/devices/system/cpu/cpu15/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu15/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu15/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu15/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu15/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu15/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu15/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu15/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu15/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu16/acpi_cppc/feedback_ctrs:ref:29430330384 del:32848376143
> /sys/devices/system/cpu/cpu16/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu16/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu16/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu16/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu16/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu16/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu16/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu16/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu16/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu17/acpi_cppc/feedback_ctrs:ref:29997814080 del:33374419073
> /sys/devices/system/cpu/cpu17/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu17/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu17/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu17/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu17/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu17/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu17/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu17/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu17/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu18/acpi_cppc/feedback_ctrs:ref:28312400376 del:32285787922
> /sys/devices/system/cpu/cpu18/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu18/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu18/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu18/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu18/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu18/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu18/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu18/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu18/acpi_cppc/wraparound_time:18446744073709551615
> /sys/devices/system/cpu/cpu19/acpi_cppc/feedback_ctrs:ref:28316604732 del:32229146887
> /sys/devices/system/cpu/cpu19/acpi_cppc/lowest_nonlinear_perf:21
> /sys/devices/system/cpu/cpu19/acpi_cppc/highest_perf:65
> /sys/devices/system/cpu/cpu19/acpi_cppc/nominal_freq:3300
> /sys/devices/system/cpu/cpu19/acpi_cppc/lowest_freq:0
> /sys/devices/system/cpu/cpu19/acpi_cppc/guaranteed_perf:47
> /sys/devices/system/cpu/cpu19/acpi_cppc/nominal_perf:46
> /sys/devices/system/cpu/cpu19/acpi_cppc/lowest_perf:1
> /sys/devices/system/cpu/cpu19/acpi_cppc/reference_perf:54
> /sys/devices/system/cpu/cpu19/acpi_cppc/wraparound_time:18446744073709551615

Thanks,

Russell

next prev parent reply	other threads:[~2025-05-01 21:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 11:30 [PATCH v1 0/2] intel_pstate: Use information from CPPC to compute hybrid " Rafael J. Wysocki
2024-12-05 11:39 ` [PATCH v1 1/2] cpufreq: intel_pstate: Use CPPC to get " Rafael J. Wysocki
2025-05-01  1:28   ` Russell Haley
2025-05-01 17:13     ` srinivas pandruvada
2025-05-01 21:33       ` Russell Haley [this message]
2025-05-01 23:12         ` srinivas pandruvada
2024-12-05 11:40 ` [PATCH v1 2/2] cpufreq: intel_pstate: Drop Arrow Lake from "scaling factor" list Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac0e5571-15b2-4b7a-adc9-84bbca96cbf3@gmail.com \
    --to=yumpusamongus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®