From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C385A1F131A for ; Fri, 13 Mar 2026 10:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773399012; cv=none; b=oHMZdXsR6MKN863khT5Stsmv1dGC7bVnHAI5K5N+MmFMbcVmJFyRqgPu/9WLpQd6zMI1WTym5oZXI4QsYjtSPk+C2v4lbdYMv6Qb3XxshZcf4E538NOqseTNbuSXOkQj8KlqmnGdhb0vj5f3Rbgvkjx5Jou6XfpXS23lSPaaiLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773399012; c=relaxed/simple; bh=aps8mFovGZlF1yvFqIvQlDxUebp7B5Obn1q2i7KjfFk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kn/6iFijj+j/5fPW/lPd6KZR4upczDQlMMjHn7BHHOAYwL4jzEaFHyvpwRtYqBWhRBY8Xg8B5cnXPBw/V0Ps4fJDvtMCcSEjRhtyGyjLWfmTXn68ngZ1OrveRINFoKgz+K0l4Ziqg1xqD8/1J+NIbjzlln4UL5M547fYYll9Kis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eedGq58q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AjVGYn6O; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eedGq58q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AjVGYn6O" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5tevx3342538 for ; Fri, 13 Mar 2026 10:50:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RBkgUQGXepS8VOkWnzpVhui4Op9wXcFLhgxSgyRZRj4=; b=eedGq58qab40pewS Vbu5u08TeDatsqm61BVjokT+CTJjW+LMc/WuJL7cGFQbW8+ZGRLfgUov9SX6Njqa X20xEW17MnfOiUHvGU0Km2VRJ4wNNf/75NihYX39Hk0BEOQnw3w5bJz/cFALFJKu M64zUBuyoeeAQOFMXmZCvAkHbw/vJ8pjHnb0CODY5dihZUmO8LnSj/EoKanngZ+T uRyVysEvXpeBPB2p0vX8Rr8BEl3fHAh+q3RmAezfqpbPJb8Zq6H5Hmx4vq7gNLmd i3SXpAt5yaNWWuj+09dWuFmcrEsx7p+HCAI0eWDb3ZxX/RAOBk4RBCJebC4HeBMt KOvQmA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w4fd0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 10:50:08 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd90958f24so92753585a.1 for ; Fri, 13 Mar 2026 03:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773399008; x=1774003808; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RBkgUQGXepS8VOkWnzpVhui4Op9wXcFLhgxSgyRZRj4=; b=AjVGYn6O2Z78blGxSBE+tdX4U3lqMfxYYSmm3FieWsZUz3SlGWpOrJKFsKsZ4XYi0p mXEZISyUhIytnLH0dgVV66bPtdiXkuD2r2blpCrg+zMwMp3Wwi3/OFK/X37Zka386NSp qVbiQHNVcCgmzBZBYp4HBmebyN/Dc+45dU19E21EA1XWvPDD+5wneEmUwuQzqIlYGyfR t8Ud/AtI1EMN+xwESRlP9VBuuMfzhNlgSIHp2JN+0g/ULdz094tTqAwbuLYR0vgPjtp8 BLgpI9GZtuoohUI+VQJfDc64GZ86RNMsMhnwDDAZV9mnujfPV44MsVQ0FBA/UGsJIH1B j0Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773399008; x=1774003808; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RBkgUQGXepS8VOkWnzpVhui4Op9wXcFLhgxSgyRZRj4=; b=dYC5yrsZN9suH72KEPxAo5gqTJP5NJOHQ7gNYWQyqJAGFX/QV1Y5TOHiX4z5IKaLcz 3YihBdUP7JlO8WrBbZsRiS+GAUiFhFrId2m+dcO+haMrWVY9IIFpiKhvddo7Ti20nySp Kyhv1xoPafRgsKfr6j+QeEQLLhA8ogvdaAHWKDqHUIsitgkQHjD8HvwJ7wWERq+pL96d 9jWa8H3zaF+TRG5vA5dCfeT9ltIvIcENNe91pbEMFGf8BDAM3jr8U8R9LOmeb95uP/go bdzdf08jqr1OJBay+n9YJ/PTD57rZvi47ipG++yJgc+VHHUCbAhQz0frHPyRhj5uDr6u AdIw== X-Forwarded-Encrypted: i=1; AJvYcCWeMywf2XsToJT7o9F+LnNw9PHOE/Nf24zKUtz6lzclqLS659Sj/q1f0xk5Rx6ThU6JLdgx4YDOIoB2cLY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf/lBZFxwybxq4qUh/yJuh4XX5Hk7fZL282d+c/bQpUO1W8r4H 3972cMuLTcse4zXzz6UNQ9JImno1zbUmt9vsAK46T8HfRIV0AQB7b4ywYU6tdRz7EV7jLZUr90G KU/DurjMQJ10a2BtFrvMvZ0IIvgsu5Bt0GGo2hFKY+VIbv4GJxhvW1kWZqQ/0bu/fePg= X-Gm-Gg: ATEYQzyUHZu1cFD3tH2japQmSQEL8Fj0IhlP1MTTe5hvsKQABrG6sLHyZDWfReyRoJB 4Gw2sc/zSrBtMz7PoFmM1I1Lp5WEAioTi9eU5rG1r7yb/WNw625923thZKd3R1cxoqfk3vAUibP c5V/zeRzIiIqYYnXHbBKoT5YoklX5ovR16Am5M0PwrChLem20+31pkFIAjJw9HnPPnrRgw4YVa9 7EyRUpmZYp5n4VgHG/fmoc8MOHIJ4wcFvE+h4LmWuvq5IExEVgjPSAEWujG3waKN8PHksSr2oCs fAXBz3Tj1rVwBNzNUGjd0Ez9o2Ty0hAuyYyvzN5Rn0ovflzr1g3Hi1i8Xg2xdlBDRaXJXZD/lI6 Kbzo3gqy/eU4vSXz1vypZaj5Nv018c+PXrfYlbrDq+IIhJrDdAp/UbqnwE1zVpsovf4xcY3+Rnp X96RY= X-Received: by 2002:a05:620a:290e:b0:8cd:8736:9fc3 with SMTP id af79cd13be357-8cdb5b8a614mr303373185a.7.1773399008218; Fri, 13 Mar 2026 03:50:08 -0700 (PDT) X-Received: by 2002:a05:620a:290e:b0:8cd:8736:9fc3 with SMTP id af79cd13be357-8cdb5b8a614mr303370385a.7.1773399007766; Fri, 13 Mar 2026 03:50:07 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6634fbb94afsm1204251a12.4.2026.03.13.03.50.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 03:50:05 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 11:50:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/11] clk: qcom: camcc-sc8180x: Remove wait_val for Titan GDSC To: Val Packett , Bjorn Andersson , Michael Turquette , Stephen Boyd , Vladimir Zapolskiy , Satya Priya Kakitapalli , Dmitry Baryshkov Cc: Konrad Dybcio , Johan Hovold , Manivannan Sadhasivam , Dmitry Baryshkov , Maximilian Luz , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260312112321.370983-1-val@packett.cool> <20260312112321.370983-10-val@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260312112321.370983-10-val@packett.cool> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: PAc4eA98VK4u_02nuOiinDIrzXQavr-A X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b3ebe0 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=QN4KUsGz3BfPxM-IDMAA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA4NCBTYWx0ZWRfX/w84aDK60N37 F0lzL1z252QaW9BeEHzH2e4375iJwnfXejBD0N+iG0vnY5t1Q/JW1Q4QZUZ0b24tvw6HZGCXphL AnPChOFi399UowI1KQqt7yxq0icYnELjyILZkPunDW0kbhF0hYxt3u3Gkf9gVRiWbdUR7JK0HKa qFGH57D63+8Z2t26i868hbi1lZORU1dN6YrYoP8J+flPmjQrtqTXdT7cLa+LYyY3hwkeDYKdERt MJciDW9Gbq4j7737k6iJHE6gUZGQgmbQO7xje6jo63qsUUlsw5G6ie/dMULlq47Kw1sEJ6YZprS 3trd0SUaqJg2zHpuSFreQybvofhFxYfB2pwkmlofXq6SICB6jaDTBidsbuFirAoWZMyDs3tN0fn Wrx46VG4TavcCSuYoT+thCX+LhZD36IBu/xJRmvpyymEK+xvuxsDmujPcQkCCXEGavWJ5pakBJy 5SSGf7c01iGSfOdnZNw== X-Proofpoint-ORIG-GUID: PAc4eA98VK4u_02nuOiinDIrzXQavr-A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130084 On 3/12/26 12:12 PM, Val Packett wrote: > These values seem to have been copied from newer SoCs, but e.g. SC7180 > and SDM845 do not use them. They seem to play a role in causing the > "titan_top_gdsc stuck at off" errors on boot on the Surface Pro X. > > Remove to fix. > > Fixes: 691f3413baa4 ("clk: qcom: camcc-sc8180x: Add SC8180X camera clock controller driver") > Signed-off-by: Val Packett > --- > drivers/clk/qcom/camcc-sc8180x.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/clk/qcom/camcc-sc8180x.c b/drivers/clk/qcom/camcc-sc8180x.c > index 388fedf1dc81..cd4c40a81c28 100644 > --- a/drivers/clk/qcom/camcc-sc8180x.c > +++ b/drivers/clk/qcom/camcc-sc8180x.c > @@ -2538,9 +2538,6 @@ static struct clk_branch cam_cc_mclk7_clk = { > > static struct gdsc titan_top_gdsc = { > .gdscr = 0xc1bc, > - .en_rest_wait_val = 0x2, > - .en_few_wait_val = 0x2, > - .clk_dis_wait_val = 0xf, Those are the 'correct' / on-reset values which if absent, are going to be overriden by the driver, with values destined for MSM8974, so please drop this one Konrad