From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D02A2FF151 for ; Mon, 26 Jan 2026 14:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769439268; cv=none; b=k7qjCaEkLcS/msPoeco/en2XMwtC4OBRtYp0DY+hPM4YJGHxGFgFFcl83mK5DWJot4tKgYmVP58lx6hM0j0BhDLztztmnjvVHO7UO1w8F7cii3q/U6CYU+ohbDTlOpiJ+DYV2cMGkUPT0kMjctJBF1SQUkDRlrf7+kvilBbqwOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769439268; c=relaxed/simple; bh=Uxr1fUcxgHYez2kADgJu2kX9ia0MIDAG/hm5ySSvkVc=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:In-Reply-To: Content-Type:References; b=ZW/qvkyIobYGFqVZ/XuPetyyphLins1f9lWFA4t+YjIA2jyw4TvB1d1O1wx8IKzRhmRHhqIgmiefR2S+LHpcWA3Egh+SZ2lIkOtJGos9vNid8upLd5q/1g2xZG1Mzh13S++i9aS15jtx8FD8IFC8SkLhjq0UmtaQUdJO5yjFB3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=latfrhts; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="latfrhts" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260126145423euoutp01b14e782fda5eee1e9f2621b6512ec7dd~OT6KoP7y81630616306euoutp01Q for ; Mon, 26 Jan 2026 14:54:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260126145423euoutp01b14e782fda5eee1e9f2621b6512ec7dd~OT6KoP7y81630616306euoutp01Q DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1769439263; bh=FJ6dndNVnr43t5sh/dPsANRRiyWCeTFjxztR0Zx4Cp0=; h=Date:Subject:From:To:Cc:In-Reply-To:References:From; b=latfrhtsmG8RtRz6JSigyMYSADZ/lFu31gIaRZXGoM25xpFM4HGx1IOuvYmKN1tVi 4sUcfPGg12Uh96uCRj+XIOl41w0DhSrap4g8zmAdpw5cd90hIFkCoUbnyZzvvTOpe9 xdDk4RRnYRMWithrPUfQAQa3VFcYmsfAwG6Bib6g= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20260126145422eucas1p243889bf4ac456996ce7ed05111331d67~OT6KA7zOj1143511435eucas1p2B; Mon, 26 Jan 2026 14:54:22 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260126145422eusmtip2d1a656619f59b16d7baae0d47ee79283~OT6JQxXP51987919879eusmtip2T; Mon, 26 Jan 2026 14:54:22 +0000 (GMT) Message-ID: Date: Mon, 26 Jan 2026 15:54:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH 1/3] drm/bridge: samsung-dsim: move bridge init sequence to atomic_enable From: Marek Szyprowski To: Kaustabh Chakraborty , Inki Dae , Jagan Teki , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Language: en-US In-Reply-To: <1db5ffdf-924b-49cb-a057-802a1bfe6073@samsung.com> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20260126145422eucas1p243889bf4ac456996ce7ed05111331d67 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260124172136eucas1p1e7a2da65c3fca268ea68f12506c6c19e X-EPHeader: CA X-CMS-RootMailID: 20260124172136eucas1p1e7a2da65c3fca268ea68f12506c6c19e References: <20260124-exynos-dsim-fixes-v1-0-122d047a23d1@disroot.org> <20260124-exynos-dsim-fixes-v1-1-122d047a23d1@disroot.org> <1db5ffdf-924b-49cb-a057-802a1bfe6073@samsung.com> On 26.01.2026 09:57, Marek Szyprowski wrote: > On 24.01.2026 18:20, Kaustabh Chakraborty wrote: >> Since commit c9b1150a68d9 ("drm/atomic-helper: Re-order bridge chain >> pre-enable and post-disable"), pre-enable sequence is called before the >> CRTC is enabled. >> >> This causes unintended side-effects (abberation among potentially other >> things) in the display when samsung_dsim_init() is called in the >> pre-enable part of the sequence. Call it in samsung_dsim_atomic_enable() >> instead. >> >> Cc: stable@vger.kernel.org # v6.17 and later >> Signed-off-by: Kaustabh Chakraborty > > I'm not sure if this will be needed: > > https://lore.kernel.org/all/20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideasonboard.com/ > Even more, there is a pending similar patch: https://lore.kernel.org/all/20250619-samsung-dsim-fix-v1-1-6b5de68fb115@ideasonboard.com/ Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland