From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DF9838A73A for ; Wed, 1 Apr 2026 17:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775063480; cv=none; b=aHmeomaxC+vszT1JKaQm1EmVPqpgb00tAlA9j75WH4d3sXAFL6zpo8yOzyEUPnVVmlpbRGHB5xk+GGu7BPQyg5BIKQE4K+8Bnn1kvpN6uJskOBTh0ZFvWh/ZkVkys0scmiR9UxnSMsuFhnZYaKbCItQ3HjJ8l8FsvBqIw3JgEvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775063480; c=relaxed/simple; bh=tKQg9FEyHFjH051eIU+lMe+gbUHFvtyWocXZ67LAsPU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D0IH/n9T0dY1MUIQq7H3XPNwIRhn1oK/ELb1B7ox/2ok9K+FUTmT0OpHJ0WzVDS1an4qLJT+AV6c5O4byfp6V0KhNOKyCJQD0jk2OJLvlwTs43tVq7AhaSuYpnqNyjBRPi19MbTcNSZQ12Qo9aUq9W8ChMzToX81abLsx2N1uV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YdNQXbck; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YdNQXbck" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2c156c4a9efso27408eec.1 for ; Wed, 01 Apr 2026 10:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775063478; x=1775668278; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cqZuiU/Uwawkq6HgVlP6yMHEQIxXC9LO0ktZ8u6/saY=; b=YdNQXbck4S7jYQGIL3HfFSipC4Ubn1oZts1o0N0hp6PVYEHb5Y0/j2AeXgsaNZmjs+ nVJYyyuDUYJLC2TDI1kEFQyzIHFW5e7Fd6Kd+2tlHWGnz5zdGlEKXJN4TdsbEqadyUTR 2bafn38tfAHz7H9SBE/dRws7b5l/QuWL/yQITr+RCStZvqoEJOiRW1EMOMhwFMUzd1UC uyntT95dBKRRit132FxECGD3M5vpgNTDuRdJyeZqucQlQ4y65w/Mke5cnuoVyKr6jsJ7 F/4XanTcrJp3YLBi6pU4hPOWnYWvnU+wOr4uPdqRWvu4ykW1IKA8/+NvcWCy3ZVlfSiS cveA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775063478; x=1775668278; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cqZuiU/Uwawkq6HgVlP6yMHEQIxXC9LO0ktZ8u6/saY=; b=AsVmIw7dtMN8iCt69/RpP2L326B/fZLlmDxHsE2N38e/ZZ3L+A/zWx7Tmya8/auNk1 +wUaJtf+dz03PBQX60roVaRK4Ya9GECdq1RYdo2PEIO45Ae3w2pxwfyl8LFVazzL/LzN /9F2gaNawqvrlwlaUywUqMJWCNVZu2js9czWqWV7Y9vBO9aVOUTVHjCaRCOa7UuK1ApA kGB1dveA2vTE9yVWNjH1Elh5v1Ii6lyEyDOan8+q+cCTA14PdbxunKaQvdob7KiaUAZt b1KqZiU8Aurc/Tb24w0kS6XWQ58tGvg6am+5IdnyeLWLF34aJDXzuCfRL5/JQPN4Jv4H cXyw== X-Forwarded-Encrypted: i=1; AJvYcCUAs2IWaQdGvUQRVDRAI8X56Yn13BrL1WWuMnnH4O9N/MsOikyDDYWy80Uspnh7PIQcyDbXmkaVCV4Wcsk=@vger.kernel.org X-Gm-Message-State: AOJu0YyGRNlvVuNeibWgnY220OurD88QKbzJnvArmmxOpagZNHjgcDXu HwBdajsVWFPY/7Um3PTe2urLB9+Nrqp82bFvKufIbVb5kwQEHpz8Z/Ga X-Gm-Gg: ATEYQzyIgWXFdsILYJThhWCA/c3XgkHMDerf6QUz4G9xgY7tZfXCM4WAon/nyVhIIwI +71Q08UKgmN76F//1aAZeitU9cf6YSwL4WHIR2Vpbhih89d04l/i39CF8XaRgUNNj3C5jdBB+gZ /i04v2dLCHtE48ogsWnBCHSiVBEm9D8XlE+jX//y0NCB4PJ4EBEUk6859clw3netLGT8KJop2iM +zTvl1JPexuzJsqZUim9chnOVsle9gKeBIsHU5GxmeXEAQUXf5W6pIeZyze/j9unZQ0fFcN6ITG VgxwwmkCCfv5B/aJT4mcpf7b8tdvjf2ZiGnAM08rkM54YQ66lRTupfXw3pZdAE0n3kCDTk0xXu8 Wkl1BWdxOXs00rHZ9BfFaHXHNBMQvgZxmvsT8HVoaLN4PJ7SGcq1QcyH31beQocVNzK4orUMBQh G1CtvOisNHA/jXyJn1T91WL6i6XMyWocjlKE1F X-Received: by 2002:a05:7300:aa8c:b0:2c1:23d:c728 with SMTP id 5a478bee46e88-2c9333bca76mr2295783eec.31.1775063478040; Wed, 01 Apr 2026 10:11:18 -0700 (PDT) Received: from fedora ([2601:644:937c:6c90::c63a]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca792f3f3dsm250190eec.8.2026.04.01.10.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 10:11:17 -0700 (PDT) Date: Wed, 1 Apr 2026 10:11:14 -0700 From: Vishal Moola To: Suren Baghdasaryan Cc: Brendan Jackman , Andrew Morton , Vlastimil Babka , Michal Hocko , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: cleanup flag vars in alloc_pages_bulk_noprof() Message-ID: References: <20260331-b4-prepare_alloc_pages-flags-v1-1-ea2416def698@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Mar 31, 2026 at 09:10:11AM -0700, Suren Baghdasaryan wrote: > On Tue, Mar 31, 2026 at 3:52 AM Brendan Jackman wrote: > > > > These two variables are redundant, squash them to align > > alloc_pages_bulk_noprof() with the style used in > > alloc_frozen_pages_nolock_noprof(). > > Indeed. I'm not sure why this was needed even in the original patch > (387ba26fb1cb) that introduced this function. It carefully preserves > the original gfp even though its value either gets overwritten later > (prepare_alloc_pages succeeds) or is unused (prepare_alloc_pages > fails)... I did some digging and wasn't able to find any reason myself. It should be fine without it. Reviewed-by: Vishal Moola > > > > Signed-off-by: Brendan Jackman > > Reviewed-by: Suren Baghdasaryan