From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C26CF47D943 for ; Wed, 1 Apr 2026 17:33:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775064816; cv=none; b=J+Hq6OvTyHiSngtPiALqrutZk3Pkf3BYcsJhdrX2iA3MsRfU3UEqLT8VC1wykKWkmkwgsoiU3nQ+P/yF040eD8nygSEUBrNkX65l+6kTVU07nmHaUZcVqay++F0s9eSB0rbRgn7znxRALBqJhmiU7SUfZgV6LjQL8VJl1O4JGQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775064816; c=relaxed/simple; bh=GALUpL9FcmSNoTtHE6SpePyLmLDTRd/mTbP3SWjUuZY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UBfXcZ0UdXVi5Aj+T+AYZc6t0+wHK1jZW4iZcQ1hZGl9f37iI2Na3/MV5P0CIHjGlh0s8MIiDsFFTUXtPUxBG+CVH9z+C081qdqJdq0feSMTaOSofKHgyoIcG14T0Iz9aip9mGogPBWtBS0iLaqZ+oJljsvi7nGGlMr+LFOeYMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jN3S4vo9; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jN3S4vo9" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-6500040ef83so2253d50.2 for ; Wed, 01 Apr 2026 10:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775064814; x=1775669614; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aLnfQJSw9REm8a9+311bKseMryW3/suAyHmSGj3g0SU=; b=jN3S4vo9GyI2XB8Fn/2MYWFXOCDgzoUTeZjXWDVdiUqT5EiNDMAgL0TppgHK4Pb1GQ w7gwMrL2qoaPoVHje+nFVixsYdAxvZXYuqrRGcUVcKkAE403IqYC0c0bwhvmx7Jb5c6H YV4ORyoMHUwNIonuUnYgtwDyNvoifgjRn6yGopphXa/sb+UbXF3yPRM1Hd74sfhYuhy8 32v0wkH5kbXdzL5uN8r7uIKXRjcpWj6l5cGBxso0XI/jndUsqqlHz3KQMhhhd7XK+vQX +WdaTHrO6T8RLsTVNNsnn1FxwrQQsmEJdmRKl8Bg/kg0k/JYbPkPr1x99xOhfBRI79jP jNmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775064814; x=1775669614; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aLnfQJSw9REm8a9+311bKseMryW3/suAyHmSGj3g0SU=; b=CCikS3nQFJzRSCGotgFxFGuVpuvcJNqGHeF0DfHFNMs4qWZWt/vu+vurXGy1bO7jRI 8lMiAxtPB7L2pmt7+HbRH5OVTZ3nbjvUWHjqD/Rpu+IOnH2Xdr++WWyQcEs6QuOHfk8O IjX2hFr9Bmt5rl4UZxyucuzJ0kcoLtE/37p1kvrE4m+61jAq3vAASujMfW5MTgI2j1hI zssYdoU5/36C7YMt/g8oZCvYNngi6ADB5woHg3iGBRBct60wtyIrMnAG9l/yY+Gdm8by oOHxifBD0VWTe9aJixqEL/+vCj54MEJKxhSqE4140ECXWPxMoDBgAzWronrooolYIXWx ogIQ== X-Forwarded-Encrypted: i=1; AJvYcCURi7ZoI7dZuKAGZ9x5IyaxX2c4VenwB1KgjUgkQARA16V5jnMVmCF268svbtO/DFIFx1YQoW3SBOgpDjg=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ418V6juZhojKA8b4Ezhp14u6RcQr/ZDQRTgwVoBhnKnDdclZ w6J/fkbrKXwyj02wRzWDoPMFZ41RBritpMnWSgnocUIutl5lGU/dI179gu8RkQ== X-Gm-Gg: ATEYQzwxqIp1ow54I4hnCip1jkiO0OYSWU6ioso8w3O/uivGWBfA184uhi2drKXfE8o eEPIw0fw0ziZl9EPqc+lkOpUczbzzaO9b92Fz+kgfqtJpY0S8rMPx/Ekfp3Bl7bwkWg5Qbxucle nBzYkk1WFEAznk9WhGrhX6VjwSQBwzmxREdK7N0EkS0TDWOePnC+dHc13XNxv1kPOLgZtYLcoP+ ywQXbToqAmbjbqxCT9DWz+kwCyiXt9VP+xHL2wfEnDeQw/9hqpYJoLYa0ebCAswRKrmUcLOY/dA Q/dDuBgXLq7yNqgDPj7sOB2DQNPXDY11kgfFjXg5aj7GdkvELuqPiL2EoeWjTZPV2oybFn+XrPB D1MGP4svbdBVypyLVNzL5qb3U9dEZQXhFMCVL6HezRf+xfStoQ/jasM6EiKKhe6A9IiSDocIeRM 7nZV8TlBbdQSgnu3IVYh4Tx9lFy6KJtqp7 X-Received: by 2002:a05:690e:1c20:b0:650:3aae:e2e6 with SMTP id 956f58d0204a3-6503aaee65fmr764874d50.20.1775064813767; Wed, 01 Apr 2026 10:33:33 -0700 (PDT) Received: from syzkaller ([2a03:2880:25ff:5c::]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6503a828f3csm214698d50.3.2026.04.01.10.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 10:33:32 -0700 (PDT) Date: Wed, 1 Apr 2026 10:33:27 -0700 From: Bobby Eshleman To: Stefano Garzarella Cc: netdev@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org, Bobby Eshleman , Jakub Kicinski , Simon Horman , virtualization@lists.linux.dev, Eric Dumazet , Paolo Abeni , Jin Liu Subject: Re: [PATCH net] vsock: initialize child_ns_mode_locked in vsock_net_init() Message-ID: References: <20260401092153.28462-1-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401092153.28462-1-sgarzare@redhat.com> On Wed, Apr 01, 2026 at 11:21:53AM +0200, Stefano Garzarella wrote: > From: Stefano Garzarella > > The `child_ns_mode_locked` field lives in `struct net`, which persists > across vsock module reloads. When the module is unloaded and reloaded, > `vsock_net_init()` resets `mode` and `child_ns_mode` back to their > default values, but does not reset `child_ns_mode_locked`. > > The stale lock from the previous module load causes subsequent writes > to `child_ns_mode` to silently fail: `vsock_net_set_child_mode()` sees > the old lock, skips updating the actual value, and returns success > when the requested mode matches the stale lock. The sysctl handler > reports no error, but `child_ns_mode` remains unchanged. > > Steps to reproduce: > $ modprobe vsock > $ echo local > /proc/sys/net/vsock/child_ns_mode > $ cat /proc/sys/net/vsock/child_ns_mode > local > $ modprobe -r vsock > $ modprobe vsock > $ echo local > /proc/sys/net/vsock/child_ns_mode > $ cat /proc/sys/net/vsock/child_ns_mode > global <--- expected "local" > > Fix this by initializing `child_ns_mode_locked` to 0 (unlocked) in > `vsock_net_init()`, so the write-once mechanism works correctly after > module reload. > > Fixes: 102eab95f025 ("vsock: lock down child_ns_mode as write-once") > Cc: bobbyeshleman@meta.com > Reported-by: Jin Liu > Signed-off-by: Stefano Garzarella > --- > net/vmw_vsock/af_vsock.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c > index 2f7d94d682cb..d912ed2f012a 100644 > --- a/net/vmw_vsock/af_vsock.c > +++ b/net/vmw_vsock/af_vsock.c > @@ -2928,6 +2928,7 @@ static void vsock_net_init(struct net *net) > net->vsock.mode = vsock_net_child_mode(current->nsproxy->net_ns); > > net->vsock.child_ns_mode = net->vsock.mode; > + net->vsock.child_ns_mode_locked = 0; > } > > static __net_init int vsock_sysctl_init_net(struct net *net) > -- > 2.53.0 > Reviewed-by: Bobby Eshleman