From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF1DB31AAAB for ; Mon, 2 Feb 2026 22:04:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770069885; cv=none; b=P7aHUcVJNYtsSDeIa/0PYPwwv4oWkYtI2c1TPRJa5UBfVohhHQH3hob3+haDRm6L+GLgKXc97FSY9+irMDSZsoy0cwRIA3hlz2ZK6iRHpyxrLT4blg0NGe/dtM3jJWlwo9krITGuciFpqQsnr5vi4HWa+J8eio6o5zc4McJVOUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770069885; c=relaxed/simple; bh=7VykqEqHfUn5733n2KE5/tx5n0O8ya9OVk/KKprmhC8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Z3lXFlknOiQbyW4DwUUgmdp9jLsHqQkjgVuaJk5fCxhiKkYbny6dKuZE34lFftv28+41isA5tEsSiUkYaOlCqM2z9pMVVTbWrzlWAdDQDqUJw6qPcMYvgOoOal5irAMTMwwQzDjEIM8PGntNJUHFETsk+MjcQHLD/sbo+njI6kA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hc7xlTtz; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hc7xlTtz" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-480706554beso53553355e9.1 for ; Mon, 02 Feb 2026 14:04:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770069882; x=1770674682; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=IFLZ+5GxWIPwp0hW4yiKz6XiBiZeFbJ7SQBypDoy+TQ=; b=Hc7xlTtzzPTujrUqIFSdL5ISJlN2PRSIbmoH1DiGwt7TkOpx80E3BTtXVpqYw/YnmZ FknldoRq/YC9cB5r6x4ci3kFDKDoPe0MB97GXbZa/7nburMxWCA0w8i0Z9z5IMw3SeBE kzc/psU3PK9Md9e3Ybh6O5w4yxcEJcZ6/ob2I+s3XmR9+BRZ6UroLhDtfRex8wrIL12z klwZc9VEyOC51xN8DtjTSo2zGeFZ7jBMXLlaiZ0Oto9xrxe8m2txLukmdNYHbZUoNwZH czOwHb1bI+9fov282TBnNa/FGBFdNQ6a04j7XhpNOZo+WVc0txrilwcNToWLZxeHWp1V 1Oag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770069882; x=1770674682; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IFLZ+5GxWIPwp0hW4yiKz6XiBiZeFbJ7SQBypDoy+TQ=; b=XftER8wZKC2DX2dWiq+/F4kuSyGoq9lxp30V00200EKF1Q+9r5+TD54SVV9Ieh6uSn 3mBlmopa6Jgses1FpPcOn0kC0pZfSmSvlWhihTRNA/d2buERkdkuVbmFDp0wLpB/knCU B7fNnoJoNaIf9FGdNuJhqJg3jM3pEO9rz6HGhJmV8G/LE+dEYsLdefyTQEgDLVqmAHwu hQbbIWabe7H+sxty/WdYSjgEDX9NtxwIgwjMFl01VvzOxNc8AR0+Ese9CUpxjJJgx36b bwho1SBPBrDGefPdQMo0CT44tFv84Q9eGGN6o+8F7yGHrEvh9TjcbaQLnOR6SSE9TxaH u0hw== X-Forwarded-Encrypted: i=1; AJvYcCVxe5YmhVypBMVKGOqGyR6fMA1LDxkEM9BoM5pZu3ARCxa/hTIA0/z1x3fEsqVknp2WGX0uYWE139ZPXuE=@vger.kernel.org X-Gm-Message-State: AOJu0YyMDhxSqYfmTCFo3uo2nX4rYYXmkHadb2iXon+qQqDrcYMB1IiV iUk7uLR9MEzwgTKRXUDl86Z/KSBt44U4c1bp9vcU1GF9o+slQE8mzt/b X-Gm-Gg: AZuq6aLAaJbz1tZ7Ok7MUa/oByeC4/l7mQ4c80K7bxZgJwDch7DlpVKEhI87tz/zGkK OXOcmcp06vQTwjxuxFitUfVsdJlFGa8/X0cDa1lLxne/TC6oRT43Y9JtvEuAbAh0n4iQbeIqzON 328fpFI3CiekVe98EzxASF+eaB5/kxlkhjwfEZTGhWOLYwOk6Xt26uRMKl4ZwdWtQgBPX9vHxVq j/iurCR0x1Hn2/RateBXDhLTDQm9EH6Ndvi3WQvwWX7PXhZJpu6L0XtF4EoQ21I/CQpqmgsoNW0 S23EErORB5LtsX4MNm0ZPr/8Afl/SRU79njdtLVj7LW1qDm/JBdLn9n/6ryAsUYRv20LHbaxgEE ajgKAAwE24x8qIudcBt4EXNMx52wdi3Si0+JxRcJYCvZaxNHVqDTiGZWRZZo4hQTc3JhaVJ+zW+ UhMg3igx3kbeXqRuGzjT/K8OpEyjipwBk3RvP9ARssUOAztpDBVhrwv+X6yZNAj1L0XMQ= X-Received: by 2002:a05:600c:3b23:b0:47e:e87f:4bba with SMTP id 5b1f17b1804b1-482db49e871mr172494235e9.29.1770069882072; Mon, 02 Feb 2026 14:04:42 -0800 (PST) Received: from 0.1.2.1.2.0.a.2.dynamic.cust.swisscom.net ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edfe7sm46189472f8f.14.2026.02.02.14.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 14:04:41 -0800 (PST) Message-ID: Subject: Re: [PATCH] [v2] ASoC: sophgo: fix 64-bit division build failure From: Alexander Sverdlin To: Arnd Bergmann , Chen Wang , Inochi Amaoto , "Anton D. Stavinskii" Cc: Arnd Bergmann , linux-sound@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org Date: Mon, 02 Feb 2026 23:04:40 +0100 In-Reply-To: <20260202215956.2127414-1-arnd@kernel.org> References: <20260202215956.2127414-1-arnd@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-02-02 at 22:59 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann >=20 > cv1800b_adc_setbclk_div() does four 64-bit divisions in a row, which > is rather inefficient on 32-bit systems, and using the plain division > causes a build failure as a result: >=20 > ERROR: modpost: "__aeabi_uldivmod" [sound/soc/sophgo/cv1800b-sound-adc.ko= ] undefined! >=20 > As the input value is actually a 32-bit integer, just change the type > of the temporary value as well. >=20 > Fixes: 4cf8752a03e6 ("ASoC: sophgo: add CV1800B internal ADC codec driver= ") > Suggested-by: Alexander Sverdlin > Signed-off-by: Arnd Bergmann Reviewed-by: Alexander Sverdlin > --- > =C2=A0sound/soc/sophgo/cv1800b-sound-adc.c | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/sound/soc/sophgo/cv1800b-sound-adc.c b/sound/soc/sophgo/cv18= 00b-sound-adc.c > index 794030b713e9..de1c77014c2f 100644 > --- a/sound/soc/sophgo/cv1800b-sound-adc.c > +++ b/sound/soc/sophgo/cv1800b-sound-adc.c > @@ -100,7 +100,7 @@ static int cv1800b_adc_setbclk_div(struct cv1800b_pri= v *priv, unsigned int rate) > =C2=A0{ > =C2=A0 u32 val; > =C2=A0 u32 bclk_div; > - u64 tmp; > + u32 tmp; > =C2=A0 > =C2=A0 if (!priv->mclk_rate || !rate) > =C2=A0 return -EINVAL; > @@ -117,7 +117,7 @@ static int cv1800b_adc_setbclk_div(struct cv1800b_pri= v *priv, unsigned int rate) > =C2=A0 } > =C2=A0 > =C2=A0 if (tmp > 256) { > - dev_err(priv->dev, "BCLK divider %llu out of range\n", tmp); > + dev_err(priv->dev, "BCLK divider %u out of range\n", tmp); > =C2=A0 return -EINVAL; > =C2=A0 } > =C2=A0 --=20 Alexander Sverdlin.