From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1297FC43144 for ; Mon, 25 Jun 2018 16:29:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B491525E13 for ; Mon, 25 Jun 2018 16:29:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lechnology.com header.i=@lechnology.com header.b="tMM0XH+b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B491525E13 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lechnology.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754795AbeFYQ3c (ORCPT ); Mon, 25 Jun 2018 12:29:32 -0400 Received: from vern.gendns.com ([206.190.152.46]:49610 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbeFYQ3a (ORCPT ); Mon, 25 Jun 2018 12:29:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=r91C6+aK/61YDGvR398KlNuGauI9OXfL1vw5DA5xmwU=; b=tMM0XH+bf+eTX3sYvWvUzX978k FRREJ6VG8WenwisleIUgdubgVixlCFpGAA8qvY/m6aI4wJxONvZWzD8RSI7JYTgRTdO6EjE5HO7E3 hg7/2YK1jrIQkax5UasJ3wYaAJ3pdgiU2SlUKnJ3eJvHZ+7dI/gaWXrCRAZt17X4DzJfqAaX+LRUE ZE9uvqVRPQYC/e7oEmpoIrLOC1tijRXpdN7ge1bnALJm9BFFa5ZCmPNQaGeKOlq/A1u+god/ab8v5 inbWPXeF3inRQB1YQBu4ktjRs9lh282hCkKq1QQ8cdalhH6hlp3Gm+qkqtfhWDyaMKK5L5gFqua5p xjIe9oCQ==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:54456 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1fXUMr-001FnC-61; Mon, 25 Jun 2018 12:29:29 -0400 Subject: Re: [PATCH 6/9] ARM: davinci: da830-evm: use aemif platform driver To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Sekhar Nori , Kevin Hilman , Russell King , Michael Turquette , Stephen Boyd , arm-soc , LKML , linux-clk References: <20180625152920.11549-1-brgl@bgdev.pl> <20180625152920.11549-7-brgl@bgdev.pl> <0e4bc2fb-15fc-6422-a4a3-0918adf0b1b3@lechnology.com> From: David Lechner Message-ID: Date: Mon, 25 Jun 2018 11:29:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/25/2018 11:23 AM, Bartosz Golaszewski wrote: > 2018-06-25 18:20 GMT+02:00 David Lechner : >> On 06/25/2018 10:29 AM, Bartosz Golaszewski wrote: >>> >>> From: Bartosz Golaszewski >>> >>> We now support board files in the aemif driver. Register a platform >>> device instead of using the handcrafted API in da830-evm. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> arch/arm/mach-davinci/board-da830-evm.c | 56 +++++++++++++++++++------ >>> 1 file changed, 44 insertions(+), 12 deletions(-) >>> >>> diff --git a/arch/arm/mach-davinci/board-da830-evm.c >>> b/arch/arm/mach-davinci/board-da830-evm.c >>> index b2470141dba3..666db3cee08a 100644 >>> --- a/arch/arm/mach-davinci/board-da830-evm.c >>> +++ b/arch/arm/mach-davinci/board-da830-evm.c >>> @@ -28,6 +28,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> @@ -333,14 +334,48 @@ static struct resource da830_evm_nand_resources[] = >>> { >>> }, >>> }; >>> -static struct platform_device da830_evm_nand_device = { >>> - .name = "davinci_nand", >>> - .id = 1, >>> - .dev = { >>> - .platform_data = &da830_evm_nand_pdata, >>> +static struct platform_device da830_evm_aemif_devices[] = { >>> + { >>> + .name = "davinci_nand", >>> + .id = 1, >> >> >> Actually, now that I've thought about it some more. It probably >> makes more sense to make all of the "davinci_nand" devices in this >> series use id = -1 since there is only one per board. It looks like >> da850 is the only one that has a lookup for "davinic_nand.0" already. >> >> I think that we are going to have to add clock lookups for the >> "davinci_nand" devices as well. Although the driver doesn't do >> clk_get() explicitly, I think some function it calls does get a >> clock. I remember that we had to add a clock-ranges property to >> device tree to get the davinci_nand driver working, which is why >> I think we are going to need a clock lookup for these devices >> as well. >> > > Seems like ever since commit a8e3923ab571 ("mtd: rawnand: davinci: > don't acquire and enable clock") we no longer need to worry about the > clock entries for nand. > > Thanks, > Bart > Sounds good. If you end up touching the da850 clock lookups, you can probably drop the "davinci_nand.0" entry there.