From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 679D436EAA7 for ; Thu, 5 Feb 2026 09:01:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770282077; cv=none; b=Z6lEXaLdX9sBsndmf/ikHxEKM6AMliLmNs/ZZSKd3Ik7EAsEu+ARJj17swCzbnkSzAamFFr1ZTpol7l/z9d7kscRgBfi1cHG08j2gOlXErkpDiIqBFxXaRML6ShoTM+LNZwV8lBVp2UKhdKJol6bUBmrQojSJveoLElht1oiyZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770282077; c=relaxed/simple; bh=Gkb8FKXpoDfkn/jUQYSvOOu7QYbZgcPt/PoChDyyk2g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qlsiz29o4FiL/V3pKW39df9zaER2ay7wTgG4VZwWAcuBLP0vqUy+gPljdPk3VLroC6Up19njEbTLhsvq2xNpifJcEfC11FJbT9TYD70MNeKwFFtRDub1aSxJFDCTdlVdcO9YcFldQe+TuGXE+Jqb2CKaJSFAmenMdeBM7zVHGQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ro54lUHF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eXRrle9I; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ro54lUHF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eXRrle9I" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6153e1AV3246047 for ; Thu, 5 Feb 2026 09:01:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PJMVZFUE4KOxEnuiMJZ5bx2oMxAoaysvSaCQJCkpBCk=; b=Ro54lUHFe9GsPDIk hB70/hyU3CTrQtxbd5S9gt8Et0bA8STlbRVLW5wg1V4GtowAbzse10D7z809GZz5 lkUZFRWjNoIDarrX7YoXQU8a/bIfIwORP3/8AqWxMxf3038LjuNen4fQYNH9/GJe M9gaqPdCB9P1noge9IrxKILatExFwicQfDFh6y2vCEJxDH1cBh66Y7/DKuSSqc2M PmNeC1R/oTKwl+CD4unc+95/TKCkjUQpUGFq5jAQ1zDdqmE+4/D0tdGa1v4aEpfT AfOZIGKZFtaG1sFMsK0G2fqoWJM7i3BEKWVQ8hxe8X3umB0wM2jHHjOmx76DZrpb xK4Tpw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c4cp51xnx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Feb 2026 09:01:16 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c6d6b0f193so14643185a.1 for ; Thu, 05 Feb 2026 01:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770282075; x=1770886875; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PJMVZFUE4KOxEnuiMJZ5bx2oMxAoaysvSaCQJCkpBCk=; b=eXRrle9Ifsp7rKzldF4MzcMGtFxlFIQkUQ/cQIaaBRC+np5pfGof62MTJ17Zpytc2M Igq0wmGCiz7lrrNI19d3vJ/R4oJOnviEO1Zt2Fcf/p+zijt1MTOFcPlhS9WVnkYpENsq blRlO3bb2qcCKBdVITyQDpNPteeAPWHTb5QUrYBoE6KDFQFf2f73Y1IGvOc3PNTP305n V9H2w0quhr7Zoz/oaaJAtrwpXCKbrtvbnPbX51YoUjCaPi5gGUiKNvgxJcTfHXI6hFZm 4VL1m/FB74B7ES6am4WOL6A8XU8pI5Nte5lt/kkfzaL1QJ2ZEIWyrsPokUh1SvMXa4C6 ttpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770282075; x=1770886875; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PJMVZFUE4KOxEnuiMJZ5bx2oMxAoaysvSaCQJCkpBCk=; b=V50l/+RyNsTLsbEcTfyCE713L7NL/NCRZaahpKfs9AOGAugKXD6nt8lHxR/4JxdoVX gsRTSZKT0OVu+C/0vXCH8s3R1rsT/a0rfrRNyydhw2wAvMSe4/UVZiPG3FaUwfMhnddS 8EXoqv9xUXWSqPiwxDCoYPAguTz3QTANXbwcX1VPmcDyYQg+uK+iosReFubtFqD2UgFy Kf/6SEX4bRVyWwfI1p3AQ3//E2RBz4GRk0rlKwV3dmn6s3MihQ5kzUhKkhERTowsvZyY TZKoU6psp6dkt1e7UtFbz7zNStGU2fcw+xp32yfGZDyoVNdds2ZdW+a0jGofhFfU4VJo tGLg== X-Forwarded-Encrypted: i=1; AJvYcCUNLFkwB+qcdiQuo7fjk/85f8swh49g8a+LZV5p5RXlGtu3FTEb2igrxeBXn9uLenRl4xDUvvxiazpK4U4=@vger.kernel.org X-Gm-Message-State: AOJu0YxPMxXo7dMcvx6ANCFtwZuknkmjrMF24sxVlYik8U21nCNgSmN6 n35y/LIVCFKQZhTwebOWajFGNQMnSSEkR93Yru+YGjXd56TDdzeC943M8nQtiAUng1StM7cl1QE ZAACNYgfqfjsSDqbgz97pgW7RZzZh3RoP5W+F1/2v621RccGAubcz0SLZXs84oSCBzUc= X-Gm-Gg: AZuq6aI3HIKW747NsGW16PZyh4b+K7GEAOEnV/PUabcS2nW4DzZRN275dgubFanBd2v cFHKmwb3GYUC/nuD1AL1ORoHa90EkkrYEgi7IZo0NnOkBNCwcIs2ftzuGe85knhHIlUSb9Iwl1i y9r4UShIxp+RT5qeNhxLNsOe9L/tTMVVN8dqZNMpHsu55MFponxwSOy6X1hRgOYqK4vQMwmsLuu zDbhq4BOMF6M0h7GDQgAgqVzytJ7ImzW5tRNHn/dhludQvX5nSmEN7ng9yTxGjiQBNkO/ORWqrC 94WEZe9fqLhaLMwcuC/+uocjlxjqeMs/JRCMCi1LBJ27++UyWBTV1I1ekJAsm0E4n/LFVnisKx5 jcYqPGRHxZheFrJjaUSTGZDNhiGPPMCTmAZ2FJYmYTvt3eZUydYUICXWX8kfwmeR+mOw= X-Received: by 2002:a05:620a:17a7:b0:8c6:ca3d:4e0a with SMTP id af79cd13be357-8ca2f83c150mr570395385a.3.1770282075549; Thu, 05 Feb 2026 01:01:15 -0800 (PST) X-Received: by 2002:a05:620a:17a7:b0:8c6:ca3d:4e0a with SMTP id af79cd13be357-8ca2f83c150mr570389785a.3.1770282075007; Thu, 05 Feb 2026 01:01:15 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8ea004ff20sm206037366b.62.2026.02.05.01.01.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Feb 2026 01:01:14 -0800 (PST) Message-ID: Date: Thu, 5 Feb 2026 10:01:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: interconnect: qcom,qcs615-rpmh: add clocks property to enable QoS To: Odelu Kukatla , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: Raviteja Laggyshetty , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Tipton References: <20260202070534.1281652-1-odelu.kukatla@oss.qualcomm.com> <20260202070534.1281652-2-odelu.kukatla@oss.qualcomm.com> <95d42fb7-2365-46a0-a995-c9cc51b17424@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <95d42fb7-2365-46a0-a995-c9cc51b17424@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Oc2VzxTY c=1 sm=1 tr=0 ts=69845c5c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=3aRxcYRQ6Dp4JYTzBNUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: Dp2tx1_4HW2SGmfK7_ysu7yatmXGw8jY X-Proofpoint-GUID: Dp2tx1_4HW2SGmfK7_ysu7yatmXGw8jY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA1MDA2NSBTYWx0ZWRfX1dFjC/fgTV5s q8vPhEAZjYtYZsmZ3o9Pgfk3SxQcbAiZXx8Ef7VNolxHK8Y+aMsQtYfx6FKOUKg/Cngd0pWHQyW bELa+Af/wVQmvgSOzWqjcdAExsMuXxlZd5eT2ssqq5LslyRGmdVT48vrQC/GVpLFHNwH38JJkm/ J2pwU6MH2+sZP9WcmuDpVH1bnCqyY6ayjnL6QIq6ktVG9oKo8klUQJuyonEIBIv3ALEVtKVLNEM WAL0+lES6cJD0V3/fWC6WGed8S55+GJaz+5eRkY/boou5P1A/YzsZxAiZk2+G5kEejGtzY+HPAy IJYyIHz4LzVG/c5DNaDG2gPCRYKs2LnrTidh9O7tzyPOxE1lpmlzvFqJ+Url0GvfTduFqddLY6K Q87zhPvJkdJWEhf9x4VqGgnSxgnLec51cQi7pggDPXnvPO1gHwmARcNFpHd0D9fgHxzamPc3yAq L6ZCd9xYKXpUXA1/3Yw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-05_01,2026-02-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 spamscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602050065 On 2/5/26 7:06 AM, Odelu Kukatla wrote: > > > On 2/2/2026 4:33 PM, Konrad Dybcio wrote: >> On 2/2/26 8:05 AM, Odelu Kukatla wrote: >>> Aggre1-noc interconnect node on QCS615 has QoS registers located >>> inside a block whose interface is clock-gated. For that node, >>> driver must enable the corresponding clock(s) before accessing >>> the registers. Add the 'clocks' property so the driver can obtain >>> and enable the required clock(s). >>> >>> Only interconnects that have clock‑gated QoS register interface >>> use this property; it is not applicable to all interconnect nodes. >>> >>> Signed-off-by: Odelu Kukatla >>> --- [...] >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - qcom,qcs615-aggre1-noc >>> + then: >>> + properties: >>> + clocks: >>> + items: >>> + - description: aggre UFS PHY AXI clock >>> + - description: aggre USB2 SEC AXI clock >>> + - description: aggre USB3 PRIM AXI clock >> >> Should we also include the IPA clock here? >> > > Thanks for the review! > > For QCS615, the IPA clock is already enabled by the bootloader (xBL) and > kept on during the boot‑up stage. Because of this, we do not need to > explicitly enable the IPA clock in the interconnect driver when > accessing the QoS registers. Would we need to re-enable it to re-program the hardware if say the icc module is loaded after unused clk cleanup or after a cx collapse? Konrad