mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	ZhengYuan Huang <gality369@gmail.com>
Cc: mark@fasheh.com, jlbec@evilplan.org, ocfs2-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org, baijiaju1990@gmail.com,
	r33s3n6@gmail.com, zzzccc427@gmail.com, tom442288@tuta.io
Subject: Re: [PATCH 0/2] ocfs2: validate active orphan slots during inode read
Date: Mon, 31 Aug 2026 14:32:38 +0800	[thread overview]
Message-ID: <ac2bd4a2-808e-4f37-89de-930836320d36@linux.alibaba.com> (raw)
In-Reply-To: <20260804134157.38e3b8513d53c079f8b05823@linux-foundation.org>



On 8/5/26 4:41 AM, Andrew Morton wrote:
> On Mon,  3 Aug 2026 11:00:05 +0800 ZhengYuan Huang <gality369@gmail.com> wrote:
> 
>> OCFS2 trusts active ordinary and append-DIO orphan slots read from dinodes.
>> A corrupted slot can therefore index osb_orphan_wipes or the slot-local
>> system-inode cache outside their allocations before the corruption is
>> reported.
> 
> Thanks.  AI review raised several possible issues, all pre-existing. 
> "out of bound access", "crash the kernel", "out-of-bounds heap access",
> "triggering this crash", etc.  All the usual things (seriously!).
> 
> 	https://sashiko.dev/#/patchset/20260803030007.3993199-1-gality369@gmail.com
> 
> None of which stands in the way of your fixes.
> 
> The best I can do with this onslaught is to make maintainers aware then
> move on.
> 
> I do wish that Sashiko was more organized about these drive-by bug
> reports.  Retain them in some lookable-uppable way for maintainers to
> look at when they have time.  This has been suggested to the Sashiko
> developers.  Perhaps one day...

Addressed in:
https://lore.kernel.org/ocfs2-devel/20260831062848.2743436-1-joseph.qi@linux.alibaba.com/T/#u

Thanks,
Joseph

      reply	other threads:[~2026-08-31  6:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03  3:00 ZhengYuan Huang
2026-08-03  3:00 ` [PATCH 1/2] ocfs2: validate orphan slot " ZhengYuan Huang
2026-08-04  7:16   ` Joseph Qi
2026-08-03  3:00 ` [PATCH 2/2] ocfs2: validate DIO " ZhengYuan Huang
2026-08-04  7:17   ` Joseph Qi
2026-08-04 20:41 ` [PATCH 0/2] ocfs2: validate active orphan slots " Andrew Morton
2026-08-31  6:32   ` Joseph Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac2bd4a2-808e-4f37-89de-930836320d36@linux.alibaba.com \
    --to=joseph.qi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=baijiaju1990@gmail.com \
    --cc=gality369@gmail.com \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@lists.linux.dev \
    --cc=r33s3n6@gmail.com \
    --cc=tom442288@tuta.io \
    --cc=zzzccc427@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®