From: Logan Gunthorpe <logang@deltatee.com>
To: Wesley Sheng <wesley.sheng@microchip.com>,
kurt.schwemmer@microsemi.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: wesleyshenggit@sina.com
Subject: Re: [PATCH v2 0/2] Fix two bugs of switchtec module
Date: Mon, 15 Apr 2019 09:51:30 -0600 [thread overview]
Message-ID: <ac314aa2-951b-58c7-cfd6-65e53b5b5f1e@deltatee.com> (raw)
In-Reply-To: <1555339302-31829-1-git-send-email-wesley.sheng@microchip.com>
On 2019-04-15 8:41 a.m., Wesley Sheng wrote:
> Hi, Everyone,
>
> This patch series fix two bugs of switchtec module.
>
> The first is introduced by device spec definition issue: the maximum
> supported PCIe function number by hardware should be 255 instead of
> the false number of 48. Rectify it in driver and for backward
> compatible, a new ioctl and corresponding data structure are created,
> while keep the deprecated one.
>
> The second is MRPC event unintentionally masked at corner case.
> Fix this bug by skipping the mask operation for MRPC event in event ISR
> like what we already do for LINK event.
>
> Regard,
> Wesley
>
> --
>
> Changed since v1:
> - rewrapped the commit message of [PATCH 1/2] into one paragraph
Probably should have collected my Reviewed-by tag into the patches as
well. I still approve this series:
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Thanks,
Logan
next prev parent reply other threads:[~2019-04-15 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 14:41 Wesley Sheng
2019-04-15 14:41 ` [PATCH v2 1/2] switchtec: Fix false maximum supported PCIe function number issue Wesley Sheng
2019-04-17 22:48 ` Bjorn Helgaas
[not found] ` <20190418165621.GA5272@sina.com>
2019-04-18 13:09 ` Bjorn Helgaas
2019-04-18 15:49 ` Logan Gunthorpe
2019-04-15 14:41 ` [PATCH v2 2/2] switchtec: Fix unintended mask of MRPC event Wesley Sheng
2019-04-18 13:49 ` Bjorn Helgaas
2019-04-15 15:51 ` Logan Gunthorpe [this message]
2019-04-18 13:55 ` [PATCH v2 0/2] Fix two bugs of switchtec module Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac314aa2-951b-58c7-cfd6-65e53b5b5f1e@deltatee.com \
--to=logang@deltatee.com \
--cc=bhelgaas@google.com \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wesley.sheng@microchip.com \
--cc=wesleyshenggit@sina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®