From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2997DC8FE for ; Sun, 12 Jan 2025 02:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736649466; cv=none; b=LnQ26vuKy0qBazNvivsXd5fNale7xGaapeyu8qegpwGFee1Av+LR3PIQQHHZCTW78uKfipOQ8QpN5No76bcGP2vuJUGMvR1N4Oe9YEht/Zz1RlycEDoYy9YyftLVaAkovL2KVkpBHS36J4jhEYUI7MLAh3rmwPPXDFmFXNhKmVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736649466; c=relaxed/simple; bh=n7lKFqsHRVehIkJ+seO4LRtOefY6ISAHxearUP289ko=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FAWHMVU6V6XGMsXwedknmxB45lPM7YwkRE3yUanGNBe87loxzsq5y7767Ayr6ZyZEa/sKATsqmddg80C6CgIJCCMbQH7q3AprmiYMiZu836NMIPtbgycRqheNgy6iCFk05f9dtPrf5zbZmrxGvZPj+tsdbLLL30SjNVL4cXyiYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=shelob.surriel.com; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tWnqQ-000000000W9-2h7W; Sat, 11 Jan 2025 21:36:54 -0500 Message-ID: Subject: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes From: Rik van Riel To: Dave Hansen , x86@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Date: Sat, 11 Jan 2025 21:36:54 -0500 In-Reply-To: References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-10-riel@surriel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: riel@surriel.com On Mon, 2025-01-06 at 10:40 -0800, Dave Hansen wrote: > On 12/30/24 09:53, Rik van Riel wrote: > ... > > +#ifdef CONFIG_CPU_SUP_AMD > > + struct list_head broadcast_asid_list; > > + u16 broadcast_asid; > > + bool asid_transition; > > +#endif >=20 > Could we either do: >=20 > config X86_TLB_FLUSH_BROADCAST_HW > bool > depends on CONFIG_CPU_SUP_AMD I went with this option. I also got rid of the list_head (thanks Nadav), and moved the remaining two items into the same word as the protection key bits. I think I have everybody's comments addressed in my code base now. I'll post a new version soon-ish :) --=20 All Rights Reversed.