From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.nearlyone.de (mail.nearlyone.de [49.12.199.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB1331E82A for ; Thu, 2 Apr 2026 06:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=49.12.199.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775112187; cv=none; b=GR/q1jDfD8SPaMgmLSTMp+B3FUc8b6Rq3I2EcVEd32DhetUUbfIaLJJ/Kq+uq7UqyErRPR2KKUYA72G3Gv/p1156ISql89PeoawSyolgKS6MkzWE2n4JAmFh8WZ9lG0xSUsj/teHc+Of9Ih9xJezYdDXEgXwkBw7FUlAToQRB/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775112187; c=relaxed/simple; bh=rEu5hGgLcWb3CjQj+sYcj2uqav5RURDVRntTYDp9jt0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nw3gJ+dBrUVsx1DiayfchIX2fxohekpgI6nXSooxbXuYFMgZDsVeveLMMu5g2xeIbsH7Vx5Pz2pU/Tk6qWnV+3JfyMx4NdD2PbaG/F/P8/m5zM6t8rOxTK1zS5xtg1DSMr40lx6eJOaq4M/JH51N98TzRNm6hgige+svLSwLc30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=monom.org; spf=pass smtp.mailfrom=monom.org; dkim=pass (2048-bit key) header.d=monom.org header.i=@monom.org header.b=jbZqwdkq; arc=none smtp.client-ip=49.12.199.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=monom.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=monom.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=monom.org header.i=@monom.org header.b="jbZqwdkq" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6031EE3248; Thu, 2 Apr 2026 08:42:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monom.org; s=dkim; t=1775112182; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=jrD1iuF+GNNFEO5AvARb8A0vXs10PJBYxgbJT8WFa6o=; b=jbZqwdkqveAr6vV7TnNP3eoWxRa7pYTwbff6Ghx7yiUKG9T3rnphi9VYpjyTjc+jSvqZZ3 1wcNBaYtOjCmhX38dMqDWAVwNYict2CyubLf48f4NqCiu324Fl3woDbpxGtpYCxJjmR7Nl xtFc1SgXJDTo7ZrPSlg2DFtJ56rodualuIVcMht4G6x8YnuX7F/HoA8dUDEdR32NSX/HK3 OcjzFOkGoVOQ55ss6N58TCM+JP5+hx2Ny9vTKRjsYJrezSgdG4KMsMAiEldrJ/VwnBXAJo lzqiH7YP7VB/N18FofS7Qg33C987WOLJXOTTqR8dnB+RLGxVe23O3S6lOKOiZw== Date: Thu, 2 Apr 2026 08:42:57 +0200 From: Daniel Wagner To: Christoph Hellwig Cc: Daniel Wagner , Keith Busch , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: expose TLS mode Message-ID: References: <20260401-expose-tls-mode-v1-1-433a83d1d23f@kernel.org> <20260401140934.GD21703@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401140934.GD21703@lst.de> X-Last-TLS-Session-Version: TLSv1.3 On Wed, Apr 01, 2026 at 04:09:34PM +0200, Christoph Hellwig wrote: > Looks fine to me with the example fixed. BTW, do you think an empty string is better instead of "none" when TLS is off?