From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD4733D9044 for ; Mon, 1 Jun 2026 15:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780326812; cv=none; b=EM2HVHrLMJCP9xndJK4fnDBh+JuXUIf0E7ZGtIHc/B3PaVNCfkmnj3WPSc46pvEJDeGJRkWBOzx5r0oTiBWsyzlsvtgecCk9Ko8ALADB0zl1e+FebMG1ZaC7Mc8QK32u68Evua0O/IySHlkK3gwioheYDK7h+KPbl1Oqzpqipwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780326812; c=relaxed/simple; bh=r0+aCzNBWqpfZkcJMC8J4KdHaiFjjmgp8w4RhjdUi30=; h=Message-ID:Date:MIME-Version:From:To:Subject:References: In-Reply-To:Content-Type; b=NQzf4gRZ0kMNKtv4y+HTWtoNPjPUOsvYvMjLwmpykT8P4TQYhN+9zp3Z9br7pFmovwqTUrHx1SGJ4srdjPpXPlxfurZodQ/djSe2duCMwzgV9swGmgwTchn8xmNX3qUGHAOkVr0IXw9vcmNaqCwirj3hR5DrD3bTo2j9Zuy12is= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RYjbyKHE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D8oJAe9d; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RYjbyKHE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D8oJAe9d" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 651F2qkM1214161 for ; Mon, 1 Jun 2026 15:13:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l1AKZpYX7RXkOvz/l1ikrJX0mnPav1pKxezabwf8MjU=; b=RYjbyKHEOfptoxa2 kRWEeQHJIPHhn3IX6WIJ0PTUcElg4GClm5nJFvdUzABhJ/KM5J9g5ezP9Nd/jiPs SpYMs0QSjeqBtnDoYtb2HQfNCR4eDUoWSRdIT1BKrIjvk2LAWx1HkSinVjl0REfv LN86JJB1kgl0Ciliy/qozAkZd7wSvih2gweaA3w8n3hT80VxqcW125c8J+iOHrP0 KLn/WkTIyR0vh17KMRULiO6D4t0RdV0FHOgmdLxkAhsElUzUxetj33jF8ne1mmQz ZKTQJGMLN+wXaITan7JUM5UZYMJWpC8pFyhT93zMoCGvf5xMnlpXgSe+yVkIvqy0 FHbQtg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eh6s99mx7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Jun 2026 15:13:30 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-8423efdbe6fso1058096b3a.0 for ; Mon, 01 Jun 2026 08:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780326809; x=1780931609; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:subject:to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=l1AKZpYX7RXkOvz/l1ikrJX0mnPav1pKxezabwf8MjU=; b=D8oJAe9doR/1vnfE2Cv8YYn5jXiSeaBb5YXQi05UurXCJVqB0TxB8Dgm/TzdCK4BCI ZgS7yDFzLU5SaTZeAhjHwbi5lfbYSFOkd+PWSAGB5SlQuazXkM4D6Q8ZPIIzsrCfCfUN wG/AjNTxVlqSl3q9Ajrcg/Qwrr7bKah1HAfkwc2DD7vBQ6hvDtx3wcVHwz4doOTHwSlF 1dj2DK/xNWIL+a6WboPVkKEpBeT1YgaJCeIdOh3VMSPfOquD75ql2uA2fr0VlSG0dlas m+fEgFkFhlpCIw0DnLazasICKEyiKqqkW3BaYTl18Keda9mWnE/wDnVENlZtOiRxRkL+ icTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780326809; x=1780931609; h=content-transfer-encoding:in-reply-to:references:subject:to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=l1AKZpYX7RXkOvz/l1ikrJX0mnPav1pKxezabwf8MjU=; b=hWse0CGb5GjzBueH3hz1UDnYQHOfVF/Xq/ncaM0J01VHSLk9cLoE6Ntla4crQ0mPH/ okUpvSql90VGxPWtBDuHQ6sHfTHEapx/ZivD6YWn0KQTqap9iik/yVetPgMXaxVRxhEE WsXeTta0QTV5He6/1sTdUOhboR2VoTIUD/gBdjZNPl/N9aBHCe/zSiMoqgtkny6Lj6zN prXfG6AKfuZ8FrZW5e/uSdDnpVP7xS7j5lXY2aRts623zFSfVPnPi7XyHl7yibly7iHC Yr5UGHI2QmFcXEjh/u/cjqHEOaF2RNbn4Oo+siBWYfR3y1e7BmrQhXQVjF83A5Gn4dgO 6BUA== X-Forwarded-Encrypted: i=1; AFNElJ/OCA1lWCQ++cjcRxuyj1Zicl319wGhPfv8HXRykTXixom4S8BNeXGAvIMaH7H7oejuSpxKU+SeUaAiHEs=@vger.kernel.org X-Gm-Message-State: AOJu0YwissZzGhMAVrTXO7LUolPHdvisj5PIsxzGAOEJniL48/RM9lR3 RanhQmlqZHCtIFAcf/F0X1HA/xqJMlD+EnT05wpcixgt2K2V6In7gvDvF/6+UTZef5IJ2aI4B1k oaDxYvGeoYISBEb2OpswBMeQp9k76SsRp/azzaWD0OfNQsqz5xPq302O4QbKYYMXAJQ4= X-Gm-Gg: Acq92OG+7neSsXG0aBstONZNd2LhZAV7WsV1rI+8n+CrvFSyldLPK/4SZfixfPtiPiA teRgPQ8+ccYLgCleu70iDu1OeqF17VjNzCpCd6Hfy/y8bnybGGsjy0OWyCvNX35WlMTEnrZeT49 7TeGYhiK54h5i43CKVEoR/0eyCtkA7ZHS8QSAtaD3DatVDYZlljA55Rl+Lx01f0XqxMMMOfkTq2 jVydFIkdrYDqIWxrGnAYLdaUgyM7R5AICrjOrEZ09Ou1AraJIqTLJXXMmN1nPzUrKv7RHpmeQ7T RcFM4U7CSnCujhGhYXsJg/fAcBdUCsFC2Dfr+nhGbJfimDg81vqNP/dLFkciLzWsdyTzk8kJFBt g/2cWcrolcP6ND5T+xJegjOSi3DTlVSw7u+Bve9DpwOLjnn487sFmcOYs3sD9YG86JqqcNg3yP4 rtwDUdIGGoenhy+uZ15xWIV5yV7BQ= X-Received: by 2002:a05:6a00:2d9e:b0:841:dc85:1638 with SMTP id d2e1a72fcca58-84225700f47mr10727553b3a.42.1780326809362; Mon, 01 Jun 2026 08:13:29 -0700 (PDT) X-Received: by 2002:a05:6a00:2d9e:b0:841:dc85:1638 with SMTP id d2e1a72fcca58-84225700f47mr10727514b3a.42.1780326808761; Mon, 01 Jun 2026 08:13:28 -0700 (PDT) Received: from [10.133.33.66] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84214c9252bsm10691086b3a.39.2026.06.01.08.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2026 08:13:28 -0700 (PDT) Message-ID: Date: Mon, 1 Jun 2026 23:13:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: hangxiang.ma@oss.qualcomm.com To: Loic Poulain , Robert Foss , Todor Tomov , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: qcom: camss: csid: Consolidate CSI2_RX_CFG0_PHY_SEL_BASE_IDX definition References: <20260601-camss-macro-v1-1-cabf1fb99241@oss.qualcomm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 7qVhUayC0XdQ2DXnxLdY2nLVcuslKlZ3 X-Proofpoint-GUID: 7qVhUayC0XdQ2DXnxLdY2nLVcuslKlZ3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAxMDE1MiBTYWx0ZWRfX2KmmAMI/Y4Tz CSqkW+AgQcuu8AxYrgBcsc2u4BepjaItdWuSCdSGU1lnDE9tezgb/U/ywdUivRCzxEFoV60/+3c IDAUyh90ELJbJBfJDWq6HwjaXNbwp/GXUB3HHRfhpgved+VJfTj+ClyQPe4Z7Dxm92a4kapMlQd Cf+ZEn1hD3vCSE0YhvRCRAvvZwL9TnkSqevN7OY5gLJWF4HhjOUuZZbYFUPtfTjOS+kiE2MSNMK 4p/iZzq9Ac9jHcAPnvaDElaFrzKpoFKj5BppjgjRD/PXjVV1TLUFcgNqiZ+VpeYOXPNWj2euLBz 5hTYN6L5O+9NMIVpAVJuHky+nhsNb2LqIqbZbF1OR2rHwiOOFrYEv4OGx7ZvCDS4DCGc/uXngn7 ZzZ8sbGBt4qcgu4sKz3s2SBK4sr3q3uNx0FLIU7FLw8k/kx5lVeNARexs98kD0veFYN/wznZpcE wCPuPUz8bgRAov8wD0g== X-Authority-Analysis: v=2.4 cv=Zo7d7d7G c=1 sm=1 tr=0 ts=6a1da19a cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=oV6xyBMvY1brQq5Mu-QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 impostorscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606010152 On 6/1/26 11:04 PM, Loic Poulain wrote: > On Mon, Jun 1, 2026 at 4:44 PM Hangxiang Ma > wrote: > > > > Move the duplicate CSI2_RX_CFG0_PHY_SEL_BASE_IDX definition from > > camss-csid-680.c and camss-csid-gen3.c into the shared camss-csid.h > > header. This eliminates redundancy and makes the constant available > > to future CSID implementations. > > Taking that direction, I don’t think this is the only instance of > redundancy, so why single out this one in particular? Should we > consider one-line cleanups across all similar cases? Also, other CSID > drivers follow the same pattern but use different identifiers for that > define (e.g. csid-340). > > Also, introducing such low-level, register-aligned naming > (CSI2_RX_CFG0_PHY...) in what is supposed to be a generic > CSID header doesn’t seem appropriate. > > Regards, > Loic > > > > > > > Signed-off-by: Hangxiang Ma > > --- > > Move the duplicate CSI2_RX_CFG0_PHY_SEL_BASE_IDX definition from > > camss-csid-680.c and camss-csid-gen3.c into the shared camss-csid.h > > header. This eliminates redundancy and makes the constant available > > to future CSID implementations. > > --- > > drivers/media/platform/qcom/camss/camss-csid-680.c | 1 - > > drivers/media/platform/qcom/camss/camss-csid-gen3.c | 1 - > > drivers/media/platform/qcom/camss/camss-csid.h | 2 ++ > > 3 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-680.c b/drivers/media/platform/qcom/camss/camss-csid-680.c > > index 345a67c8fb94..bf7164085ddb 100644 > > --- a/drivers/media/platform/qcom/camss/camss-csid-680.c > > +++ b/drivers/media/platform/qcom/camss/camss-csid-680.c > > @@ -101,7 +101,6 @@ > > #define CSI2_RX_CFG0_DL2_INPUT_SEL 12 > > #define CSI2_RX_CFG0_DL3_INPUT_SEL 16 > > #define CSI2_RX_CFG0_PHY_NUM_SEL 20 > > -#define CSI2_RX_CFG0_PHY_SEL_BASE_IDX 1 > > #define CSI2_RX_CFG0_PHY_TYPE_SEL 24 > > #define CSI2_RX_CFG0_TPG_MUX_EN BIT(27) > > #define CSI2_RX_CFG0_TPG_MUX_SEL GENMASK(29, 28) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen3.c b/drivers/media/platform/qcom/camss/camss-csid-gen3.c > > index 0fdbf75fb27d..da9458cd178b 100644 > > --- a/drivers/media/platform/qcom/camss/camss-csid-gen3.c > > +++ b/drivers/media/platform/qcom/camss/camss-csid-gen3.c > > @@ -105,7 +105,6 @@ > > #define CSID_RDI_IRQ_SUBSAMPLE_PERIOD(rdi) (csid_is_lite(csid) && IS_CSID_690(csid) ?\ > > (0x34C + 0x100 * (rdi)) :\ > > (0x54C + 0x100 * (rdi))) > > -#define CSI2_RX_CFG0_PHY_SEL_BASE_IDX 1 > > > > static void __csid_configure_rx(struct csid_device *csid, > > struct csid_phy_config *phy, int vc) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid.h b/drivers/media/platform/qcom/camss/camss-csid.h > > index 5296b10f6bac..059ac94ad1be 100644 > > --- a/drivers/media/platform/qcom/camss/camss-csid.h > > +++ b/drivers/media/platform/qcom/camss/camss-csid.h > > @@ -27,6 +27,8 @@ > > /* CSID hardware can demultiplex up to 4 outputs */ > > #define MSM_CSID_MAX_SRC_STREAMS 4 > > > > +/* CSIPHY to hardware PHY selector mapping */ > > +#define CSI2_RX_CFG0_PHY_SEL_BASE_IDX 1 > > #define CSID_RESET_TIMEOUT_MS 500 > > > > enum csid_testgen_mode { > > > > --- > > base-commit: 697a0e31ee66f5ddb929c09895139779fff33f20 > > change-id: 20260601-camss-macro-3d40c4d4e90d > > > > Best regards, > > -- > > Hangxiang Ma > > > Thanks Loic, Bryan pointed this out in last review cycle and suggested to split it as a standalone series. This idea comes from KNP series as I was once suggested to move this macro into one common header to remove redundancy. I think your are correct after fully consideration. I will make changes only for KNP and put it in driver. Best regards, Hangxiang