Re: [PATCH v3] dt-bindings: mmc: ti-omap2420-mmc: convert text based binding to json schema

[Charan Pedumuru <charan.pedumuru@gmail.com>]

On 20-05-2025 19:39, Krzysztof Kozlowski wrote:
> On 20/05/2025 15:12, Charan Pedumuru wrote:
>> Convert TI MMC host controller binding to YAML format.
>> Changes during Conversion:
>> - Add new properties 'dma', 'dma-names' under required.
> 
> Why?

Actually, dma and dma-names can be removed from required, so there is no need to add any new properties to required. I will remove them.

> 
>> - Define two separate phandles for 'dmas' in the examples.
>> - Include appropriate header file for interrupts and use
>>   it in the examples.
> 
> Examples are not the binding, so you can drop last two items.
> 
>>
>> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
>> ---
>> Changes in v3:
> 
> 
> ...
> 
>> +  dmas:
>> +    maxItems: 2
>> +
>> +  dma-names:
>> +    items:
>> +      - const: tx
>> +      - const: rx
>> +
>> +  ti,hwmods:
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +    description:
>> +      List of hwmod names (ascii strings), that comes from the OMAP
>> +      HW documentation, attached to a device. Must contain at least
>> +      one hwmod.
> 
> Description does not match the property. It is not a list and where the
> hwmod below:


Sure, will change the description.

> 
>> +    pattern: "^msdi[0-9]+$"
> 
> I see msdi - is it something different?
> 
> There was no such description in original binding, so maybe you are
> changing something but anyway it should be correct.

Normally, it should be mmc, but for this particular binding it is msdi or do we need to change it to mmc for ti,hwmods property in dts and redefine the pattern here?

> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - dmas
>> +  - dma-names
>> +  - ti,hwmods
> Best regards,
> Krzysztof

-- 
Best Regards,
Charan.