From: Helge Deller <deller@gmx.de>
To: Helge Deller <deller@kernel.org>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_pci: Fix Warning at drivers/pci/devres.c:603 pcim_add_mapping_to_legacy_table
Date: Mon, 27 Jan 2025 14:14:13 +0100 [thread overview]
Message-ID: <ac39e075-ad59-41ba-b47f-59085269ccfa@gmx.de> (raw)
In-Reply-To: <Z5XmLKzhKpLAlzHt@p100>
On 1/26/25 08:37, Helge Deller wrote:
> Some PA-RISC servers have BMC management cards (Diva) with up to 5 serial
> UARTS per memory PCI bar. This triggers since at least kernel 6.12 for each of
> the UARTS (beside the first one) the following warning in devres.c:
...
>
> I see three options to avoid this warning:
> a) drop the WARNING() from devrec.c,
> b) modify pcim_iomap() to return an existing mapping if it exists
> instead of creating a new mapping, or
> c) change serial8250_pci_setup_port() to only create a new mapping
> if none exists yet.
>
> This patch implements option c).
Please ignore this patch as it behaves wrong.
I'll send an updated patch.
Helge
next prev parent reply other threads:[~2025-01-27 13:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 7:37 Helge Deller
2025-01-27 13:14 ` Helge Deller [this message]
2025-02-06 14:35 ` Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac39e075-ad59-41ba-b47f-59085269ccfa@gmx.de \
--to=deller@gmx.de \
--cc=bhelgaas@google.com \
--cc=deller@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®