From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E52C4332D for ; Fri, 20 Mar 2020 17:29:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEB4B20722 for ; Fri, 20 Mar 2020 17:28:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727238AbgCTR26 (ORCPT ); Fri, 20 Mar 2020 13:28:58 -0400 Received: from mx2.suse.de ([195.135.220.15]:40238 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727176AbgCTR25 (ORCPT ); Fri, 20 Mar 2020 13:28:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E1AF1AC84; Fri, 20 Mar 2020 17:28:55 +0000 (UTC) Subject: Re: [PATCH] mm/compaction.c: Clean code by removing unnecessary assignment To: mateusznosek0@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org References: <20200318174509.15021-1-mateusznosek0@gmail.com> From: Vlastimil Babka Message-ID: Date: Fri, 20 Mar 2020 18:28:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200318174509.15021-1-mateusznosek0@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/18/20 6:45 PM, mateusznosek0@gmail.com wrote: > From: Mateusz Nosek > > Previously 0 was assigned to variable 'last_migrated_pfn'. But the > variable is not read after that, so the assignment can be removed. > > Signed-off-by: Mateusz Nosek Acked-by: Vlastimil Babka > --- > mm/compaction.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 827d8a2b3164..4576d6c5afb5 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2183,7 +2183,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > ret = COMPACT_CONTENDED; > putback_movable_pages(&cc->migratepages); > cc->nr_migratepages = 0; > - last_migrated_pfn = 0; > goto out; > case ISOLATE_NONE: > if (update_cached) { >