From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751698AbdKVPtN (ORCPT ); Wed, 22 Nov 2017 10:49:13 -0500 Received: from mout.web.de ([217.72.192.78]:58998 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbdKVPtL (ORCPT ); Wed, 22 Nov 2017 10:49:11 -0500 Subject: [PATCH 1/3] ASoC: cs42l73: Delete an error message for a failed memory allocation in cs42l73_i2c_probe() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Brian Austin , Jaroslav Kysela , Liam Girdwood , Mark Brown , Paul Handrigan , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: <609e2542-4750-fe60-4f42-08bca79bfb56@users.sourceforge.net> Message-ID: Date: Wed, 22 Nov 2017 16:48:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <609e2542-4750-fe60-4f42-08bca79bfb56@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:y5is0LLd5dq+2J0BNoqm5dWVuqJFGRKuvM4zERt+y4sXewJ6cPB QKArHGtWUxiBr0I7qpEtc+2LgmV8QHP0FaRxetFBQ2DZGNIoRM7+YBzg3JGvxMaStJVsdP1 57pGkfqGgF+h2wy7fsKEeUTmqE+qxeHi0XW9NrXeOVdLATAsR39l14OXyTMGjx1tUmdzvM0 rEgDjT5kFQtXtloO4EyqA== X-UI-Out-Filterresults: notjunk:1;V01:K0:CL8R0GdJigs=:jfrCmZxfRIgO+TVL4wT3Jl Tq/6QIWhIENEH6V8QcEUI92pSkY1adt2uXBaDqTd2qzah2+WjzX1lGugnIV64uIBRgCtBKw+g sA0zlcnfulCmJjTAqyXwbcI598ZYFDWSOkXb616XNnbbb+7/nOt6x5qAdgPWbwx/iv6gTSCkQ FnAMP54Ds17jJzfUl0vA/p4EzcA5Dhiq7O1ZTl9Wb9AS+c/O+O0Rpf2Ft3vUAmZfEHHoxO0do vV2vKcb/NugqHsSuVV4Qc84lojZYEGor4wKGeIeWFrW4M7z6bhCnphebqiG069KN+WTSLrPFl 37wuQ5HJjhZKjLKK2scpfdSyLsdszQcdvEyqgifZCc3N/l5aiMPV3loAGMOWcv2aXEjmMe1iQ isDaIo6O5307Vz98Lv6Wn23tx6afc3KT9Vvb1+YiSCG8SdJjyPbcRwbEaDR//CcS/MuSG1QXa cMvzUZZRS3r88WqHk8K3CYS9t7O/fXgGE90ON3oLL/ia4lUGQtD5ZSh4mjgteZruCyZ7okD6m jErVzsJn+Fz0IsE+nGnp29qHsZ356J0qGODt3cPEJxpe+4/ZOL55+a7crDVf5Vg9KE38m2+Q7 Qw1WzLJNIoZbQWuxXLAh8W493ziwslmX6FWSc3tr0fLNJcqN0mfYj8tsFvdqXA2AI5TBAYFjK i8R/OjCxiCBWKd4dZHKmMvw7Ef4OvSsvxZw47REUPQ0LyBoDcRtbVi6faosv5hb3WAU1k/k4e DBdt+IDOj9lwI1pQyhEiLGu/s6pQmzhITUJ7n1A9i+frywNo5FW6Ij41H/hqIxc2ZbngrwyyL opsSEB3jQ+VtYP3W9tPG/tlK8rZWsDKG18xVTOtcL8kaIvTZAE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 22 Nov 2017 15:50:46 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/codecs/cs42l73.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c index 3df2c473ab88..978cfbbad408 100644 --- a/sound/soc/codecs/cs42l73.c +++ b/sound/soc/codecs/cs42l73.c @@ -1307,10 +1307,9 @@ static int cs42l73_i2c_probe(struct i2c_client *i2c_client, pdata = devm_kzalloc(&i2c_client->dev, sizeof(struct cs42l73_platform_data), GFP_KERNEL); - if (!pdata) { - dev_err(&i2c_client->dev, "could not allocate pdata\n"); + if (!pdata) return -ENOMEM; - } + if (i2c_client->dev.of_node) { if (of_property_read_u32(i2c_client->dev.of_node, "chgfreq", &val32) >= 0) -- 2.15.0