Re: edac: struct device - replace bus_id with dev_name(), dev_set_name()

["Kay Sievers" <kay.sievers@vrfy.org>]

On Mon, Nov 3, 2008 at 23:57, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 30 Oct 2008 01:39:05 +0100
> Kay Sievers <kay.sievers@vrfy.org> wrote:
>
>> Subject: edac: struct device - replace bus_id with dev_name(), dev_set_name()
>
> um,
>
> ERROR: space required after that ',' (ctx:VxV)
> #40: FILE: drivers/edac/edac_mc.c:404:
> +               "%s (%s) %s %s already assigned %d\n",dev_name( p->dev),
>                                                     ^
>
> ERROR: space prohibited after that open parenthesis '('
> #40: FILE: drivers/edac/edac_mc.c:404:
> +               "%s (%s) %s %s already assigned %d\n",dev_name( p->dev),
>
>
> where did this crap come from?  It looks like some automated thing
> placed a space at the wrong end of the string?
>
> If so, are we about to send hundreds of such mistakes into the tree?

It was me feeling automated, maybe 4 am in the morning.
It's only one instance in the ~60 patches I have so far:
  $ cat * | wc -l
  7255

  $ grep '( ' *
  bus_id-edac.patch:+		"%s (%s) %s %s already assigned %d\n",dev_name( p->dev),

Sorry for that.

Thanks,
Kay