From: "Kay Sievers" <kay.sievers@vrfy.org>
To: "Al Viro" <viro@zeniv.linux.org.uk>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
gregkh@suse.de, petero2@telia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix pktcdvd breakage from commit e105b8bfc769b0545b6f0f395179d1e43cbee822
Date: Sun, 30 Nov 2008 14:41:11 +0100 [thread overview]
Message-ID: <ac3eb2510811300541t660b7a9fsd44f5634cbd8028b@mail.gmail.com> (raw)
In-Reply-To: <20081130133229.GZ28946@ZenIV.linux.org.uk>
On Sun, Nov 30, 2008 at 14:32, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Sun, Nov 30, 2008 at 02:25:43PM +0100, Kay Sievers wrote:
>
>> Pktcdvd creates char _and_ block device nodes at the same time, while
>> the char nodes are not allocated, but created and conflict in
>> /sys/dev/ with properly allocated ones from other subsystems. Your
>> patch just papers over this bug.
>
> Where the hell is it creating any char device nodes? Show me.
Here the hell it is:
pd->dev = device_create(class_pktcdvd, NULL, pd->pkt_dev, NULL,
"%s", pd->name);
The bogus "pkt_dev", it's a char dev_t value, but because the char
dev_t value is already validly used by other subsystems, it will cause
the broken /sys/dev/ link. That's the real bug.
Kay
prev parent reply other threads:[~2008-11-30 13:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-30 12:19 Al Viro
2008-11-30 12:41 ` Kay Sievers
2008-11-30 13:21 ` Al Viro
2008-11-30 13:25 ` Kay Sievers
2008-11-30 13:32 ` Al Viro
2008-11-30 13:40 ` Al Viro
2008-11-30 13:44 ` Kay Sievers
2008-11-30 13:50 ` Al Viro
2008-11-30 13:57 ` Kay Sievers
2008-11-30 14:13 ` Al Viro
2008-11-30 14:28 ` Kay Sievers
2008-11-30 14:52 ` Al Viro
2008-11-30 15:53 ` Al Viro
2008-11-30 15:56 ` Kay Sievers
2008-12-05 2:57 ` Kay Sievers
2008-12-06 3:38 ` Kay Sievers
2008-12-09 21:57 ` Peter Osterlund
2008-11-30 13:41 ` Kay Sievers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac3eb2510811300541t660b7a9fsd44f5634cbd8028b@mail.gmail.com \
--to=kay.sievers@vrfy.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®