mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: Greg KH <gregkh@suse.de>
Cc: Grant Likely <grant.likely@secretlab.ca>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Export device_add_attributes() so drivers can use it.
Date: Wed, 18 Feb 2009 16:45:08 +0100	[thread overview]
Message-ID: <ac3eb2510902180745v2886ae31s2d7faeb2faedab6e@mail.gmail.com> (raw)
In-Reply-To: <20090218152913.GA26448@suse.de>

On Wed, Feb 18, 2009 at 16:29, Greg KH <gregkh@suse.de> wrote:
> On Wed, Feb 18, 2009 at 08:11:34AM -0700, Grant Likely wrote:
>> From: Grant Likely <grant.likely@secretlab.ca>
>>
>> I find myself using the pattern of device_add_attributes() and
>> device_remove_attributes() frequently in my drivers.  Rather than
>> reinventing the wheel every time, I'm floating this patch to export
>> the symbols to see how it is received.  If this looks okay then I'll
>> rework my drivers and post additional patches to use these functions.
>
> No objection from me, as long as the symbols are EXPORT_SYMBOL_GPL(),
> like the rest of the driver core.  Is that ok with you?

These functions used outside the core create attributes after the
uevent is sent, and userspace will not see these files at event time.
This is in most cases a pretty broken behavior. Is that the expected
behavior in your drivers?

Thanks,
Kay

  reply	other threads:[~2009-02-18 15:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18 15:11 Grant Likely
2009-02-18 15:29 ` Greg KH
2009-02-18 15:45   ` Kay Sievers [this message]
2009-02-18 15:48     ` Grant Likely
2009-02-18 15:53       ` Kay Sievers
2009-02-18 16:34         ` Grant Likely
2009-02-18 16:49           ` Kay Sievers
2009-02-18 17:51             ` Grant Likely
2009-02-18 18:32               ` Kay Sievers
2009-02-18 18:39                 ` Greg KH
2009-02-18 19:14                   ` Kay Sievers
2009-02-19  6:50                   ` Grant Likely
2009-02-19 23:08                     ` Kay Sievers
2009-02-20 15:28                       ` Grant Likely
2009-02-20 18:35                         ` Greg KH
2009-02-26 22:28                         ` Kay Sievers
2009-02-26 23:52                           ` Grant Likely
2009-02-18 15:46   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac3eb2510902180745v2886ae31s2d7faeb2faedab6e@mail.gmail.com \
    --to=kay.sievers@vrfy.org \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome