From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762114AbZDQR4a (ORCPT ); Fri, 17 Apr 2009 13:56:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756294AbZDQR4U (ORCPT ); Fri, 17 Apr 2009 13:56:20 -0400 Received: from mail-bw0-f163.google.com ([209.85.218.163]:36346 "EHLO mail-bw0-f163.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753534AbZDQR4T (ORCPT ); Fri, 17 Apr 2009 13:56:19 -0400 X-Greylist: delayed 6754 seconds by postgrey-1.27 at vger.kernel.org; Fri, 17 Apr 2009 13:56:18 EDT MIME-Version: 1.0 In-Reply-To: <49E8BFB2.50608@vlnb.net> References: <49E7307A.8000205@vlnb.net> <49E77795.7080204@linux.vnet.ibm.com> <49E85F1C.7040106@vlnb.net> <49E8832F.6070302@linux.vnet.ibm.com> <49E88E3F.8030107@vlnb.net> <49E891C8.1050007@emulex.com> <49E8BFB2.50608@vlnb.net> From: Kay Sievers Date: Fri, 17 Apr 2009 19:56:02 +0200 Message-ID: Subject: Re: [Scst-devel] Discussion about SCST sysfs layout and implementation. To: Vladislav Bolkhovitin Cc: James Smart , Daniel Debonzi , "scst-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 17, 2009 at 19:43, Vladislav Bolkhovitin wrote: > Thank you for the suggestion. If nobody objects, we will go with > /sys/class/scst_tgt. On Fri, Apr 17, 2009 at 19:43, Vladislav Bolkhovitin wrote: > I agree, looks like using struct device instead of struct kobject should > additionally complicate the code a lot for not clear gain. Thes both replies together suggest that you miss how sysfs and the driver core works. Please go and read the current code, and look at sysfs, before trying anything like this. There is no way to add any stuff to /sys/class/scst_tgt/ without using proper "struct device" objects. For the same reason we will not have a disconnected device tree, we will not havet any raw kobject in the /sys/devices, /sys/class, /sys/bus directories. Thanks, Kay